headers
Matthew Ranostay | 5 Sep 20:52

[PATCH] hda: SPDIF mux controls


Dynamically create mux controls for SPDIF outs on certain IDT/Sigmatel codecs.

---
Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>

diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
index 9968ee4..4637d76 100644
--- a/pci/hda/patch_sigmatel.c
+++ b/pci/hda/patch_sigmatel.c
@@ -173,6 +173,9 @@ struct sigmatel_spec {
 	unsigned int num_dmics;
 	hda_nid_t *dmux_nids;
 	unsigned int num_dmuxes;
+	hda_nid_t *smux_nids;
+	unsigned int num_smuxes;
+
 	hda_nid_t dig_in_nid;
 	hda_nid_t mono_nid;
 	hda_nid_t anabeep_nid;
@@ -193,6 +196,8 @@ struct sigmatel_spec {
 	unsigned int cur_dmux[2];
 	struct hda_input_mux *input_mux;
 	unsigned int cur_mux[3];
+	struct hda_input_mux *sinput_mux;
+	unsigned int cur_smux[2];
 	unsigned int powerdown_adcs;

 	/* i/o switches */
@@ -209,6 +214,7 @@ struct sigmatel_spec {
(Continue reading)

Permalink | Reply |
headers
Takashi Iwai | 7 Sep 12:23
Favicon

Re: [PATCH] hda: SPDIF mux controls

At Fri, 05 Sep 2008 14:55:02 -0400,
Matthew Ranostay wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Dynamically create mux controls for SPDIF outs on certain IDT/Sigmatel codecs.
> 
> - ---
> Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>

Thanks, applied.

One concern is whether "IEC958 Mux" is the right name for this.
Maybe something like "IEC958 Capture Source" would be more intuitive.
However, note that "Capture Source" name is often problematic for
multiple instances due to a bug (or a feature) of alsa-lib mixer
abstraction.  (That's why "Input Source" is used in many HD-audio
codes.)

Takashi

> 
> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
> index 9968ee4..4637d76 100644
> - --- a/pci/hda/patch_sigmatel.c
> +++ b/pci/hda/patch_sigmatel.c
> @@ -173,6 +173,9 @@ struct sigmatel_spec {
>  	unsigned int num_dmics;
>  	hda_nid_t *dmux_nids;
(Continue reading)

Permalink | Reply |
headers
Matthew Ranostay | 7 Sep 17:17

Re: [PATCH] hda: SPDIF mux controls


Takashi Iwai wrote:
> At Fri, 05 Sep 2008 14:55:02 -0400,
> Matthew Ranostay wrote:
> Dynamically create mux controls for SPDIF outs on certain IDT/Sigmatel codecs.
> 
> ---
> Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>
> 
>> Thanks, applied.
> 
>> One concern is whether "IEC958 Mux" is the right name for this.
>> Maybe something like "IEC958 Capture Source" would be more intuitive.
Ah but it isn't a capture source mux it's actually for the output SPDIF's.

Matt

>> However, note that "Capture Source" name is often problematic for
>> multiple instances due to a bug (or a feature) of alsa-lib mixer
>> abstraction.  (That's why "Input Source" is used in many HD-audio
>> codes.)
> 
> 
>> Takashi
> 
> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
> index 9968ee4..4637d76 100644
> --- a/pci/hda/patch_sigmatel.c
> +++ b/pci/hda/patch_sigmatel.c
> @@ -173,6 +173,9 @@ struct sigmatel_spec {
(Continue reading)

Permalink | Reply |
headers
Takashi Iwai | 8 Sep 16:26
Favicon

Re: [PATCH] hda: SPDIF mux controls

At Sun, 07 Sep 2008 11:17:47 -0400,
Matthew Ranostay wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Takashi Iwai wrote:
> > At Fri, 05 Sep 2008 14:55:02 -0400,
> > Matthew Ranostay wrote:
> > Dynamically create mux controls for SPDIF outs on certain IDT/Sigmatel codecs.
> > 
> > ---
> > Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>
> > 
> >> Thanks, applied.
> > 
> >> One concern is whether "IEC958 Mux" is the right name for this.
> >> Maybe something like "IEC958 Capture Source" would be more intuitive.
> Ah but it isn't a capture source mux it's actually for the output SPDIF's.

OK, then it can be "IEC958 Playback Source".

Takashi

> 
> - - Matt
> 
> >> However, note that "Capture Source" name is often problematic for
> >> multiple instances due to a bug (or a feature) of alsa-lib mixer
> >> abstraction.  (That's why "Input Source" is used in many HD-audio
(Continue reading)

Permalink | Reply |

Gmane