[PATCH] phase and juli coding style fixes (more coming up)

From my signoff:

From b4a282ae0d54087bc152571c250afcd57fa9fa38 Mon Sep 17 00:00:00 2001
From: Vedran Miletic <rivanvx <at> gmail.com>
Date: Sun, 7 Sep 2008 11:22:35 +0200
Subject: [PATCH] ALSA: ice1712/ice1724: Coding style fixes part 1
(more coming up)

Inspired by Alexander Beregalov's patches for wtm and aureon.c,
I decided to run checkpatch on some more files. After some work
checkpatch.pl-0.23 --no-tree --file --strict <file> reports
0 errors, 0 warnings, 0 checks, n lines checked for:
phase.c
phase.h
juli.c (1 check about unused code, maybe we should comment it)
juli.h (no changes necessary)
In other files I have just fixed // comments and long lines along the
way (but not all of them), more coming up.

Signed-off-by: Vedran Miletic <rivanvx <at> gmail.com>

Patch is attached.

--

-- 
Vedran Miletić
_______________________________________________
Alsa-devel mailing list
(Continue reading)

Takashi Iwai | 7 Sep 12:21
Favicon

Re: [PATCH] phase and juli coding style fixes (more coming up)

At Sun, 7 Sep 2008 11:39:10 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> From my signoff:
> 
> From b4a282ae0d54087bc152571c250afcd57fa9fa38 Mon Sep 17 00:00:00 2001
> From: Vedran Miletic <rivanvx <at> gmail.com>
> Date: Sun, 7 Sep 2008 11:22:35 +0200
> Subject: [PATCH] ALSA: ice1712/ice1724: Coding style fixes part 1
> (more coming up)
> 
> Inspired by Alexander Beregalov's patches for wtm and aureon.c,
> I decided to run checkpatch on some more files. After some work
> checkpatch.pl-0.23 --no-tree --file --strict <file> reports
> 0 errors, 0 warnings, 0 checks, n lines checked for:
> phase.c
> phase.h
> juli.c (1 check about unused code, maybe we should comment it)
> juli.h (no changes necessary)
> In other files I have just fixed // comments and long lines along the
> way (but not all of them), more coming up.
> 
> Signed-off-by: Vedran Miletic <rivanvx <at> gmail.com>
> 
> Patch is attached.

Thanks.  Applied now.

BTW, there was a typo in your patch that broke the compile.
Please check the build properly before submitting the patch.
(Continue reading)

Re: [PATCH] phase and juli coding style fixes (more coming up)

Sorry for missing that one, I'm not able to compile alsa for some
reason. Some change in alsa-kmirror don't work with current
alsa-driver on my 2.6.26 kernel.

I will be more careful next time. Just wondering, what did I miss?

BTW, I was wondering: do you sync your tree (sound-2.6 or
sound-unstable-2.6) with 2.6.27 Linus's tree? Because, if that's the
case, then I might be tempted to switch to using that tree as my
"everyday kernel".

2008/9/7 Takashi Iwai <tiwai <at> suse.de>:
> Thanks.  Applied now.
>
> BTW, there was a typo in your patch that broke the compile.
> Please check the build properly before submitting the patch.
>
>
> Takashi
>
--

-- 
Vedran Miletić
_______________________________________________
Alsa-devel mailing list
Alsa-devel <at> alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Takashi Iwai | 7 Sep 12:45
Favicon

Re: [PATCH] phase and juli coding style fixes (more coming up)

At Sun, 7 Sep 2008 12:29:08 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> Sorry for missing that one, I'm not able to compile alsa for some
> reason. Some change in alsa-kmirror don't work with current
> alsa-driver on my 2.6.26 kernel.

Don't use alsa-kmirror then.  The submitted patch should have been
tested properly.  If untested, please describe it clearly.

> I will be more careful next time. Just wondering, what did I miss?

A missing semicolon in a line.

> BTW, I was wondering: do you sync your tree (sound-2.6 or
> sound-unstable-2.6) with 2.6.27 Linus's tree? Because, if that's the
> case, then I might be tempted to switch to using that tree as my
> "everyday kernel".

The standard procedure is to pull the upstream tree onto yours.
That is, run

   % git pull git://git.kernel.org/pub/.../tiwai/sound-2.6.git master

then the changes in sound-2.6.git tree will be merged into yours.

 
Takashi

> 2008/9/7 Takashi Iwai <tiwai <at> suse.de>:
(Continue reading)


Gmane