gmane.linux.alsa.devel

[PATCH] ice1712.c: fix coding style

before:
total: 113 errors, 169 warnings, 2786 lines checked
total: 26 errors, 24 warnings, 504 lines checked

after:
total: 14 errors, 163 warnings, 2799 lines checked
total: 0 errors, 24 warnings, 504 lines checked

Compile tested only.

Signed-off-by: Alexander Beregalov <a.beregalov <at> gmail.com>
---

 sound/pci/ice1712/ice1712.c |  237 +++++++++++++++++++++++--------------------
 sound/pci/ice1712/ice1712.h |   52 +++++-----
 2 files changed, 151 insertions(+), 138 deletions(-)

diff --git a/sound/pci/ice1712/ice1712.c b/sound/pci/ice1712/ice1712.c
index 05ffab6..5b44238 100644
--- a/sound/pci/ice1712/ice1712.c
+++ b/sound/pci/ice1712/ice1712.c
@@ -17,7 +17,7 @@
  *   along with this program; if not, write to the Free Software
  *   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
  *
- */      
+ */

 /*
   NOTES:

(Continue reading)

headers

Takashi Iwai | 7 Sep 12:28

Re: [PATCH] ice1712.c: fix coding style

At Sun, 7 Sep 2008 14:17:02 +0400,
Alexander Beregalov wrote:
> 
> before:
> total: 113 errors, 169 warnings, 2786 lines checked
> total: 26 errors, 24 warnings, 504 lines checked
> 
> after:
> total: 14 errors, 163 warnings, 2799 lines checked
> total: 0 errors, 24 warnings, 504 lines checked
> 
> Compile tested only.
> 
> Signed-off-by: Alexander Beregalov <a.beregalov <at> gmail.com>

Applied, too.

But, before submitting the next: if you are sending a series of patches,
please add [PATCH xx/yy] in the subject, so that I can wait for all
patches.

Thanks,

Takashi

> ---
> 
>  sound/pci/ice1712/ice1712.c |  237 +++++++++++++++++++++++--------------------
>  sound/pci/ice1712/ice1712.h |   52 +++++-----
>  2 files changed, 151 insertions(+), 138 deletions(-)

(Continue reading)

headers

Alexander Beregalov | 7 Sep 12:35

Re: [PATCH] ice1712.c: fix coding style

2008/9/7 Takashi Iwai <tiwai <at> suse.de>:
> But, before submitting the next: if you are sending a series of patches,
> please add [PATCH xx/yy] in the subject, so that I can wait for all
> patches.
Ok, thanks.
Is that also needed for patches which are not depended from each other?

headers

Takashi Iwai | 7 Sep 12:48

Re: [PATCH] ice1712.c: fix coding style

At Sun, 7 Sep 2008 14:35:46 +0400,
Alexander Beregalov wrote:
> 
> 2008/9/7 Takashi Iwai <tiwai <at> suse.de>:
> > But, before submitting the next: if you are sending a series of patches,
> > please add [PATCH xx/yy] in the subject, so that I can wait for all
> > patches.
> Ok, thanks.
> Is that also needed for patches which are not depended from each other?

If you send multiple patches at once, then it'd be helpful.  Then I
would notice more easily if any patch is missing.

Of course, this isn't a strict rule.  That is, it'd be nice if you
can give some information that any patches are pending.

thanks,

Takashi