headers
"Vedran =?iso-8859-2?q?Mileti=E6=22?= | 7 Sep 17:06

[PATCH] ice1712 drivers coding style fixes (part 2)

I started with Takashi's sound-unstable tree as a base:
Fixed:
* ice1724 compilation error (one { too much)
* checkpatch errors along the files

sound/pci/ice1712/ak4xxx.c total: 1 errors, 3 warnings, 0 checks, 196
lines checked
sound/pci/ice1712/amp.h total: 0 errors, 0 warnings, 1 checks, 51 lines checked
sound/pci/ice1712/aureon.c total: 0 errors, 121 warnings, 3 checks,
2284 lines checked
sound/pci/ice1712/aureon.h total: 0 errors, 1 warnings, 0 checks, 65
lines checked
sound/pci/ice1712/delta.c total: 17 errors, 44 warnings, 1 checks, 817
lines checked
sound/pci/ice1712/delta.h total: 0 errors, 8 warnings, 0 checks, 153
lines checked
sound/pci/ice1712/envy24ht.h total: 0 errors, 21 warnings, 0 checks,
221 lines checked
sound/pci/ice1712/ews.c total: 27 errors, 64 warnings, 2 checks, 1087
lines checked
sound/pci/ice1712/ews.h total: 0 errors, 7 warnings, 0 checks, 86 lines checked
sound/pci/ice1712/hoontech.c total: 13 errors, 10 warnings, 1 checks,
360 lines checked
sound/pci/ice1712/hoontech.h total: 2 errors, 7 warnings, 0 checks, 77
lines checked
sound/pci/ice1712/ice1712.c total: 14 errors, 162 warnings, 3 checks,
2799 lines checked
sound/pci/ice1712/ice1712.h total: 0 errors, 22 warnings, 3 checks,
511 lines checked
sound/pci/ice1712/ice1724.c total: 11 errors, 62 warnings, 8 checks,
(Continue reading)

Permalink | Reply |
headers
Takashi Iwai | 8 Sep 16:28
Favicon

Re: [PATCH] ice1712 drivers coding style fixes (part 2)

At Sun, 7 Sep 2008 17:07:39 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> I started with Takashi's sound-unstable tree as a base:

Oh, please base on sound-2.6 tree.  The unstable tree is really
unstable, not for upstream merge.

> Fixed:
> * ice1724 compilation error (one { too much)

Well, I already applied your first one, so this version conflicts.
Please re-create from the latest sound-2.6.git tree.

thanks,

Takashi
Permalink | Reply |
headers
"Vedran =?iso-8859-2?q?Mileti=E6=22?= | 8 Sep 19:41

Re: [PATCH] ice1712 drivers coding style fixes (part 2)

2008/9/8 Takashi Iwai <tiwai <at> suse.de>:
> At Sun, 7 Sep 2008 17:07:39 +0200,
> =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
>>
>> I started with Takashi's sound-unstable tree as a base:
>
> Oh, please base on sound-2.6 tree.  The unstable tree is really
> unstable, not for upstream merge.
Ok, thanks for clarification. Will do.
>
>> Fixed:
>> * ice1724 compilation error (one { too much)
>
> Well, I already applied your first one, so this version conflicts.
> Please re-create from the latest sound-2.6.git tree.
I know this isn't a place to ask for git lessons, but is there a way
to do it semi-automagically with git?
>
> thanks,
>
> Takashi
>

--

-- 
Vedran Miletić
_______________________________________________
Alsa-devel mailing list
Alsa-devel <at> alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
(Continue reading)

Permalink | Reply |
headers
Takashi Iwai | 8 Sep 23:51
Favicon

Re: [PATCH] ice1712 drivers coding style fixes (part 2)

At Mon, 8 Sep 2008 19:41:11 +0200,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> 2008/9/8 Takashi Iwai <tiwai <at> suse.de>:
> > At Sun, 7 Sep 2008 17:07:39 +0200,
> > =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> >>
> >> I started with Takashi's sound-unstable tree as a base:
> >
> > Oh, please base on sound-2.6 tree.  The unstable tree is really
> > unstable, not for upstream merge.
> Ok, thanks for clarification. Will do.
> >
> >> Fixed:
> >> * ice1724 compilation error (one { too much)
> >
> > Well, I already applied your first one, so this version conflicts.
> > Please re-create from the latest sound-2.6.git tree.
> I know this isn't a place to ask for git lessons, but is there a way
> to do it semi-automagically with git?

Usually, pull the upstream, and rebase your changes onto it.
In your case, just doing git-cherry-pick would suffice because
it's a single patch anyway.

Takashi
Permalink | Reply |

Gmane