headers
Matthew Ranostay | 7 Sep 20:35

[PATCH1/1] hda: digital slave support for IDT codecs

Added slave_dig_outs entries for several IDT codecs that have multiple
SPDIF outs, and enabled these SPDIF outs in several pin configs.

---
Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>

diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
index 9968ee4..52b3579 100644
--- a/pci/hda/patch_sigmatel.c
+++ b/pci/hda/patch_sigmatel.c
@@ -229,6 +229,10 @@ static hda_nid_t stac92hd73xx_pwr_nids[8] = {
 	0x0f, 0x10, 0x11
 };

+static hda_nid_t stac92hd73xx_slave_dig_outs[2] = {
+	0x26, 0,
+};
+
 static hda_nid_t stac92hd73xx_adc_nids[2] = {
 	0x1a, 0x1b
 };
@@ -274,6 +278,10 @@ static hda_nid_t stac92hd83xxx_pwr_nids[4] = {
 	0xa, 0xb, 0xd, 0xe,
 };

+static hda_nid_t stac92hd83xxx_slave_dig_outs[2] = {
+	0x1e, 0,
+};
+
 static unsigned int stac92hd83xxx_pwr_mapping[4] = {
(Continue reading)

Permalink | Reply |
headers
Takashi Iwai | 8 Sep 16:23
Favicon

Re: [PATCH1/1] hda: digital slave support for IDT codecs

At Sun, 07 Sep 2008 14:36:53 -0400,
Matthew Ranostay wrote:
> 
> Added slave_dig_outs entries for several IDT codecs that have multiple
> SPDIF outs, and enabled these SPDIF outs in several pin configs.
> 
> ---
> Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>

This patch seems not applicable.
Could you rebuild from my latest git tree?
Note that the core changes for slave SPDIF was already added.

thanks,

Takashi

> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
> index 9968ee4..52b3579 100644
> --- a/pci/hda/patch_sigmatel.c
> +++ b/pci/hda/patch_sigmatel.c
> @@ -229,6 +229,10 @@ static hda_nid_t stac92hd73xx_pwr_nids[8] = {
>  	0x0f, 0x10, 0x11
>  };
> 
> +static hda_nid_t stac92hd73xx_slave_dig_outs[2] = {
> +	0x26, 0,
> +};
> +
>  static hda_nid_t stac92hd73xx_adc_nids[2] = {
(Continue reading)

Permalink | Reply |
headers
Matthew Ranostay | 8 Sep 16:28

Re: [PATCH1/1] hda: digital slave support for IDT codecs


Takashi Iwai wrote:
> At Sun, 07 Sep 2008 14:36:53 -0400,
> Matthew Ranostay wrote:
>> Added slave_dig_outs entries for several IDT codecs that have multiple
>> SPDIF outs, and enabled these SPDIF outs in several pin configs.
>>
Have you pushed your changes lately? I don't see any update since last Wednesday
in the git log.

-Matt

>> ---
>> Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>
> 
> This patch seems not applicable.
> Could you rebuild from my latest git tree?
> Note that the core changes for slave SPDIF was already added.
> 
> thanks,
> 
> Takashi
> 
>> diff --git a/pci/hda/patch_sigmatel.c b/pci/hda/patch_sigmatel.c
>> index 9968ee4..52b3579 100644
>> --- a/pci/hda/patch_sigmatel.c
>> +++ b/pci/hda/patch_sigmatel.c
>> @@ -229,6 +229,10 @@ static hda_nid_t stac92hd73xx_pwr_nids[8] = {
>>  	0x0f, 0x10, 0x11
>>  };
(Continue reading)

Permalink | Reply |
headers
Takashi Iwai | 8 Sep 16:37
Favicon

Re: [PATCH1/1] hda: digital slave support for IDT codecs

At Mon, 08 Sep 2008 10:28:53 -0400,
Matthew Ranostay wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Takashi Iwai wrote:
> > At Sun, 07 Sep 2008 14:36:53 -0400,
> > Matthew Ranostay wrote:
> >> Added slave_dig_outs entries for several IDT codecs that have multiple
> >> SPDIF outs, and enabled these SPDIF outs in several pin configs.
> >>
> Have you pushed your changes lately? I don't see any update since last Wednesday
> in the git log.

Take sound-2.6.git tree from the below:
    git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
Gitweb is
    http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=summary

thanks,

Takashi

> >> ---
> >> Signed-off-by: Matthew Ranostay <mranostay <at> embeddedalley.com>
> > 
> > This patch seems not applicable.
> > Could you rebuild from my latest git tree?
> > Note that the core changes for slave SPDIF was already added.
(Continue reading)

Permalink | Reply |
headers
Mark Brown | 8 Sep 17:12
Favicon
Gravatar

[PATCH 0/3] Minor ASoC updates

The following changes since commit 17c4badb6077b14d1cc67860511abd2001cefbf1:
  Cliff Cai (1):
        ASoC: Blackfin: Include Blackfin architecture support in build

are available in the git repository at:

  git://opensource.wolfsonmicro.com/linux-2.6-asoc for-tiwai

Mark Brown (3):
      ALSA: ASoC: Fix indentation in WM9713
      ALSA: ASoC: Sort Kconfig and Makefile entries for codecs
      ALSA: ASoC: Use codec digital mute when stopping playback

 sound/soc/codecs/Kconfig  |   64 ++++++++++++++++++++++----------------------
 sound/soc/codecs/Makefile |   16 +++++-----
 sound/soc/codecs/wm9713.c |   22 +++++++-------
 sound/soc/soc-core.c      |    6 ++++
 4 files changed, 57 insertions(+), 51 deletions(-)
Permalink | Reply |
headers
Mark Brown | 8 Sep 17:13
Favicon
Gravatar

[PATCH 1/3] ALSA: ASoC: Fix indentation in WM9713

Signed-off-by: Mark Brown <broonie <at> opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm9713.c |   22 +++++++++++-----------
 1 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c
index 38d1fe0..c10f8a3 100644
--- a/sound/soc/codecs/wm9713.c
+++ b/sound/soc/codecs/wm9713.c
@@ -949,17 +949,17 @@ static int wm9713_pcm_hw_params(struct snd_pcm_substream *substream,

 static void wm9713_voiceshutdown(struct snd_pcm_substream *substream)
 {
-    struct snd_soc_pcm_runtime *rtd = substream->private_data;
-    struct snd_soc_device *socdev = rtd->socdev;
-    struct snd_soc_codec *codec = socdev->codec;
-    u16 status;
-
-    /* Gracefully shut down the voice interface. */
-    status = ac97_read(codec, AC97_EXTENDED_STATUS) | 0x1000;
-    ac97_write(codec, AC97_HANDSET_RATE, 0x0280);
-    schedule_timeout_interruptible(msecs_to_jiffies(1));
-    ac97_write(codec, AC97_HANDSET_RATE, 0x0F80);
-    ac97_write(codec, AC97_EXTENDED_MID, status);
+	struct snd_soc_pcm_runtime *rtd = substream->private_data;
+	struct snd_soc_device *socdev = rtd->socdev;
+	struct snd_soc_codec *codec = socdev->codec;
+	u16 status;
+
+	/* Gracefully shut down the voice interface. */
(Continue reading)

Permalink | Reply |
headers
Mark Brown | 8 Sep 17:13
Favicon
Gravatar

[PATCH 2/3] ALSA: ASoC: Sort Kconfig and Makefile entries for codecs

Hopefully this will make merges a little bit easier.

Signed-off-by: Mark Brown <broonie <at> opensource.wolfsonmicro.com>
---
 sound/soc/codecs/Kconfig  |   64 ++++++++++++++++++++++----------------------
 sound/soc/codecs/Makefile |   16 +++++-----
 2 files changed, 40 insertions(+), 40 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 8b4bb5c..27f2dfa 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -4,7 +4,10 @@ config SND_SOC_ALL_CODECS
 	select SPI
 	select SPI_MASTER
 	select SND_SOC_AK4535
+	select SND_SOC_CS4270
 	select SND_SOC_SSM2602
+	select SND_SOC_TLV320AIC26
+	select SND_SOC_TLV320AIC3X
 	select SND_SOC_UDA1380
 	select SND_SOC_WM8510
 	select SND_SOC_WM8580
@@ -14,9 +17,6 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_WM8900
 	select SND_SOC_WM8903
 	select SND_SOC_WM8990
-	select SND_SOC_CS4270
-	select SND_SOC_TLV320AIC26
-	select SND_SOC_TLV320AIC3X
(Continue reading)

Permalink | Reply |
headers
Mark Brown | 8 Sep 17:13
Favicon
Gravatar

[PATCH 3/3] ALSA: ASoC: Use codec digital mute when stopping playback

Muting the DAC masks artefacts introduced as the digital stream shuts
down, for example when the input stops being clocked.

Signed-off-by: Mark Brown <broonie <at> opensource.wolfsonmicro.com>
---
 sound/soc/soc-core.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 1563cee..ad38113 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -340,6 +340,12 @@ static int soc_codec_close(struct snd_pcm_substream *substream)
 	}
 	codec->active--;

+	/* Muting the DAC suppresses artifacts caused during digital
+	 * shutdown, for example from stopping clocks.
+	 */
+	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+		snd_soc_dai_digital_mute(codec_dai, 1);
+
 	if (cpu_dai->ops.shutdown)
 		cpu_dai->ops.shutdown(substream);

--

-- 
1.5.6.5
Permalink | Reply |
headers
Takashi Iwai | 8 Sep 18:15
Favicon

Re: [PATCH 0/3] Minor ASoC updates

At Mon, 8 Sep 2008 16:12:50 +0100,
Mark Brown wrote:
> 
> The following changes since commit 17c4badb6077b14d1cc67860511abd2001cefbf1:
>   Cliff Cai (1):
>         ASoC: Blackfin: Include Blackfin architecture support in build
> 
> are available in the git repository at:
> 
>   git://opensource.wolfsonmicro.com/linux-2.6-asoc for-tiwai
> 
> Mark Brown (3):
>       ALSA: ASoC: Fix indentation in WM9713
>       ALSA: ASoC: Sort Kconfig and Makefile entries for codecs
>       ALSA: ASoC: Use codec digital mute when stopping playback
> 
>  sound/soc/codecs/Kconfig  |   64 ++++++++++++++++++++++----------------------
>  sound/soc/codecs/Makefile |   16 +++++-----
>  sound/soc/codecs/wm9713.c |   22 +++++++-------
>  sound/soc/soc-core.c      |    6 ++++
>  4 files changed, 57 insertions(+), 51 deletions(-)

All looks good.  Now pulled and pushed out.
Thanks.

Takashi
Permalink | Reply |

Gmane