headers
Scott Jiang | 21 Jun 2012 19:51
Picon

[PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg

Signed-off-by: Scott Jiang <scott.jiang.linux <at> gmail.com>
---
 sound/soc/blackfin/bf6xx-sport.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/blackfin/bf6xx-sport.c b/sound/soc/blackfin/bf6xx-sport.c
index f19a72b..318c5ba 100644
--- a/sound/soc/blackfin/bf6xx-sport.c
+++ b/sound/soc/blackfin/bf6xx-sport.c
 <at>  <at>  -256,9 +256,9  <at>  <at>  static irqreturn_t sport_err_irq(int irq, void *dev_id)
 	struct device *dev = &sport->pdev->dev;

 	if (sport->tx_regs->spctl & SPORT_CTL_DERRPRI)
-		dev_dbg(dev, "sport error: TUVF\n");
+		dev_err(dev, "sport error: TUVF\n");
 	if (sport->rx_regs->spctl & SPORT_CTL_DERRPRI)
-		dev_dbg(dev, "sport error: ROVF\n");
+		dev_err(dev, "sport error: ROVF\n");

 	return IRQ_HANDLED;
 }
--

-- 
1.7.0.4
Permalink | Reply |
headers
Mark Brown | 21 Jun 2012 12:08
Favicon
Gravatar

Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg

On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
> Signed-off-by: Scott Jiang <scott.jiang.linux <at> gmail.com>

Applied, but as I said last time you should use subject lines that match
up with the rest of the subsystem.

On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
> Signed-off-by: Scott Jiang <scott.jiang.linux <at> gmail.com>

Applied, but as I said last time you should use subject lines that match
up with the rest of the subsystem.
Permalink | Reply |
headers
Scott Jiang | 21 Jun 2012 12:29
Picon

Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg

2012/6/21 Mark Brown <broonie <at> opensource.wolfsonmicro.com>:
> On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
>> Signed-off-by: Scott Jiang <scott.jiang.linux <at> gmail.com>
>
> Applied, but as I said last time you should use subject lines that match
> up with the rest of the subsystem.

Sorry, I'm not sure what you mean. Do you mean 80 columns or style?
Could you please give me more details?

Thanks,
Scott
Permalink | Reply |
headers
Mark Brown | 21 Jun 2012 12:47
Favicon
Gravatar

Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg

On Thu, Jun 21, 2012 at 06:29:40PM +0800, Scott Jiang wrote:
> 2012/6/21 Mark Brown <broonie <at> opensource.wolfsonmicro.com>:
> > On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
> >> Signed-off-by: Scott Jiang <scott.jiang.linux <at> gmail.com>

> > Applied, but as I said last time you should use subject lines that match
> > up with the rest of the subsystem.

> Sorry, I'm not sure what you mean. Do you mean 80 columns or style?
> Could you please give me more details?

You're calling the subsystem "asoc" not "ASoC".

On Thu, Jun 21, 2012 at 06:29:40PM +0800, Scott Jiang wrote:
> 2012/6/21 Mark Brown <broonie <at> opensource.wolfsonmicro.com>:
> > On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
> >> Signed-off-by: Scott Jiang <scott.jiang.linux <at> gmail.com>

> > Applied, but as I said last time you should use subject lines that match
> > up with the rest of the subsystem.

> Sorry, I'm not sure what you mean. Do you mean 80 columns or style?
> Could you please give me more details?

You're calling the subsystem "asoc" not "ASoC".
Permalink | Reply |
headers
David Henningsson | 21 Jun 2012 16:50
Favicon

Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

On 06/21/2012 12:47 PM, Mark Brown wrote:
> On Thu, Jun 21, 2012 at 06:29:40PM +0800, Scott Jiang wrote:
>> 2012/6/21 Mark Brown<broonie <at> opensource.wolfsonmicro.com>:
>>> On Thu, Jun 21, 2012 at 01:51:58PM -0400, Scott Jiang wrote:
>>>> Signed-off-by: Scott Jiang<scott.jiang.linux <at> gmail.com>
>
>>> Applied, but as I said last time you should use subject lines that match
>>> up with the rest of the subsystem.
>
>> Sorry, I'm not sure what you mean. Do you mean 80 columns or style?
>> Could you please give me more details?
>
> You're calling the subsystem "asoc" not "ASoC".

While we're at it, how about switching to the a/b/c style used by 
several other subsystems?

I personally think "alsa/hda/realtek" looks much prettier than the 
shoutier "ALSA: HDA: Realtek:" thing we have today.

--

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
Permalink | Reply |
headers
Mark Brown | 21 Jun 2012 17:22
Favicon
Gravatar

Re: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

On Thu, Jun 21, 2012 at 04:50:50PM +0200, David Henningsson wrote:

> While we're at it, how about switching to the a/b/c style used by
> several other subsystems?

Looking at the git logs that's *really* unusual.

> I personally think "alsa/hda/realtek" looks much prettier than the
> shoutier "ALSA: HDA: Realtek:" thing we have today.

I have to say I really don't like this, especially the lowercasing of
everything.  It doesn't read like normal text, it reads like a filename.

On Thu, Jun 21, 2012 at 04:50:50PM +0200, David Henningsson wrote:

> While we're at it, how about switching to the a/b/c style used by
> several other subsystems?

Looking at the git logs that's *really* unusual.

> I personally think "alsa/hda/realtek" looks much prettier than the
> shoutier "ALSA: HDA: Realtek:" thing we have today.

I have to say I really don't like this, especially the lowercasing of
everything.  It doesn't read like normal text, it reads like a filename.
Permalink | Reply |
headers
Takashi Iwai | 21 Jun 2012 17:31
Picon

Re: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

At Thu, 21 Jun 2012 16:22:44 +0100,
Mark Brown wrote:
> 
> On Thu, Jun 21, 2012 at 04:50:50PM +0200, David Henningsson wrote:
> 
> > While we're at it, how about switching to the a/b/c style used by
> > several other subsystems?
> 
> Looking at the git logs that's *really* unusual.

I'd say it's between usual and unusual :)
Driver-local commits tend to have a prefix with the path (or
omitting "drivers/").  So in our case it'd be "sound/soc/codec: xxx"
or "sound/pci/hda: xxx".

> > I personally think "alsa/hda/realtek" looks much prettier than the
> > shoutier "ALSA: HDA: Realtek:" thing we have today.
> 
> I have to say I really don't like this, especially the lowercasing of
> everything.  It doesn't read like normal text, it reads like a filename.

Yeah, I share the same feeling.  The words like ALSA or ASoC don't fit
with lower letters well.

Takashi
Permalink | Reply |
headers
Mark Brown | 21 Jun 2012 17:39
Favicon
Gravatar

Re: Patch subject line (was: Re: [PATCH] asoc: bfin: use dev_err to print error log instead of dev_dbg)

On Thu, Jun 21, 2012 at 05:31:51PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > Looking at the git logs that's *really* unusual.

> I'd say it's between usual and unusual :)
> Driver-local commits tend to have a prefix with the path (or
> omitting "drivers/").  So in our case it'd be "sound/soc/codec: xxx"
> or "sound/pci/hda: xxx".

Yeah, I was mainly thinking of the subsystem: bit which is pretty much
the norm (with a few exceptions).

On Thu, Jun 21, 2012 at 05:31:51PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > Looking at the git logs that's *really* unusual.

> I'd say it's between usual and unusual :)
> Driver-local commits tend to have a prefix with the path (or
> omitting "drivers/").  So in our case it'd be "sound/soc/codec: xxx"
> or "sound/pci/hda: xxx".

Yeah, I was mainly thinking of the subsystem: bit which is pretty much
the norm (with a few exceptions).
Permalink | Reply |

Gmane