headers
Bernard Li | 2 Feb 2007 08:27

Re: systemimager-bittorrent %pre scripts

Hi Andrea:

For now I have put "bittorrent" in OSCAR's base prereqs, meaning that
the package will be installed prior to SIS being installed.  This is
not ideal (IMHO) but does work.

If nobody from OSCAR objects, I will leave it at that.

Basically the issue is that in SystemImager 3.7.6, bittorrent RPM
dependency was removed such that RPMs can be distro-neutral (SuSE
calls it BitTorrent, RH/FC calls it bittorrent).  There is also a
check for bittorrent binaries in the %pre script, if it couldn't find
them the installation of systemimager-bittorrent would fail.  This
can't be bypassed simply by adding bittorrent to SIS' config.xml,
since there is no ordering involved.

Cheers,

Bernard

On 1/29/07, Bernard Li <bernard@...> wrote:
> Andrea:
>
> Currently the %pre section checks to see if the BitTorrent binaries
> are available, if not, then the installation exits.
>
> WIll you consider removing the exit statement?  I think outputing the
> warning message is sufficient for the user to know that they need to
> install the BitTorrent package.
>
(Continue reading)

Permalink | Reply |
headers
Erich Focht | 2 Feb 2007 19:42
Picon

Re: [Oscar-devel] systemimager-bittorrent %pre scripts

Hi Bernard,

the check in the %pre script is a pretty bad idea, isn't it? It prevents us
from fixing this cleanly inside config.xml :-( Two ways seem clean to me:
Either take out the dependency entirely (also from the %pre) or take it in
cleanly, as dependency, and make the package distro dependent (but
noarch). The distro-dependency is not a big deal, actually the package should
be small. A pity that requires don't allow an ||

Regards,
Erich

On Friday 02 February 2007 08:27, Bernard Li wrote:
> Hi Andrea:
> 
> For now I have put "bittorrent" in OSCAR's base prereqs, meaning that
> the package will be installed prior to SIS being installed.  This is
> not ideal (IMHO) but does work.
> 
> If nobody from OSCAR objects, I will leave it at that.
> 
> Basically the issue is that in SystemImager 3.7.6, bittorrent RPM
> dependency was removed such that RPMs can be distro-neutral (SuSE
> calls it BitTorrent, RH/FC calls it bittorrent).  There is also a
> check for bittorrent binaries in the %pre script, if it couldn't find
> them the installation of systemimager-bittorrent would fail.  This
> can't be bypassed simply by adding bittorrent to SIS' config.xml,
> since there is no ordering involved.
> 
> Cheers,
(Continue reading)

Permalink | Reply |
headers
Bernard Li | 2 Feb 2007 20:21

Re: [Oscar-devel] systemimager-bittorrent %pre scripts

Hi Erich:

On 2/2/07, Erich Focht <efocht@...> wrote:

> the check in the %pre script is a pretty bad idea, isn't it? It prevents us
> from fixing this cleanly inside config.xml :-( Two ways seem clean to me:
> Either take out the dependency entirely (also from the %pre) or take it in

Andrea suggests changing the message from "error" to "warning" and
also to take out the exit statement.  This case, installation of
systemimager-bittorrent will not fail and the bittorrent package will
be installed after (since it is in config.xml) and everything is A-OK.
 Though if the user sets OSCAR_VERBOSE=3 or higher he will see the
"warning" message and wonder what is going on...

> cleanly, as dependency, and make the package distro dependent (but
> noarch). The distro-dependency is not a big deal, actually the package should
> be small. A pity that requires don't allow an ||

Actually, this could be solved if both bittorrent and BitTorrent
packages provide a common package name, but I doubt this is the
case...

IMHO having the package distro dependent is the correct way to go
since this will allow correct dependency resolution.  It is a pity
that RPMs generated in that case cannot be used cross-distro.

Anyways, another solution as I have outlined is simply put bittorrent
in prereqs.
(Continue reading)

Permalink | Reply |
headers
Erich Focht | 5 Feb 2007 10:42
Picon

Re: [Oscar-devel] systemimager-bittorrent %pre scripts

Hi Bernard,

On Friday 02 February 2007 20:21, Bernard Li wrote:
> Hi Erich:
> 
> On 2/2/07, Erich Focht <efocht@...> wrote:
> 
> > the check in the %pre script is a pretty bad idea, isn't it? It prevents us
> > from fixing this cleanly inside config.xml :-( Two ways seem clean to me:
> > Either take out the dependency entirely (also from the %pre) or take it in
> 
> Andrea suggests changing the message from "error" to "warning" and
> also to take out the exit statement.  This case, installation of
> systemimager-bittorrent will not fail and the bittorrent package will
> be installed after (since it is in config.xml) and everything is A-OK.
>  Though if the user sets OSCAR_VERBOSE=3 or higher he will see the
> "warning" message and wonder what is going on...

this sounds very reasonable! Would be great if you could do it!

> Actually, this could be solved if both bittorrent and BitTorrent
> packages provide a common package name, but I doubt this is the
> case...

Those packages come from SUSE and RedHat, therefore we have no influence on
what they provide :-(

> IMHO having the package distro dependent is the correct way to go
> since this will allow correct dependency resolution.  It is a pity
> that RPMs generated in that case cannot be used cross-distro.
(Continue reading)

Permalink | Reply |
headers
Bernard Li | 5 Feb 2007 19:24

Re: systemimager-bittorrent %pre scripts

Hi Erich:

Last night I checked in updated versions of SystemImager and
SystemInstaller into OSCAR trunk.

Andrea has changed the %pre script in systemimager-bittorrent such
that it won't fail if the bittorrent package is not installed prior to
systemimager-bittorrent RPM installation.  Nothing else has been
touched.

Cheers,

Bernard

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
Permalink | Reply |
headers
Andrea Righi | 2 Feb 2007 10:49
Picon
Favicon

Re: [Sisuite-devel] systemimager-bittorrent %pre scripts

Bernard Li wrote:
> For now I have put "bittorrent" in OSCAR's base prereqs, meaning that
> the package will be installed prior to SIS being installed.  This is
> not ideal (IMHO) but does work.
>
> If nobody from OSCAR objects, I will leave it at that.
>
> Basically the issue is that in SystemImager 3.7.6, bittorrent RPM
> dependency was removed such that RPMs can be distro-neutral (SuSE
> calls it BitTorrent, RH/FC calls it bittorrent).  There is also a
> check for bittorrent binaries in the %pre script, if it couldn't find
> them the installation of systemimager-bittorrent would fail.  This
> can't be bypassed simply by adding bittorrent to SIS' config.xml,
> since there is no ordering involved.

OK, I like to replace the exit statement with a warning (instead of
error) directly in systemimager-bittorrent package, but I think that
also this change is needed in OSCAR, to remove warning message that
could generate confusion to the users...

What do you think about this?

-Andrea

Index: systemimager.spec
===================================================================
--- systemimager.spec	(revision 3896)
+++ systemimager.spec	(working copy)
 <at>  <at>  -774,29 +774,29  <at>  <at> 
 echo "checking for a tracker binary..."
(Continue reading)

Permalink | Reply |
headers
Bernard Li | 2 Feb 2007 11:02

Re: [Sisuite-devel] systemimager-bittorrent %pre scripts

Hi Andrea:

Actually, by default, without setting OSCAR_VERBOSE, these kind of
warnings are suppressed.  So I suppose it is fine.

For now my solution is simply to add bittorrent as a prereq.  But
either solution is fine, I guess...

Cheers,

Bernard

On 2/2/07, Andrea Righi <a.righi@...> wrote:
> Bernard Li wrote:
> > For now I have put "bittorrent" in OSCAR's base prereqs, meaning that
> > the package will be installed prior to SIS being installed.  This is
> > not ideal (IMHO) but does work.
> >
> > If nobody from OSCAR objects, I will leave it at that.
> >
> > Basically the issue is that in SystemImager 3.7.6, bittorrent RPM
> > dependency was removed such that RPMs can be distro-neutral (SuSE
> > calls it BitTorrent, RH/FC calls it bittorrent).  There is also a
> > check for bittorrent binaries in the %pre script, if it couldn't find
> > them the installation of systemimager-bittorrent would fail.  This
> > can't be bypassed simply by adding bittorrent to SIS' config.xml,
> > since there is no ordering involved.
>
> OK, I like to replace the exit statement with a warning (instead of
> error) directly in systemimager-bittorrent package, but I think that
(Continue reading)

Permalink | Reply |

Gmane