headers
Lino Sanfilippo | 8 Jul 2010 18:52
Favicon

Patch 4/5


This patch fixes a missing cleanup in cases where an error occurs
after an event has already been assigned to a group.
Before an event has not been put back to the "todo" list properly
(the list_del() for the working list was missing) and also was not
put back in cases of error in dazukofs_group_read().

There is still something missing:
If a filedescriptor has already been opened for an event, it has to
be closed before it is put back to the "working list".
I will send a fix for this issue with another patch.

Geschäftsführender Gesellschafter: Tjark Auerbach
Sitz der Gesellschaft: Tettnang
Handelsregister: Amtsgericht Ulm, HRB 630992
ALLGEMEINE GESCHÄFTSBEDINGUNGEN
Es gelten unsere Allgemeinen Geschäftsbedingungen
(AGB). Sie finden sie in der jeweils gültigen Fassung
im Internet unter http://www.avira.de/agb
***************************************************
Attachment (dazukofs-3.1.3-patch4.diff): text/x-patch, 7264 bytes
_______________________________________________
Dazuko-devel mailing list
Dazuko-devel <at> nongnu.org
http://lists.nongnu.org/mailman/listinfo/dazuko-devel
Permalink | Reply |
headers
John Ogness | 16 Oct 2010 18:34

Re: Patch 4/5

On 2010-07-08, Lino Sanfilippo <lino.sanfilippo <at> avira.com> wrote:
> This patch fixes a missing cleanup in cases where an error occurs
> after an event has already been assigned to a group.  Before an
> event has not been put back to the "todo" list properly (the
> list_del() for the working list was missing) and also was not put
> back in cases of error in dazukofs_group_read().
>
> There is still something missing:
> If a filedescriptor has already been opened for an event, it has to
> be closed before it is put back to the "working list".  I will send
> a fix for this issue with another patch.

Thank you for pointing this out. The latest version (3.1.4-rc1) fixes
this issue and also handles closing the file descriptor. I chose not
to use your implementation because I felt it made the group use_count
handling too complicated.

John Ogness

--

-- 
Dazuko Maintainer
Permalink | Reply |
headers
Lino Sanfilippo | 2 Nov 2010 11:46
Favicon

Re: Patch 4/5

John Ogness wrote:
> On 2010-07-08, Lino Sanfilippo <lino.sanfilippo <at> avira.com> wrote:
>   
>> This patch fixes a missing cleanup in cases where an error occurs
>> after an event has already been assigned to a group.  Before an
>> event has not been put back to the "todo" list properly (the
>> list_del() for the working list was missing) and also was not put
>> back in cases of error in dazukofs_group_read().
>>     
>
> Thank you for pointing this out. The latest version (3.1.4-rc1) fixes
> this issue

The issue is still there. Have a look at claim_event() where we do:
- remove item from todo list
- put item on working list

If something fails afterwards we call unclaim_event() and only do:
- put item back on todo list

Removing the item from the working list in unclaim_event() is still 
missing...

Regards,
Lino

Geschäftsführender Gesellschafter: Tjark Auerbach
Sitz der Gesellschaft: Tettnang
Handelsregister: Amtsgericht Ulm, HRB 630992
ALLGEMEINE GESCHÄFTSBEDINGUNGEN
(Continue reading)

Permalink | Reply |

Gmane