For newbie maintainers

Emilien Klein | 14 Jan 2012 15:56

RFS: shaarli

Dear mentors,

I am looking for a sponsor for my package "shaarli".

 * Package name    : shaarli
   Version         : 0.0.33beta-1
   Upstream Author : Sebastien Sauvage <sebsauvage <at> sebsauvage.net>
 * URL             : http://sebsauvage.net/wiki/doku.php?id=php:shaarli
 * License         : zlib/libpng OSI licence.
   Section         : web

It builds those binary packages:

shaarli    - Minimalist, personal and fast Delicious clone

To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/shaarli

Alternatively, one can download the package with dget using this command:

  dget -x http://mentors.debian.net/debian/pool/main/s/shaarli/shaarli_0.0.33beta-1.dsc

Shaarli contains the jQuery 1.6.2 minified file, which results in this
Lintian warning:
W: shaarli: embedded-javascript-library usr/share/shaarli/inc/jquery.min.js
I've considered depending on the jquery Debian package, but that one
is already at version 1.7.1. In order to not introduce
incompatibilities, I have thus left the file in the Shaarli package.

(Continue reading)

headers

Jakub Wilk | 14 Jan 2012 18:09

Re: RFS: shaarli

* Emilien Klein <emilien+debian <at> klein.st>, 2012-01-14, 15:56:
>  dget -x http://mentors.debian.net/debian/pool/main/s/shaarli/shaarli_0.0.33beta-1.dsc
>
>Shaarli contains the jQuery 1.6.2 minified file,

…for which we have no source. This is violation of DFSG §2.
(And additionally, upstream is violating jQuery's license.)

-- 
Jakub Wilk

--

-- 
To UNSUBSCRIBE, email to debian-mentors-REQUEST <at> lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster <at> lists.debian.org
Archive: http://lists.debian.org/20120114170959.GA3631 <at> jwilk.net

headers

Emilien Klein | 14 Jan 2012 19:21

Re: RFS: shaarli

Le 14 janv. 2012 18:10, "Jakub Wilk" <jwilk <at> debian.org> a écrit :
> * Emilien Klein <emilien+debian <at> klein.st>, 2012-01-14, 15:56:
>> Shaarli contains the jQuery 1.6.2 minified file,
>
> …for which we have no source. This is violation of DFSG §2.
> (And additionally, upstream is violating jQuery's license.)

Jakub, is there any other way to come into compliance than to get upstream to supply the jQuery script unminified?

+Emilien

headers

Arno Töll | 15 Jan 2012 00:10

Re: RFS: shaarli

Hello,

On 14.01.2012 19:21, Emilien Klein wrote:
> Jakub, is there any other way to come into compliance than to get upstream
> to supply the jQuery script unminified?

yes. The best way actually: Drop the embedded code copy and make it use
an unmodified upstream version if possible. Following your explanations
I guess that's not easily possible.

--

-- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D

headers

Emilien Klein | 16 Jan 2012 23:10

Re: RFS: shaarli

2012/1/14 Jakub Wilk <jwilk <at> debian.org>:
> * Emilien Klein <emilien+debian <at> klein.st>, 2012-01-14, 15:56:
>
>>  dget -x
>> http://mentors.debian.net/debian/pool/main/s/shaarli/shaarli_0.0.33beta-1.dsc
>>
>> Shaarli contains the jQuery 1.6.2 minified file,
>
>
> …for which we have no source. This is violation of DFSG §2.
> (And additionally, upstream is violating jQuery's license.)

Hi Jakub, Arno, and the other mentors,

I've worked with upstream Shaarli to fix the issue with the inclusion
of the minified jQuery files. Upstream has released a tarball that
uses the jQuery CDN instead of the local minified files (which have
been removed from the archive), so I've rebuilt the package using this
new tarball. I've uploaded it to mentors, it should be processed in a
few minutes.

Could someone please review my RFS?

Thanks!
    +Emilien

headers

Paul Wise | 16 Jan 2012 23:30

Re: RFS: shaarli

On Tue, Jan 17, 2012 at 6:10 AM, Emilien Klein wrote:

> I've worked with upstream Shaarli to fix the issue with the inclusion
> of the minified jQuery files. Upstream has released a tarball that
> uses the jQuery CDN instead of the local minified files (which have
> been removed from the archive)

That isn't a good idea either since it breaks when users of it have
network access to the software but no general Internet access to get
to the jQuery CDN. Much better would be to depend on the Debian
package of jQuery and use that.

--

-- 
bye,
pabs

http://wiki.debian.org/PaulWise

headers

Arno Töll | 17 Jan 2012 11:07

Re: RFS: shaarli


Hi,

On 16.01.2012 23:30, Paul Wise wrote:
> Much better would be to depend on the Debian
> package of jQuery and use that.

Indeed. But that's a simple change, since upstream uses an unmodified
third party source now.

--

-- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D

headers

Emilien Klein | 17 Jan 2012 11:11

Re: RFS: shaarli

Hi Paul,

2012/1/16 Paul Wise <pabs <at> debian.org>:
> On Tue, Jan 17, 2012 at 6:10 AM, Emilien Klein wrote:
>
>> I've worked with upstream Shaarli to fix the issue with the inclusion
>> of the minified jQuery files. Upstream has released a tarball that
>> uses the jQuery CDN instead of the local minified files (which have
>> been removed from the archive)
>
> That isn't a good idea either since it breaks when users of it have
> network access to the software but no general Internet access to get
> to the jQuery CDN. Much better would be to depend on the Debian
> package of jQuery and use that.

I've now patched the package to depend and use the Debian package of
jQuery instead of the CDN. It is uploaded to mentors:
http://mentors.debian.net/package/shaarli

Thanks for reviewing it.
    +Emilien

headers

Emilien Klein | 22 Jan 2012 21:56

Re: RFS: shaarli

Hi Mentors,

I've added a dependency on php5-gd to have the thumbnailing service
work properly. I've uploaded the updated package again to mentors:

 http://mentors.debian.net/package/shaarli

Alternatively, one can download the package with dget using this command:

 dget -x http://mentors.debian.net/debian/pool/main/s/shaarli/shaarli_0.0.33beta-1.dsc

Thanks for your time reviewing it.
    +Emilien
P.S.: Please CC me, as I'm not subscribed to this list.

headers

Emilien Klein | 17 Feb 2012 23:05

Re: RFS: shaarli

Hi Mentors,

I have now updated the package to the newest version 0.0.38beta and
uploaded it to mentors.d.n.

FYI version 0.0.37beta introduced a new JavaScript library that wasn't
yet packaged in Debian, so I have first worked on getting it packaged
in Debian. To co-maintain this new package, I have joined the
JavaScript team. The new package [0] has been uploaded to Sid
yesterday!
The JS library file included in the tar.gz is minified, but I've
worked with Shaarli's developer, and he is going to remove it from the
release tarball in the next version.

You can find my new package here:
http://mentors.debian.net/package/shaarli

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/s/shaarli/shaarli_0.0.38beta-1.dsc

Thanks for your time reviewing it.
   +Emilien
P.S.: Please CC me, as I'm not subscribed to this list.

[0] http://packages.qa.debian.org/j/jquery-lazyload.html

headers

Emilien Klein | 3 May 2012 23:52

Re: RFS: shaarli

Hi Mentors,

2012/2/17 Emilien Klein <emilien+debian <at> klein.st>:
> I have now updated the package to the newest version 0.0.38beta and
> uploaded it to mentors.d.n.

I'm looking for somebody to review my new package and possibly sponsor
its upload.

It's a web application used to maintain one's own list of bookmarks
(similar to delicious or Diigo) mainly written in PHP.

You can find the package here:
http://mentors.debian.net/package/shaarli

Alternatively, one can download the package with dget using this command:

dget -x http://mentors.debian.net/debian/pool/main/s/shaarli/shaarli_0.0.38beta-1.dsc

Thanks for your time reviewing it.
   +Emilien
P.S.: Please CC me, as I'm not subscribed to this list.