Peter Moon | 6 Jun 21:22 2011
Picon

[PATCH] cx231xx: Add support for Hauppauge WinTV USB2-FM

This patch adds support for the " Hauppauge WinTV USB2-FM" Analog Stick.

Signed-off-by: Peter Moon <pomoon <at> gmail.com>

diff -ru linux.orig/drivers/media/video/cx231xx/cx231xx-avcore.c
linux/drivers/media/video/cx231xx/cx231xx-avcore.c
--- linux.orig/drivers/media/video/cx231xx/cx231xx-avcore.c     2011-06-03
21:53:42.000000000 +0200
+++ linux/drivers/media/video/cx231xx/cx231xx-avcore.c  2011-06-03
21:54:13.000000000 +0200
 <at>  <at>  -355,6 +355,7  <at>  <at> 
       case CX231XX_BOARD_HAUPPAUGE_EXETER:
       case CX231XX_BOARD_HAUPPAUGE_USBLIVE2:
       case CX231XX_BOARD_PV_PLAYTV_USB_HYBRID:
+       case CX231XX_BOARD_HAUPPAUGE_USB2_FM:
               if (avmode == POLARIS_AVMODE_ANALOGT_TV) {
                       while (afe_power_status != (FLD_PWRDN_TUNING_BIAS |
                                               FLD_PWRDN_ENABLE_PLL)) {
 <at>  <at>  -1729,6 +1730,7  <at>  <at> 
       case CX231XX_BOARD_CNXT_RDU_250:
       case CX231XX_BOARD_CNXT_VIDEO_GRABBER:
       case CX231XX_BOARD_HAUPPAUGE_EXETER:
+       case CX231XX_BOARD_HAUPPAUGE_USB2_FM:
               func_mode = 0x03;
               break;
       case CX231XX_BOARD_CNXT_RDE_253S:
diff -ru linux.orig/drivers/media/video/cx231xx/cx231xx-cards.c
linux/drivers/media/video/cx231xx/cx231xx-cards.c
--- linux.orig/drivers/media/video/cx231xx/cx231xx-cards.c      2011-06-03
21:53:42.000000000 +0200
(Continue reading)

Devin Heitmueller | 6 Jun 22:00 2011

Re: [PATCH] cx231xx: Add support for Hauppauge WinTV USB2-FM

On Mon, Jun 6, 2011 at 3:22 PM, Peter Moon <pomoon <at> gmail.com> wrote:
> This patch adds support for the " Hauppauge WinTV USB2-FM" Analog Stick.
>
> Signed-off-by: Peter Moon <pomoon <at> gmail.com>

I basically have the same patch sitting in my one of my Hauppauge
private repos, but hadn't gotten around to submitting it upstream yet.

My only comment is that the func_mode in cx231xx_dif_set_standard()
should be 0x01, not 0x03.  Change that, resubmit the patch after
testing, and I will put my Reviewed-By on it.

Also, there is actually another USB ID which is the exact same product
(but targeted at NTSC by default).  I'll have to lookup the ID though.

Devin

--

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
Peter Moon | 7 Jun 18:12 2011
Picon

Re: [PATCH] cx231xx: Add support for Hauppauge WinTV USB2-FM

On Mon, Jun 6, 2011 at 10:00 PM, Devin Heitmueller
<dheitmueller <at> kernellabs.com> wrote:
> On Mon, Jun 6, 2011 at 3:22 PM, Peter Moon <pomoon <at> gmail.com> wrote:
>> This patch adds support for the " Hauppauge WinTV USB2-FM" Analog Stick.
>>
>> Signed-off-by: Peter Moon <pomoon <at> gmail.com>
>
> My only comment is that the func_mode in cx231xx_dif_set_standard()
> should be 0x01, not 0x03.  Change that, resubmit the patch after
> testing, and I will put my Reviewed-By on it.

I will make the change you suggest and retest.

> Also, there is actually another USB ID which is the exact same product
> (but targeted at NTSC by default).  I'll have to lookup the ID though.

According to the Windows driver inf file that I have, the USB ID of
the NTSC version is 2040:b111.

I can add the USB device definition for the NTSC targeted device as well.

Peter Moon
Devin Heitmueller | 7 Jun 18:17 2011

Re: [PATCH] cx231xx: Add support for Hauppauge WinTV USB2-FM

On Tue, Jun 7, 2011 at 12:12 PM, Peter Moon <pomoon <at> gmail.com> wrote:
> According to the Windows driver inf file that I have, the USB ID of
> the NTSC version is 2040:b111.

Correct.  The PAL defaulted device is b110.  The NTSC defaulted device is B111.

> I can add the USB device definition for the NTSC targeted device as well.

You can do this either one of two ways:  you can add just the USB ID
and point them both to the same card profile.  Or you can create two
card profiles that are identical in every way except for the default
standard.  The second approach is probably a better end-user
experience (since the default standard would match the user's
expectations), but the first approach is less code.

Devin

--

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com

Gmane