Linux video input infrastructure (V4L/DVB) development discussion and bug report mailing list. Covers drivers for Web Cams, Analog and Digital input and TV capture and AM/FM radio receivers.

Antti Palosaari | 10 Jul 2012 17:04

[PATCH RFCv3] add DTMB support for DVB API

Changes since v2
* add documentation
* FEC_0x => FEC_x_y
* remove typedef

Some questions still:
1)
Should I use INTERLEAVING_AUTO instead of INTERLEAVING_NONE ?

2)
Which is better, enum fe_interleaving or u8 for interleaving type inside struct dtv_frontend_properties?
Only 2 bits is needed to present current values so enum will waste some space.

Cc: Patrick Boettcher <pboettcher <at> kernellabs.com>
Cc: Andreas Oberritter <obi <at> linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab <at> redhat.com>

Antti Palosaari (1):
  add DTMB support for DVB API

 Documentation/DocBook/media/dvb/dvbproperty.xml |   40 ++++++++++++++++++++++-
 drivers/media/dvb/dvb-core/dvb_frontend.c       |   14 ++++++--
 drivers/media/dvb/dvb-core/dvb_frontend.h       |    2 ++
 drivers/media/dvb/frontends/atbm8830.c          |    2 +-
 drivers/media/dvb/frontends/lgs8gl5.c           |    2 +-
 drivers/media/dvb/frontends/lgs8gxx.c           |    2 +-
 include/linux/dvb/frontend.h                    |   21 ++++++++++--
 include/linux/dvb/version.h                     |    2 +-
 8 files changed, 74 insertions(+), 11 deletions(-)

(Continue reading)

headers

Antti Palosaari | 10 Jul 2012 17:04

[PATCH RFCv3] add DTMB support for DVB API

Cc: Patrick Boettcher <pboettcher <at> kernellabs.com>
Cc: Andreas Oberritter <obi <at> linuxtv.org>
Cc: Mauro Carvalho Chehab <mchehab <at> redhat.com>
Acked-by: Patrick Boettcher <pboettcher <at> kernellabs.com>
Signed-off-by: Antti Palosaari <crope <at> iki.fi>
---
 Documentation/DocBook/media/dvb/dvbproperty.xml |   40 ++++++++++++++++++++++-
 drivers/media/dvb/dvb-core/dvb_frontend.c       |   14 ++++++--
 drivers/media/dvb/dvb-core/dvb_frontend.h       |    2 ++
 drivers/media/dvb/frontends/atbm8830.c          |    2 +-
 drivers/media/dvb/frontends/lgs8gl5.c           |    2 +-
 drivers/media/dvb/frontends/lgs8gxx.c           |    2 +-
 include/linux/dvb/frontend.h                    |   21 ++++++++++--
 include/linux/dvb/version.h                     |    2 +-
 8 files changed, 74 insertions(+), 11 deletions(-)

diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml b/Documentation/DocBook/media/dvb/dvbproperty.xml
index e633c09..05230ed 100644
--- a/Documentation/DocBook/media/dvb/dvbproperty.xml
+++ b/Documentation/DocBook/media/dvb/dvbproperty.xml
 <at>  <at>  -194,6 +194,7  <at>  <at>  get/set up to 64 properties. The actual meaning of each property is described on
 	APSK_16,
 	APSK_32,
 	DQPSK,
+	QAM_4_NR,
  } fe_modulation_t;
 </programlisting>
 	</section>
 <at>  <at>  -265,6 +266,7  <at>  <at>  typedef enum fe_code_rate {
 	FEC_AUTO,

(Continue reading)

headers

Mauro Carvalho Chehab | 30 Jul 2012 17:19

Re: [PATCH RFCv3] add DTMB support for DVB API

Em 10-07-2012 12:04, Antti Palosaari escreveu:
> Cc: Patrick Boettcher <pboettcher <at> kernellabs.com>
> Cc: Andreas Oberritter <obi <at> linuxtv.org>
> Cc: Mauro Carvalho Chehab <mchehab <at> redhat.com>
> Acked-by: Patrick Boettcher <pboettcher <at> kernellabs.com>
> Signed-off-by: Antti Palosaari <crope <at> iki.fi>

On a quick check, it looks ok on my eyes.

> ---
>   Documentation/DocBook/media/dvb/dvbproperty.xml |   40 ++++++++++++++++++++++-
>   drivers/media/dvb/dvb-core/dvb_frontend.c       |   14 ++++++--
>   drivers/media/dvb/dvb-core/dvb_frontend.h       |    2 ++
>   drivers/media/dvb/frontends/atbm8830.c          |    2 +-
>   drivers/media/dvb/frontends/lgs8gl5.c           |    2 +-
>   drivers/media/dvb/frontends/lgs8gxx.c           |    2 +-
>   include/linux/dvb/frontend.h                    |   21 ++++++++++--
>   include/linux/dvb/version.h                     |    2 +-
>   8 files changed, 74 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/DocBook/media/dvb/dvbproperty.xml b/Documentation/DocBook/media/dvb/dvbproperty.xml
> index e633c09..05230ed 100644
> --- a/Documentation/DocBook/media/dvb/dvbproperty.xml
> +++ b/Documentation/DocBook/media/dvb/dvbproperty.xml
>  <at>  <at>  -194,6 +194,7  <at>  <at>  get/set up to 64 properties. The actual meaning of each property is described on
>   	APSK_16,
>   	APSK_32,
>   	DQPSK,
> +	QAM_4_NR,
>    } fe_modulation_t;

(Continue reading)