headers
Matti Bickel | 12 Oct 14:39
Favicon

RFC: fox.eclass update

Hi folks,

While fixing bug #240060 I touched fox.eclass.
In the process, I updated the eclass to 
    * use versionator
    * cut support for fox-1.0 (loong outdated)
    * cut support for fox-1.5
    * use eautomake instead of =automake-1.4*
    * use emake instead of make
    * use elog instead of einfo
    * apply more variable quoting

I'm sure, I missed one or the other issue. That's why I'm posting it
here for public review. If you have requests or comments to make, please
reply to this thread.
--

-- 
Regards, Matti Bickel
Signed/Encrypted email preferred (key 4849EC6C)

# Copyright 1999-2005 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/fox.eclass,v 1.7 2007/01/15 20:27:06 mabi Exp $

# fox eclass
#
# This eclass allows building SLOT-able FOX Toolkit installations
# (x11-libs/fox: headers, libs, and docs), which are by design
# parallel-installable, while installing only one version of the utils
# (dev-util/reswrap) and apps (app-editors/adie, sci-calculators/calculator,
(Continue reading)

Permalink | Reply |
headers
Petteri Räty | 13 Oct 12:56
Favicon

Re: RFC: fox.eclass update

Matti Bickel kirjoitti:
> Hi folks,
> 
> While fixing bug #240060 I touched fox.eclass.
> In the process, I updated the eclass to 
>     * use versionator
>     * cut support for fox-1.0 (loong outdated)
>     * cut support for fox-1.5
>     * use eautomake instead of =automake-1.4*
>     * use emake instead of make
>     * use elog instead of einfo
>     * apply more variable quoting
> 
> I'm sure, I missed one or the other issue. That's why I'm posting it
> here for public review. If you have requests or comments to make, please
> reply to this thread.
> 

Could you also send a diff next time.

Regards,
Petteri
Permalink | Reply |
headers
Donnie Berkholz | 13 Oct 19:20
Favicon
Gravatar

Re: RFC: fox.eclass update

On 13:56 Mon 13 Oct     , Petteri Räty wrote:
> Could you also send a diff next time.

Or this time, even. +1 on that.

One easy thing to do is move what comments exist to the eclass-manpages 
format.

--

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com
Permalink | Reply |
headers
Matti Bickel | 13 Oct 20:28
Favicon

Re: RFC: fox.eclass update

Donnie Berkholz <dberkholz <at> gentoo.org> wrote:
> On 13:56 Mon 13 Oct     , Petteri Räty wrote:
> > Could you also send a diff next time.
> 
> Or this time, even. +1 on that.

Here you are. It's attached.

> One easy thing to do is move what comments exist to the eclass-manpages 
> format.

I also included some eclass-manpage foo now, thanks for the hint.
--

-- 
Regards, Matti Bickel
Signed/Encrypted email preferred (key 4849EC6C)

--- gentoo-x86/eclass/fox.eclass	2008-10-12 14:31:36.000000000 +0200
+++ fox-proposed.eclass	2008-10-13 20:27:05.000000000 +0200
@@ -1,8 +1,12 @@
 # Copyright 1999-2005 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/eclass/fox.eclass,v 1.8 2008/10/12 12:31:36 mabi Exp $
+# $Header: /var/cvsroot/gentoo-x86/eclass/fox.eclass,v 1.7 2007/01/15 20:27:06 mabi Exp $

-# fox eclass
+# @ECLASS: fox.eclass
+# @MAINTAINER: mabi <at> gentoo.org
+# @BLURB: Common build and install functions for fox-related apps and library
+# @DESCRIPTION: Used by the x11-libs/fox library and all applications that come
(Continue reading)

Permalink | Reply |
headers
Bo Ørsted Andresen | 14 Oct 15:20

Re: RFC: fox.eclass update

> --- gentoo-x86/eclass/fox.eclass	2008-10-12 14:31:36.000000000 +0200
> +++ fox-proposed.eclass	2008-10-13 20:27:05.000000000 +0200
> [...]
> -inherit eutils libtool versionator
> 
> +inherit autotools eutils libtool versionator

You should probably be setting WANT_AUTO* before inheriting autotools.

> [...]
> +	if ( ! use doc ) && [ -d "${D}"/usr/share/doc/${PF}/html ] ; then

Get rid of the pointless subshell.

    if use !doc && ...

--

-- 
Bo Andresen
Permalink | Reply |

Gmane