The Blackfin Kernel/Distribution Development List

Mike Frysinger | 11 Apr 2012 04:44

broken asm/blackfin.h in mainline

seems the asm/blackfin.h ssync changes were rewritten when pushed to
mainline.  the version pushed is broken.  also, seems the Author field
is wrong, but that can't be fixed now.

commit 0db07a905628d7f2952691df40853ffd95ceb097
Author: Bob Liu <lliubbo@...>
Date:   Fri Jan 27 22:10:04 2012 +0800

    blackfin: cleanup anomaly workarounds

    cleanup ANOMALY_05000312 and ANOMALY_05000244

    Signed-off-by: Robin Getz <robin.getz@...>
    Signed-off-by: Bob Liu <lliubbo@...>

 <at>  <at>  -73,18 +61,26  <at>  <at>  static inline void CSYNC(void)
 #define ssync(x) SSYNC(x)
 #define csync(x) CSYNC(x)

-#if ANOMALY_05000312
-#define SSYNC(scratch) cli scratch; nop; nop; SSYNC; sti scratch;
-#define CSYNC(scratch) cli scratch; nop; nop; CSYNC; sti scratch;
-
-#elif ANOMALY_05000244
-#define SSYNC(scratch) nop; nop; nop; SSYNC;
-#define CSYNC(scratch) nop; nop; nop; CSYNC;
+#if ANOMALY_05000312 || ANOMALY_05000244
+#define SSYNC(scratch) \
+do {           \
+   cli scratch;    \

(Continue reading)

headers

Bob Liu | 11 Apr 2012 05:39

Re: broken asm/blackfin.h in mainline

On Wed, Apr 11, 2012 at 10:44 AM, Mike Frysinger <vapier.adi <at> gmail.com> wrote:
> seems the asm/blackfin.h ssync changes were rewritten when pushed to
> mainline.  the version pushed is broken.  also, seems the Author field
> is wrong, but that can't be fixed now.
>
>
> commit 0db07a905628d7f2952691df40853ffd95ceb097
> Author: Bob Liu <lliubbo <at> gmail.com>
> Date:   Fri Jan 27 22:10:04 2012 +0800
>
>    blackfin: cleanup anomaly workarounds
>
>    cleanup ANOMALY_05000312 and ANOMALY_05000244
>
>    Signed-off-by: Robin Getz <robin.getz <at> analog.com>
>    Signed-off-by: Bob Liu <lliubbo <at> gmail.com>
>
>
>  <at>  <at>  -73,18 +61,26  <at>  <at>  static inline void CSYNC(void)
>  #define ssync(x) SSYNC(x)
>  #define csync(x) CSYNC(x)
>
> -#if ANOMALY_05000312
> -#define SSYNC(scratch) cli scratch; nop; nop; SSYNC; sti scratch;
> -#define CSYNC(scratch) cli scratch; nop; nop; CSYNC; sti scratch;
> -
> -#elif ANOMALY_05000244
> -#define SSYNC(scratch) nop; nop; nop; SSYNC;
> -#define CSYNC(scratch) nop; nop; nop; CSYNC;
> +#if ANOMALY_05000312 || ANOMALY_05000244

(Continue reading)

headers

Mike Frysinger | 11 Apr 2012 05:43

Re: broken asm/blackfin.h in mainline

On Tue, Apr 10, 2012 at 23:39, Bob Liu wrote:
> On Wed, Apr 11, 2012 at 10:44 AM, Mike Frysinger wrote:
>> arch/blackfin/mach-bf561/atomic.S: Assembler messages:
>> arch/blackfin/mach-bf561/atomic.S:48: Error: syntax error. Input text was do.
>> arch/blackfin/mach-bf561/atomic.S:48: Error:
>> arch/blackfin/mach-bf561/atomic.S:48: Error: syntax error. Input text was }.
>> arch/blackfin/mach-bf561/atomic.S:48: Error:
>> arch/blackfin/mach-bf561/atomic.S:53: Error: syntax error. Input text was do.
>> arch/blackfin/mach-bf561/atomic.S:53: Error:
>> arch/blackfin/mach-bf561/atomic.S:53: Error: syntax error. Input text was }.
>
> Sorry for the mistake, i just using checkpatch.pl then rewritten
> without well test.

yeah, checkpatch.pl can throw a lot of false positives.  have to be
careful to review each line to see if it's real or just noise :/.
-mike