headers
Alan Jenkins | 16 Sep 12:05

udev-test.pl failures

commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
Author: Kay Sievers <kay.sievers <at> vrfy.org>
Date:   Mon Sep 15 17:12:47 2008 -0700

    libudev: switch API from devpath to syspath

Lots of the udev tests fail here.  udev_sysfs.c broke when
util_resolve_sys_link() switched API.  I'll leave this up to you - maybe
your next commit is going to do away with udev_sysfs.c altogether :-).

Regards
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply |
headers
Kay Sievers | 16 Sep 19:16
Gravatar

Re: udev-test.pl failures

On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins <at> tuffmail.co.uk> wrote:
> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958

> Lots of the udev tests fail here.  udev_sysfs.c broke when
> util_resolve_sys_link() switched API.

Ah, sorry, should be fixed now.

> I'll leave this up to you - maybe
> your next commit is going to do away with udev_sysfs.c altogether :-).

It will go away soon, yeah. We should get rid of udev_sysfs.c and
"struct udevice". The temporary rule processing variables and a
libudev's "struct udev_device" pointer should fit into the rule
iterator you added recently.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply |
headers
Kay Sievers | 17 Oct 01:43
Gravatar

Re: udev-test.pl failures

On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers <at> vrfy.org> wrote:
> On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins <at> tuffmail.co.uk> wrote:
>> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
>
>> Lots of the udev tests fail here.  udev_sysfs.c broke when
>> util_resolve_sys_link() switched API.
>
> Ah, sorry, should be fixed now.
>
>> I'll leave this up to you - maybe
>> your next commit is going to do away with udev_sysfs.c altogether :-).
>
> It will go away soon, yeah. We should get rid of udev_sysfs.c and
> "struct udevice".

Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
event environment is replaced by a per-device property list. The
daemon, and everything else uses the libudev code now.

It seems to work fine here, but the code may be a bit rough at the
moment, until it has seen more testing. But, it should be pretty easy
now to play around with a threaded version of the daemon.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
(Continue reading)

Permalink | Reply |
headers
Alan Jenkins | 17 Oct 10:49

Re: udev-test.pl failures

Kay Sievers wrote:
> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers <at> vrfy.org> wrote:
>   
>> On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins <at> tuffmail.co.uk> wrote:
>>     
>>> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
>>>       
>>> Lots of the udev tests fail here.  udev_sysfs.c broke when
>>> util_resolve_sys_link() switched API.
>>>       
>> Ah, sorry, should be fixed now.
>>
>>     
>>> I'll leave this up to you - maybe
>>> your next commit is going to do away with udev_sysfs.c altogether :-).
>>>       
>> It will go away soon, yeah. We should get rid of udev_sysfs.c and
>> "struct udevice".
>>     
>
> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
> event environment is replaced by a per-device property list. The
> daemon, and everything else uses the libudev code now.
>
> It seems to work fine here, but the code may be a bit rough at the
> moment, until it has seen more testing. But, it should be pretty easy
> now to play around with a threaded version of the daemon.
>
> Thanks,
> Kay
(Continue reading)

Permalink | Reply |
headers
Kay Sievers | 17 Oct 14:05
Gravatar

Re: udev-test.pl failures

On Fri, Oct 17, 2008 at 10:49 AM, Alan Jenkins
<alan-jenkins <at> tuffmail.co.uk> wrote:
> Kay Sievers wrote:
>> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers <at> vrfy.org> wrote:
>> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
>> event environment is replaced by a per-device property list. The
>> daemon, and everything else uses the libudev code now.
>>
>> It seems to work fine here, but the code may be a bit rough at the
>> moment, until it has seen more testing. But, it should be pretty easy
>> now to play around with a threaded version of the daemon.

> Great.  I don't have so much time now though; I need to concentrate on
> project work.
>
> Going back to the original subject line... :-).  I see the tests still
> pass, but some of them make suspicious noises now.
>
> TEST 7: label test of max sysfs files
> device
> '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'boot_disk1'
> libudev: add_rule_key_pair: skip, too many keys of the same type in a single rule

That's valid, we ignore that rule. Added note to the test description.

> TEST 19: Handle stupid backslashed multi lines in config file (and replace kernel name)
> device '/devices/pci0000:00/0000:00:1d.7/usb5/5-2/5-2:1.0/tty/ttyACM0'
> expecting node 'modem'
> libudev: add_to_rules: invalid rule
(Continue reading)

Permalink | Reply |
headers
Alan Jenkins | 17 Oct 12:28

[PATCH] fix valgrind error for /sys/kernel/uids/*

Kay Sievers wrote:
> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers <at> vrfy.org> wrote:
>   
>> On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins <at> tuffmail.co.uk> wrote:
>>     
>>> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
>>>       
>>> Lots of the udev tests fail here.  udev_sysfs.c broke when
>>> util_resolve_sys_link() switched API.
>>>       
>> Ah, sorry, should be fixed now.
>>
>>     
>>> I'll leave this up to you - maybe
>>> your next commit is going to do away with udev_sysfs.c altogether :-).
>>>       
>> It will go away soon, yeah. We should get rid of udev_sysfs.c and
>> "struct udevice".
>>     
>
> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
> event environment is replaced by a per-device property list. The
> daemon, and everything else uses the libudev code now.
>
> It seems to work fine here, but the code may be a bit rough at the
> moment, until it has seen more testing. But, it should be pretty easy
> now to play around with a threaded version of the daemon.
>
> Thanks,
> Kay
(Continue reading)

Permalink | Reply |
headers
Kay Sievers | 17 Oct 13:23
Gravatar

Re: [PATCH] fix valgrind error for /sys/kernel/uids/*

On Fri, Oct 17, 2008 at 12:28 PM, Alan Jenkins
<alan-jenkins <at> tuffmail.co.uk> wrote:
> Kay Sievers wrote:
>> It seems to work fine here, but the code may be a bit rough at the
>> moment, until it has seen more testing. But, it should be pretty easy
>> now to play around with a threaded version of the daemon.

> # valgrind -q ./udevd &
> # udevtrigger
> ==16329== Invalid read of size 1
> ==16329==    at 0x40C9DA: udev_device_set_syspath (libudev-device.c:939)
> ==16329==    by 0x40DFB6: udev_monitor_receive_device
> (libudev-monitor.c:318)
> ==16329==    by 0x411F52: main (udevd.c:889)
> ==16329==  Address 0x60f2507 is 1 bytes before a block of size 6 alloc'd
> ==16329==    at 0x4C22FAB: malloc (vg_replace_malloc.c:207)
> ==16329==    by 0x4EA1DD1: strdup (strdup.c:43)
> ==16329==    by 0x40C987: udev_device_set_syspath (libudev-device.c:926)
> ==16329==    by 0x40DFB6: udev_monitor_receive_device
> (libudev-monitor.c:318)
> ==16329==    by 0x411F52: main (udevd.c:889)

> The syspath in question was /sys/kernel/uids/65534.

Ah, nice. Thanks, applied.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Permalink | Reply |

Gmane