Sebastian Andrzej Siewior | 3 Jun 2012 20:48

[PATCH 8/9] powerpc: move PCI fixup hooks from __init to __devinit

The fixups are executed once the pci-device is found which is during
boot process so __init seems fine as long as the platform does not
support hotplug.
However it is possible to remove the PCI bus at run time and have it
rediscovered again via "echo 1 > /sys/bus/pci/rescan" and this will call
the fixups again.

Cc: Kumar Gala <galak <at> kernel.crashing.org>
Cc: Benjamin Herrenschmidt <benh <at> kernel.crashing.org>
Cc: Paul Mackerras <paulus <at> samba.org>
Signed-off-by: Sebastian Andrzej Siewior <sebastian <at> breakpoint.cc>
---
 arch/powerpc/platforms/85xx/tqm85xx.c    |    2 +-
 arch/powerpc/platforms/86xx/gef_ppc9a.c  |    2 +-
 arch/powerpc/platforms/86xx/gef_sbc310.c |    2 +-
 arch/powerpc/platforms/86xx/gef_sbc610.c |    2 +-
 arch/powerpc/sysdev/fsl_pci.c            |    2 +-
 arch/powerpc/sysdev/mv64x60_pci.c        |    2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/powerpc/platforms/85xx/tqm85xx.c b/arch/powerpc/platforms/85xx/tqm85xx.c
index 4d786c2..3e70a20 100644
--- a/arch/powerpc/platforms/85xx/tqm85xx.c
+++ b/arch/powerpc/platforms/85xx/tqm85xx.c
 <at>  <at>  -102,7 +102,7  <at>  <at>  static void tqm85xx_show_cpuinfo(struct seq_file *m)
 	seq_printf(m, "PLL setting\t: 0x%x\n", ((phid1 >> 24) & 0x3f));
 }

-static void __init tqm85xx_ti1520_fixup(struct pci_dev *pdev)
+static void __devinit tqm85xx_ti1520_fixup(struct pci_dev *pdev)
(Continue reading)

Benjamin Herrenschmidt | 6 Jun 2012 07:28

Re: [PATCH 8/9] powerpc: move PCI fixup hooks from __init to __devinit

On Sun, 2012-06-03 at 20:48 +0200, Sebastian Andrzej Siewior wrote:
> The fixups are executed once the pci-device is found which is during
> boot process so __init seems fine as long as the platform does not
> support hotplug.
> However it is possible to remove the PCI bus at run time and have it
> rediscovered again via "echo 1 > /sys/bus/pci/rescan" and this will call
> the fixups again.
> 
> Cc: Kumar Gala <galak <at> kernel.crashing.org>

Acked-by: Benjamin Herrenschmidt <benh <at> kernel.crashing.org>

Thanks !

Ben.

> Cc: Paul Mackerras <paulus <at> samba.org>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian <at> breakpoint.cc>
> ---
>  arch/powerpc/platforms/85xx/tqm85xx.c    |    2 +-
>  arch/powerpc/platforms/86xx/gef_ppc9a.c  |    2 +-
>  arch/powerpc/platforms/86xx/gef_sbc310.c |    2 +-
>  arch/powerpc/platforms/86xx/gef_sbc610.c |    2 +-
>  arch/powerpc/sysdev/fsl_pci.c            |    2 +-
>  arch/powerpc/sysdev/mv64x60_pci.c        |    2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/85xx/tqm85xx.c b/arch/powerpc/platforms/85xx/tqm85xx.c
> index 4d786c2..3e70a20 100644
> --- a/arch/powerpc/platforms/85xx/tqm85xx.c
(Continue reading)


Gmane