1 Oct 2009 03:59
ax25: Fix possible oops in ax25_make_new
Linux Kernel Mailing List <linux-kernel <at> vger.kernel.org>
2009-10-01 01:59:06 GMT
2009-10-01 01:59:06 GMT
Gitweb: http://git.kernel.org/linus/8c185ab6185bf5e67766edb000ce428269364c86 Commit: 8c185ab6185bf5e67766edb000ce428269364c86 Parent: 81bbb3d4048cf577b5babcb0834230de391a35c5 Author: Jarek Poplawski <jarkao2 <at> gmail.com> AuthorDate: Sun Sep 27 10:57:02 2009 +0000 Committer: David S. Miller <davem <at> davemloft.net> CommitDate: Wed Sep 30 16:44:12 2009 -0700 ax25: Fix possible oops in ax25_make_new In ax25_make_new, if kmemdup of digipeat returns an error, there would be an oops in sk_free while calling sk_destruct, because sk_protinfo is NULL at the moment; move sk->sk_destruct initialization after this. BTW of reported-by: Bernard Pidoux F6BVP <f6bvp <at> free.fr> Signed-off-by: Jarek Poplawski <jarkao2 <at> gmail.com> Signed-off-by: David S. Miller <davem <at> davemloft.net> --- net/ax25/af_ax25.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index cd1c3dc..f454607 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c <at> <at> -901,7 +901,6 <at> <at> struct sock *ax25_make_new(struct sock *osk, struct ax25_dev *ax25_dev) sock_init_data(NULL, sk);(Continue reading)
RSS Feed