Linux Kernel Mailing List | 5 Aug 2012 21:33

time: Fix adjustment cleanup bug in timekeeping_adjust()

Gitweb:     http://git.kernel.org/linus/;a=commit;h=1d17d17484d40f2d5b35c79518597a2b25296996
Commit:     1d17d17484d40f2d5b35c79518597a2b25296996
Parent:     e7882d6c40874a5b5033ca85f7508a602a60b662
Author:     Ingo Molnar <mingo <at> kernel.org>
AuthorDate: Sat Aug 4 21:21:14 2012 +0200
Committer:  Ingo Molnar <mingo <at> kernel.org>
CommitDate: Sun Aug 5 12:37:14 2012 +0200

    time: Fix adjustment cleanup bug in timekeeping_adjust()

    Tetsuo Handa reported that sporadically the system clock starts
    counting up too quickly which is enough to confuse the hangcheck
    timer to print a bogus stall warning.

    Commit 2a8c0883 "time: Move xtime_nsec adjustment underflow handling
    timekeeping_adjust" overlooked this exit path:

            } else
                    return;

    which should really be a proper exit sequence, fixing the bug as a
    side effect.

    Also make the flow more readable by properly balancing curly
    braces.

    Reported-by: Tetsuo Handa <penguin-kernel <at> I-love.SAKURA.ne.jp> wrote:
    Tested-by: Tetsuo Handa <penguin-kernel <at> I-love.SAKURA.ne.jp> wrote:
    Signed-off-by: Ingo Molnar <mingo <at> kernel.org>
    Cc: john.stultz <at> linaro.org
(Continue reading)


Gmane