gmane.linux.kernel.input

[PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

The eGalax touchscreen used in the HP tx1305us tablet PC (and presumably 
the rest of the tx1000 series) uses a different format for events from 
the device than the existing driver supports.

Add a new device description and interrupt packet handler for the 
touchscreen used in the tx1305us, claiming the USB device ID for the 
device that this patch was tested with from the older eGalax device code.

Signed-off-by: Alastair Bridgewater <nyef <at> lisphacker.com>

---

Applies clean with linux-2.6.25 and linux-2.6.26-rc6.

--- linux-2.6.26-rc6/drivers/input/touchscreen/usbtouchscreen.c   
 2008-06-27 20:34:34.886969800 -0400
+++ linux-2.6.25/drivers/input/touchscreen/usbtouchscreen.c   
 2008-06-06 12:19:16.460568440 -0400
@@ -103,6 +103,7 @@ struct usbtouch_usb {
 enum {
     DEVTPYE_DUMMY = -1,
     DEVTYPE_EGALAX,
+    DEVTYPE_EGALAX2,
     DEVTYPE_PANJIT,
     DEVTYPE_3M,
     DEVTYPE_ITM,
@@ -120,7 +121,7 @@ static struct usb_device_id usbtouch_dev
     {USB_DEVICE(0x3823, 0x0001), .driver_info = DEVTYPE_EGALAX},
     {USB_DEVICE(0x3823, 0x0002), .driver_info = DEVTYPE_EGALAX},
     {USB_DEVICE(0x0123, 0x0001), .driver_info = DEVTYPE_EGALAX},

(Continue reading)

headers

Daniel Ritz | 28 Jun 17:17

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

hi

> The eGalax touchscreen used in the HP tx1305us tablet PC (and presumably 
> the rest of the tx1000 series) uses a different format for events from 
> the device than the existing driver supports.
> 
is there more information available? datasheets? drivers?

> Add a new device description and interrupt packet handler for the 
> touchscreen used in the tx1305us, claiming the USB device ID for the 
> device that this patch was tested with from the older eGalax device code.
>
NAK. you cannot change device IDs currently used to some new code.
this will break most eGalax setups as the device ID 0x0eef,0x0001 is used
in most of them, including the one i have..

you'll need to find a way to distinguish the screens. as a starting point
i attached an lsusb -vvv output from my screen...

NAK-by: Daniel Ritz <daniel.ritz <at> gmx.ch>

rgds
-daniel

Bus 001 Device 002: ID 0eef:0001 D-WAV Scientific Co., Ltd eGalax TouchScreen
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               1.10
  bDeviceClass            0 (Defined at Interface level)

(Continue reading)

headers

Daniel Ritz | 28 Jun 17:57

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

On Saturday 28 June 2008 17:19:16 Daniel Ritz wrote:
> hi
> 
> > The eGalax touchscreen used in the HP tx1305us tablet PC (and presumably 
> > the rest of the tx1000 series) uses a different format for events from 
> > the device than the existing driver supports.
> > 
> is there more information available? datasheets? drivers?
> 
> > Add a new device description and interrupt packet handler for the 
> > touchscreen used in the tx1305us, claiming the USB device ID for the 
> > device that this patch was tested with from the older eGalax device code.
> >
> NAK. you cannot change device IDs currently used to some new code.
> this will break most eGalax setups as the device ID 0x0eef,0x0001 is used
> in most of them, including the one i have..
> 
> you'll need to find a way to distinguish the screens. as a starting point
> i attached an lsusb -vvv output from my screen...
> 

reading the latest driver guide and programming guide from eGalax (now EETI btw.
www.eeti.com.tw ) it turns out that the newer devices should support the HID
format and report with that by default. those newer screens are handled by the
'usbhid' driver. have you tried loading that one before usbtouchscreen?

can you give an lsusb -vvv output?

in case the usbhid driver does not work, it's possible to put the touchscreen
into the non-HID operating mode and have to current code work again..it's easy

(Continue reading)

headers

Alastair Bridgewater | 28 Jun 20:18

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

Daniel Ritz wrote:
> On Saturday 28 June 2008 17:19:16 Daniel Ritz wrote:
>> hi
>>
>>> The eGalax touchscreen used in the HP tx1305us tablet PC (and presumably 
>>> the rest of the tx1000 series) uses a different format for events from 
>>> the device than the existing driver supports.
>>>
>> is there more information available? datasheets? drivers?
 >>
>>> Add a new device description and interrupt packet handler for the 
>>> touchscreen used in the tx1305us, claiming the USB device ID for the 
>>> device that this patch was tested with from the older eGalax device code.
>>>
>> NAK. you cannot change device IDs currently used to some new code.
>> this will break most eGalax setups as the device ID 0x0eef,0x0001 is used
>> in most of them, including the one i have..
>>
>> you'll need to find a way to distinguish the screens. as a starting point
>> i attached an lsusb -vvv output from my screen...
>>
> 
> reading the latest driver guide and programming guide from eGalax (now EETI btw.
> www.eeti.com.tw ) it turns out that the newer devices should support the HID
> format and report with that by default. those newer screens are handled by the
> 'usbhid' driver. have you tried loading that one before usbtouchscreen?

Okay, just built a kernel without the usbtouchscreen driver, and it 
recognized the touchscreen as belonging to the usbhid driver, and it 
works.  Didn't even have to change my X configuration.  Thank you.

(Continue reading)

headers

Dmitry Torokhov | 30 Jun 17:23

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

Hi Alastair,

On Sat, Jun 28, 2008 at 02:18:24PM -0400, Alastair Bridgewater wrote:
>       bInterfaceClass         3 Human Interface Devices
>       bInterfaceSubClass      1 Boot Interface Subclass
>       bInterfaceProtocol      2 Mouse

I think we can try to make usbtouchscreen ignore eGalaxes with
interface class set to HID?

--

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Daniel Ritz | 30 Jun 22:18

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

On Monday 30 June 2008 17:23:35 Dmitry Torokhov wrote:
> Hi Alastair,
> 
> On Sat, Jun 28, 2008 at 02:18:24PM -0400, Alastair Bridgewater wrote:
> >       bInterfaceClass         3 Human Interface Devices
> >       bInterfaceSubClass      1 Boot Interface Subclass
> >       bInterfaceProtocol      2 Mouse
> 
> I think we can try to make usbtouchscreen ignore eGalaxes with
> interface class set to HID?
> 

yeah, i was thinking of that too...something like the attached?
it's completely untested, so no signed-off-by yet...

rgds
-daniel

diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 3a0a8ca..c5b18e6 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -49,6 +49,7 @@
 #include <linux/init.h>
 #include <linux/usb.h>
 #include <linux/usb/input.h>
+#include <linux/hid.h>

 
 #define DRIVER_VERSION		"v0.6"

(Continue reading)

headers

Dmitry Torokhov | 30 Jun 22:24

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

On Mon, Jun 30, 2008 at 10:18:36PM +0200, Daniel Ritz wrote:
> On Monday 30 June 2008 17:23:35 Dmitry Torokhov wrote:
> > Hi Alastair,
> > 
> > On Sat, Jun 28, 2008 at 02:18:24PM -0400, Alastair Bridgewater wrote:
> > >       bInterfaceClass         3 Human Interface Devices
> > >       bInterfaceSubClass      1 Boot Interface Subclass
> > >       bInterfaceProtocol      2 Mouse
> > 
> > I think we can try to make usbtouchscreen ignore eGalaxes with
> > interface class set to HID?
> > 
> 
> yeah, i was thinking of that too...something like the attached?
> it's completely untested, so no signed-off-by yet...
> 

Yeah, that looks nice. If both you guys could test it it'd be grand.

Thanks!

--

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Daniel Ritz | 1 Jul 21:49

Re: [PATCH] input: Add support for eGalax TouchKit USB touchscreen used on HP tx1305us

On Monday 30 June 2008 22:24:09 Dmitry Torokhov wrote:
> On Mon, Jun 30, 2008 at 10:18:36PM +0200, Daniel Ritz wrote:
> > On Monday 30 June 2008 17:23:35 Dmitry Torokhov wrote:
> > > Hi Alastair,
> > > 
> > > On Sat, Jun 28, 2008 at 02:18:24PM -0400, Alastair Bridgewater wrote:
> > > >       bInterfaceClass         3 Human Interface Devices
> > > >       bInterfaceSubClass      1 Boot Interface Subclass
> > > >       bInterfaceProtocol      2 Mouse
> > > 
> > > I think we can try to make usbtouchscreen ignore eGalaxes with
> > > interface class set to HID?
> > > 
> > 
> > yeah, i was thinking of that too...something like the attached?
> > it's completely untested, so no signed-off-by yet...
> > 
> 
> Yeah, that looks nice. If both you guys could test it it'd be grand.
> 

ok, i got around testing the patch with my non-HID screen. it still works.
so from my side it's ok...attached the patch with the signed-off-by line
for your patch queue...

rgds
-daniel
----

[PATCH] usbtouchscreen: ignore newer eGalax screens with HID protocol

(Continue reading)