gmane.linux.kernel.input

Arjan Opmeer | 14 Sep 05:20

[PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1


From: Arjan Opmeer <arjan <at> opmeer.net>

Update the Elantech touchpad driver to v5

- Put the Elantech entry last in the psmouse_protocols[] list as it is also
  the last one in the psmouse_type enum.
- Remove support for relative mode. The driver now always uses the touchpad
  in absolute mode.
- Add support for the new Elantech touchpad model as found in the EeePC that
  uses a new protocol.

Signed-off-by: Arjan Opmeer <arjan <at> opmeer.net>

---

diff --git a/Documentation/input/elantech.txt b/Documentation/input/elantech.txt
index 679e74b..a10c3b6 100644
--- a/Documentation/input/elantech.txt
+++ b/Documentation/input/elantech.txt
@@ -1,27 +1,125 @@
 Elantech Touchpad Driver
 ========================
-        Copyright (C) 2007 Arjan Opmeer <arjan <at> opmeer.net>

-        Extra information found and provided by Steve Havelka
+	Copyright (C) 2007-2008 Arjan Opmeer <arjan <at> opmeer.net>

-Configuration of the touchpad is performed by writing values to registers
-found under sysfs entries /sys/bus/serio/drivers/psmouse/serio?/reg_*.

(Continue reading)

headers

Dmitry Torokhov | 19 Sep 06:17

Re: [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1

Hi Arjan,

On Sun, Sep 14, 2008 at 05:23:44AM +0200, Arjan Opmeer wrote:
> 
> From: Arjan Opmeer <arjan <at> opmeer.net>
> 
> Update the Elantech touchpad driver to v5
> 
> - Put the Elantech entry last in the psmouse_protocols[] list as it is also
>   the last one in the psmouse_type enum.
> - Remove support for relative mode. The driver now always uses the touchpad
>   in absolute mode.
> - Add support for the new Elantech touchpad model as found in the EeePC that
>   uses a new protocol.
> 

Could you tell me if issues with pressure reporting mentioned in
bugzilla #8781 have been resolved? I am about to put the driver in my
tree and need to know if I can enable it unconditionally or need to
mark it experimental.

Thanks!

--

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

headers

Arjan Opmeer | 19 Sep 09:05

Re: [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1

Hi Dmitry,

(Sorry for calling you Dimitry earlier :)

On Fri, Sep 19, 2008 at 12:17:27AM -0400, Dmitry Torokhov wrote:
> On Sun, Sep 14, 2008 at 05:23:44AM +0200, Arjan Opmeer wrote:
> > 
> > Update the Elantech touchpad driver to v5
> 
> Could you tell me if issues with pressure reporting mentioned in bugzilla
> #8781 have been resolved?

I am not exactly sure what the issue is that is described there.

As far as I know the touchpad does not report pressure (maybe the EeePC
style touchpad does, but I do not have hands on experience with that).
However the Xorg Synaptics driver requires pressure events to work. So I
chose a default pressure value and the driver always toggles between no
pressure and default pressure for no touch and touch respectively. This
seems to work well for all my testers as I have not heard any complaints.

A related issue seems to be that the Ubuntu packaged version of the Xorg
Synaptics driver appears to have a bug where adjusting MaxTapTime doesn't
have any effect. In the absence of true pressure reporting this is the
primary parameter to configure ones personal tapping preference for the
Elantech touchpad. I believe the bug reporter in question wants to set this
value to 0 to disable tapping altogether (although the TouchpadOff option
would be better suited), but because of this bug cannot do so.

(Continue reading)

headers

Dmitry Torokhov | 16 Oct 05:05

Re: [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1

Hi Arjan,

On Fri, Sep 19, 2008 at 09:05:30AM +0200, Arjan Opmeer wrote:
> 
> Hi Dmitry,
> 
> (Sorry for calling you Dimitry earlier :)
> 
> On Fri, Sep 19, 2008 at 12:17:27AM -0400, Dmitry Torokhov wrote:
> > On Sun, Sep 14, 2008 at 05:23:44AM +0200, Arjan Opmeer wrote:
> > > 
> > > Update the Elantech touchpad driver to v5
> > 
> > Could you tell me if issues with pressure reporting mentioned in bugzilla
> > #8781 have been resolved?
> 
> I am not exactly sure what the issue is that is described there.
> 
> As far as I know the touchpad does not report pressure (maybe the EeePC
> style touchpad does, but I do not have hands on experience with that).
> However the Xorg Synaptics driver requires pressure events to work. So I
> chose a default pressure value and the driver always toggles between no
> pressure and default pressure for no touch and touch respectively. This
> seems to work well for all my testers as I have not heard any complaints.
> 

I see. In this case the driver should not really report ABS_PRESSURE but
only BTN_TOUCH. I understand that this would require synaptics X driver
changes but that should be OK. I wrote a patch to the X driver which
seems to be working if I bastardize my synaptics touchpad but I would

(Continue reading)

headers

Arjan Opmeer | 16 Oct 06:29

Re: [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1


Hi Dmitry,

On Wed, Oct 15, 2008 at 11:05:15PM -0400, Dmitry Torokhov wrote:
> > 
> > As far as I know the touchpad does not report pressure
> 
> I see. In this case the driver should not really report ABS_PRESSURE but
> only BTN_TOUCH. I understand that this would require synaptics X driver
> changes but that should be OK. I wrote a patch to the X driver which seems
> to be working if I bastardize my synaptics touchpad but I would like to
> have it tested with real Elantech device. I am attaching the version of
> Elantech driver that I want to apply (there were some timy changes) and
> the patch to teh Synaptics X driver (against recent git pull from its
> repository). If you could give it a try that would be grand.

Well, there we have a problem. My laptop with the Elantech touchpad died. So
I no longer have any hardware to try your changes on!

Maybe we should just put the code out there and see what happens?

As I was reading over the patch I found some small things you might want to
change.

> dropped (users wishing to use touchpad in relative mode can use
> standard PS/2 protocol emilation done in hardware). The driver
                         ^^^^^^^^^ emulation

> +	case 2:
> +		/* We don't now how to check parity in protocol v2 */

(Continue reading)

headers

Dmitry Torokhov | 16 Oct 06:48

Re: [PATCH] input: Update Elantech touchpad driver to v5 for kernel 2.6.27-rc5-mm1

On Thu, Oct 16, 2008 at 06:29:09AM +0200, Arjan Opmeer wrote:
> 
> Hi Dmitry,
> 
> On Wed, Oct 15, 2008 at 11:05:15PM -0400, Dmitry Torokhov wrote:
> > > 
> > > As far as I know the touchpad does not report pressure
> > 
> > I see. In this case the driver should not really report ABS_PRESSURE but
> > only BTN_TOUCH. I understand that this would require synaptics X driver
> > changes but that should be OK. I wrote a patch to the X driver which seems
> > to be working if I bastardize my synaptics touchpad but I would like to
> > have it tested with real Elantech device. I am attaching the version of
> > Elantech driver that I want to apply (there were some timy changes) and
> > the patch to teh Synaptics X driver (against recent git pull from its
> > repository). If you could give it a try that would be grand.
> 
> Well, there we have a problem. My laptop with the Elantech touchpad died. So
> I no longer have any hardware to try your changes on!
> 

Oops, sorry to hear that. It looks like i wait for too long...

> Maybe we should just put the code out there and see what happens?
> 

I suppose so, it was in Andrew's tree for a while.

> 
> As I was reading over the patch I found some small things you might want to

(Continue reading)