Re: [PATCH 3/7] powerpc32: pull in libfdt

On Thu, Apr 01, 2010 at 09:05:59AM +0200, Sebastian Andrzej Siewior wrote:
> * Simon Horman | 2010-04-01 09:58:19 [+1100]:
> 
> >Hi,
> Hi,
> 
> >I'm seeing some signed vs unsigned comparison warnings in this code.
> >Here is a stab that I took at fixing them. Do they seem reasonable to you?
> All but fdt_create() and fdt_strerror() look fine on the first look. The
> two mentioned don't have the .c file updated. fdt_strerror() should
> remain unsigned as the error code is negative.
> 
> >If so, we could either merge them into your patch or just apply them
> >as another patch.
> I would prefer leaving it as it. It is an external library and the time
> we update it, we lose this changes. If you are going to compile this
> with -Werror could you add -Wno-sign-compare for the libfdt part? If not
> please apply it as a separate patch and I try to forward it upstream if
> you don't.

Ok, how about we a) merge your changes as is and b) try and get a patch
upstream that we add to kexec-tools later. I understand your reasoning
behind not wanting to diverge from libfdt-upstream, but at the same
time, I'd like to get this fixed if possible.