Linux MMC/SD subsystem ()

Mark Brown | 2 Jan 2012 12:49

Re: [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend

On Mon, Jan 02, 2012 at 11:07:59AM +0900, Jaehoon Chung wrote:
> On 12/30/2011 11:24 AM, Mark Brown wrote:

> > +#include <linux/pm.h>

> I think this include is unnecessary.

I think you are wrong.  What makes you say that you think it is not
needed?

> > +#ifdef CONFIG_PM
> >  static const struct dev_pm_ops sdhci_s3c_pmops = {
> > -	.suspend	= sdhci_s3c_suspend,
> > -	.resume		= sdhci_s3c_resume,
> > +	SET_SYSTEM_SLEEP_PM_OPS(sdhci_s3c_suspend, sdhci_s3c_resume)

Note that above.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Jae hoon Chung | 2 Jan 2012 16:24

Re: [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend

2012/1/2 Mark Brown <broonie <at> opensource.wolfsonmicro.com>:
> On Mon, Jan 02, 2012 at 11:07:59AM +0900, Jaehoon Chung wrote:
>> On 12/30/2011 11:24 AM, Mark Brown wrote:
>
>> > +#include <linux/pm.h>
>
>> I think this include is unnecessary.
>
> I think you are wrong.  What makes you say that you think it is not
> needed?
If that didn't include,,what's happen?
I think that is already included...Anyway..this patch looks fine to me..
(if use with your patch[2/2]..)

Thanks,
Jaehoon Chung
>
>> > +#ifdef CONFIG_PM
>> >  static const struct dev_pm_ops sdhci_s3c_pmops = {
>> > -   .suspend        = sdhci_s3c_suspend,
>> > -   .resume         = sdhci_s3c_resume,
>> > +   SET_SYSTEM_SLEEP_PM_OPS(sdhci_s3c_suspend, sdhci_s3c_resume)
>
> Note that above.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo <at> vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in

(Continue reading)

headers

Mark Brown | 2 Jan 2012 18:32

Re: [PATCH 1/2] mmc: sdhci-s3c: Use CONFIG_PM_SLEEP to ifdef system suspend

On Tue, Jan 03, 2012 at 12:24:53AM +0900, Jae hoon Chung wrote:
> 2012/1/2 Mark Brown <broonie <at> opensource.wolfsonmicro.com>:
> >> On 12/30/2011 11:24 AM, Mark Brown wrote:

> >> > +#include <linux/pm.h>
> >> I think this include is unnecessary.

> > I think you are wrong.  What makes you say that you think it is not
> > needed?

> If that didn't include,,what's happen?

The code won't compile as we're relying on a macro defined in the
header.

> I think that is already included...Anyway..this patch looks fine to me..
> (if use with your patch[2/2]..)

It's not included directly (or indirectly as far as I remember).
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html