headers
Seungwon Jeon | 18 Jun 2012 07:43

[PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

This patch supports packed write command of eMMC4.5 device.
Several writes can be grouped in packed command and all data
of the individual commands can be sent in a single transfer
on the bus.

Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
---
 drivers/mmc/card/block.c   |  406 +++++++++++++++++++++++++++++++++++++++++---
 drivers/mmc/card/queue.c   |   45 +++++-
 drivers/mmc/card/queue.h   |   12 ++
 drivers/mmc/core/mmc_ops.c |    1 +
 include/linux/mmc/core.h   |    4 +
 5 files changed, 441 insertions(+), 27 deletions(-)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 7e3f453..eb99e35 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
 <at>  <at>  -58,6 +58,12  <at>  <at>  MODULE_ALIAS("mmc:block");
 #define INAND_CMD38_ARG_SECTRIM1 0x81
 #define INAND_CMD38_ARG_SECTRIM2 0x88

+#define mmc_req_rel_wr(req)	(((req->cmd_flags & REQ_FUA) || \
+			(req->cmd_flags & REQ_META)) && \
+			(rq_data_dir(req) == WRITE))
+#define PACKED_CMD_VER		0x01
+#define PACKED_CMD_WR		0x02
+
 static DEFINE_MUTEX(block_mutex);
(Continue reading)

Permalink | Reply |
headers
merez | 18 Jun 2012 13:56

Re: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

Looks good to me.
Reviewed-by: Maya Erez <merez <at> codeaurora.org>

On Sun, June 17, 2012 10:43 pm, Seungwon Jeon wrote:
> This patch supports packed write command of eMMC4.5 device.
> Several writes can be grouped in packed command and all data
> of the individual commands can be sent in a single transfer
> on the bus.
>
> Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> ---
>  drivers/mmc/card/block.c   |  406
> +++++++++++++++++++++++++++++++++++++++++---
>  drivers/mmc/card/queue.c   |   45 +++++-
>  drivers/mmc/card/queue.h   |   12 ++
>  drivers/mmc/core/mmc_ops.c |    1 +
>  include/linux/mmc/core.h   |    4 +
>  5 files changed, 441 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 7e3f453..eb99e35 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
>  <at>  <at>  -58,6 +58,12  <at>  <at>  MODULE_ALIAS("mmc:block");
>  #define INAND_CMD38_ARG_SECTRIM1 0x81
>  #define INAND_CMD38_ARG_SECTRIM2 0x88
>
> +#define mmc_req_rel_wr(req)	(((req->cmd_flags & REQ_FUA) || \
> +			(req->cmd_flags & REQ_META)) && \
> +			(rq_data_dir(req) == WRITE))
(Continue reading)

Permalink | Reply |
headers
Namjae Jeon | 18 Jun 2012 16:11
Picon

Re: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

2012/6/18 Seungwon Jeon <tgih.jun <at> samsung.com>:
> This patch supports packed write command of eMMC4.5 device.
> Several writes can be grouped in packed command and all data
> of the individual commands can be sent in a single transfer
> on the bus.
>
> Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> ---
this patch looks good to me also.
Reviewed-by: Namjae Jeon <linkinjeon <at> gmail.com>

Thanks.
Permalink | Reply |
headers
Subhash Jadavani | 25 Jun 2012 10:26

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

<Saugata's inputs are needed>

Hi Seungwon,

Please one comment inline below related to large sector size handling for packed commands.

Regards,
Subhash

> -----Original Message-----
> From: linux-mmc-owner <at> vger.kernel.org [mailto:linux-mmc-
> owner <at> vger.kernel.org] On Behalf Of Seungwon Jeon
> Sent: Monday, June 18, 2012 11:13 AM
> To: linux-mmc <at> vger.kernel.org
> Cc: linux-kernel <at> vger.kernel.org; 'Chris Ball'; 'Maya Erez'; 'Subhash Jadavani';
> 'S, Venkatraman'
> Subject: [PATCH RESEND v7 2/3] mmc: core: Support packed write command
> for eMMC4.5 device
> 
> This patch supports packed write command of eMMC4.5 device.
> Several writes can be grouped in packed command and all data of the
> individual commands can be sent in a single transfer on the bus.
> 
> Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> ---
>  drivers/mmc/card/block.c   |  406
> +++++++++++++++++++++++++++++++++++++++++---
>  drivers/mmc/card/queue.c   |   45 +++++-
>  drivers/mmc/card/queue.h   |   12 ++
>  drivers/mmc/core/mmc_ops.c |    1 +
(Continue reading)

Permalink | Reply |
headers
Seungwon Jeon | 26 Jun 2012 05:48

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

Hi Subhash,

Subhash Jadavani <subhashj <at> codeaurora.org> wrote:
> Hi Seungwon,
> 
> Please one comment inline below related to large sector size handling for packed commands.
> 
> Regards,
> Subhash
> 
> > -----Original Message-----
> > From: linux-mmc-owner <at> vger.kernel.org [mailto:linux-mmc-
> > owner <at> vger.kernel.org] On Behalf Of Seungwon Jeon
> > Sent: Monday, June 18, 2012 11:13 AM
> > To: linux-mmc <at> vger.kernel.org
> > Cc: linux-kernel <at> vger.kernel.org; 'Chris Ball'; 'Maya Erez'; 'Subhash Jadavani';
> > 'S, Venkatraman'
> > Subject: [PATCH RESEND v7 2/3] mmc: core: Support packed write command
> > for eMMC4.5 device
> >
> > This patch supports packed write command of eMMC4.5 device.
> > Several writes can be grouped in packed command and all data of the
> > individual commands can be sent in a single transfer on the bus.
> >
> > Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> > ---
> >  drivers/mmc/card/block.c   |  406
> > +++++++++++++++++++++++++++++++++++++++++---
> >  drivers/mmc/card/queue.c   |   45 +++++-
> >  drivers/mmc/card/queue.h   |   12 ++
(Continue reading)

Permalink | Reply |
headers
Saugata Das | 27 Jun 2012 08:25
Favicon

Re: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

On 26 June 2012 09:18, Seungwon Jeon <tgih.jun <at> samsung.com> wrote:
> Hi Subhash,
>
> Subhash Jadavani <subhashj <at> codeaurora.org> wrote:
>> Hi Seungwon,
>>
>> Please one comment inline below related to large sector size handling for packed commands.
>>
>> Regards,
>> Subhash
>>
>> > -----Original Message-----
>> > From: linux-mmc-owner <at> vger.kernel.org [mailto:linux-mmc-
>> > owner <at> vger.kernel.org] On Behalf Of Seungwon Jeon
>> > Sent: Monday, June 18, 2012 11:13 AM
>> > To: linux-mmc <at> vger.kernel.org
>> > Cc: linux-kernel <at> vger.kernel.org; 'Chris Ball'; 'Maya Erez'; 'Subhash Jadavani';
>> > 'S, Venkatraman'
>> > Subject: [PATCH RESEND v7 2/3] mmc: core: Support packed write command
>> > for eMMC4.5 device
>> >
>> > This patch supports packed write command of eMMC4.5 device.
>> > Several writes can be grouped in packed command and all data of the
>> > individual commands can be sent in a single transfer on the bus.
>> >
>> > Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
>> > ---
>> >  drivers/mmc/card/block.c   |  406
>> > +++++++++++++++++++++++++++++++++++++++++---
>> >  drivers/mmc/card/queue.c   |   45 +++++-
(Continue reading)

Permalink | Reply |
headers
Seungwon Jeon | 28 Jun 2012 09:52

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

Saugata Das <saugata.das <at> linaro.org> wrote:
> On 26 June 2012 09:18, Seungwon Jeon <tgih.jun <at> samsung.com> wrote:
> > Hi Subhash,
> >
> > Subhash Jadavani <subhashj <at> codeaurora.org> wrote:
> >> Hi Seungwon,
> >>
> >> Please one comment inline below related to large sector size handling for packed commands.
> >>
> >> Regards,
> >> Subhash
> >>
> >> > -----Original Message-----
> >> > From: linux-mmc-owner <at> vger.kernel.org [mailto:linux-mmc-
> >> > owner <at> vger.kernel.org] On Behalf Of Seungwon Jeon
> >> > Sent: Monday, June 18, 2012 11:13 AM
> >> > To: linux-mmc <at> vger.kernel.org
> >> > Cc: linux-kernel <at> vger.kernel.org; 'Chris Ball'; 'Maya Erez'; 'Subhash Jadavani';
> >> > 'S, Venkatraman'
> >> > Subject: [PATCH RESEND v7 2/3] mmc: core: Support packed write command
> >> > for eMMC4.5 device
> >> >
> >> > This patch supports packed write command of eMMC4.5 device.
> >> > Several writes can be grouped in packed command and all data of the
> >> > individual commands can be sent in a single transfer on the bus.
> >> >
> >> > Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> >> > ---
> >> >  drivers/mmc/card/block.c   |  406
> >> > +++++++++++++++++++++++++++++++++++++++++---
(Continue reading)

Permalink | Reply |
headers
Subhash Jadavani | 28 Jun 2012 11:12

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

Hi Seugwon, Saugata,

Here the actual large sector size support had one issue and anyway as of now
large sector size is not supported on any of the eMMC4.5 devices, whereas
the packed commands are already supported on eMMC4.5 chips so I would prefer
not to hold this patch for issue which is really not created in this patch.

Is this ok?

Regards,
Subhash

> -----Original Message-----
> From: Seungwon Jeon [mailto:tgih.jun <at> samsung.com]
> Sent: Thursday, June 28, 2012 1:22 PM
> To: 'Saugata Das'
> Cc: 'Subhash Jadavani'; linux-mmc <at> vger.kernel.org; linux-
> kernel <at> vger.kernel.org; 'Chris Ball'; 'Maya Erez'; 'S, Venkatraman'
> Subject: RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write
> command for eMMC4.5 device
> 
> Saugata Das <saugata.das <at> linaro.org> wrote:
> > On 26 June 2012 09:18, Seungwon Jeon <tgih.jun <at> samsung.com> wrote:
> > > Hi Subhash,
> > >
> > > Subhash Jadavani <subhashj <at> codeaurora.org> wrote:
> > >> Hi Seungwon,
> > >>
> > >> Please one comment inline below related to large sector size handling
for
(Continue reading)

Permalink | Reply |
headers
Seungwon Jeon | 28 Jun 2012 11:42

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

Hi Subhash,

Subhash Jadavani <subhashj <at> codeaurora.org> wrote:
> Hi Seugwon, Saugata,
> 
> Here the actual large sector size support had one issue and anyway as of now
> large sector size is not supported on any of the eMMC4.5 devices, whereas
> the packed commands are already supported on eMMC4.5 chips so I would prefer
> not to hold this patch for issue which is really not created in this patch.
> 
> Is this ok?
That means you want to keep this issue and expect to apply your last comment?

Your comment:
So for each entry (which is for each request) in packed command header, you need to make sure that
sector count is in multiple of 8 for CMD23 argument and also CMD18/CMD25 arguments (sector address)
must be 4KB aligned.

Thanks,
Seungwon Jeon

> 
> Regards,
> Subhash
> 
> > -----Original Message-----
> > From: Seungwon Jeon [mailto:tgih.jun <at> samsung.com]
> > Sent: Thursday, June 28, 2012 1:22 PM
> > To: 'Saugata Das'
> > Cc: 'Subhash Jadavani'; linux-mmc <at> vger.kernel.org; linux-
(Continue reading)

Permalink | Reply |
headers
Subhash Jadavani | 28 Jun 2012 12:41

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device


> -----Original Message-----
> From: linux-mmc-owner <at> vger.kernel.org [mailto:linux-mmc-
> owner <at> vger.kernel.org] On Behalf Of Seungwon Jeon
> Sent: Thursday, June 28, 2012 3:13 PM
> To: 'Subhash Jadavani'; 'Saugata Das'
> Cc: 'Chris Ball'; 'Maya Erez'; linux-mmc <at> vger.kernel.org; linux-
> kernel <at> vger.kernel.org; 'S, Venkatraman'
> Subject: RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write
> command for eMMC4.5 device
> 
> Hi Subhash,
> 
> Subhash Jadavani <subhashj <at> codeaurora.org> wrote:
> > Hi Seugwon, Saugata,
> >
> > Here the actual large sector size support had one issue and anyway as
> > of now large sector size is not supported on any of the eMMC4.5
> > devices, whereas the packed commands are already supported on eMMC4.5
> > chips so I would prefer not to hold this patch for issue which is really
not
> created in this patch.
> >
> > Is this ok?
> That means you want to keep this issue and expect to apply your last
comment?
> 
> Your comment:
> So for each entry (which is for each request) in packed command header,
you
(Continue reading)

Permalink | Reply |
headers
S, Venkatraman | 26 Jun 2012 10:49
Picon
Favicon
Gravatar

Re: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

On Mon, Jun 18, 2012 at 11:13 AM, Seungwon Jeon <tgih.jun <at> samsung.com> wrote:
> This patch supports packed write command of eMMC4.5 device.
> Several writes can be grouped in packed command and all data
> of the individual commands can be sent in a single transfer
> on the bus.
>
> Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> ---
>  drivers/mmc/card/block.c   |  406 +++++++++++++++++++++++++++++++++++++++++---
>  drivers/mmc/card/queue.c   |   45 +++++-
>  drivers/mmc/card/queue.h   |   12 ++
>  drivers/mmc/core/mmc_ops.c |    1 +
>  include/linux/mmc/core.h   |    4 +
>  5 files changed, 441 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 7e3f453..eb99e35 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
>  <at>  <at>  -58,6 +58,12  <at>  <at>  MODULE_ALIAS("mmc:block");
>  #define INAND_CMD38_ARG_SECTRIM1 0x81
>  #define INAND_CMD38_ARG_SECTRIM2 0x88
>
> +#define mmc_req_rel_wr(req)    (((req->cmd_flags & REQ_FUA) || \
> +                       (req->cmd_flags & REQ_META)) && \
> +                       (rq_data_dir(req) == WRITE))
> +#define PACKED_CMD_VER         0x01
> +#define PACKED_CMD_WR          0x02
> +
>  static DEFINE_MUTEX(block_mutex);
(Continue reading)

Permalink | Reply |
headers
Seungwon Jeon | 26 Jun 2012 11:27

RE: [PATCH RESEND v7 2/3] mmc: core: Support packed write command for eMMC4.5 device

S, Venkatraman <svenkatr <at> ti.com> wrote:
> On Mon, Jun 18, 2012 at 11:13 AM, Seungwon Jeon <tgih.jun <at> samsung.com> wrote:
> > This patch supports packed write command of eMMC4.5 device.
> > Several writes can be grouped in packed command and all data
> > of the individual commands can be sent in a single transfer
> > on the bus.
> >
> > Signed-off-by: Seungwon Jeon <tgih.jun <at> samsung.com>
> > ---
> >  drivers/mmc/card/block.c   |  406 +++++++++++++++++++++++++++++++++++++++++---
> >  drivers/mmc/card/queue.c   |   45 +++++-
> >  drivers/mmc/card/queue.h   |   12 ++
> >  drivers/mmc/core/mmc_ops.c |    1 +
> >  include/linux/mmc/core.h   |    4 +
> >  5 files changed, 441 insertions(+), 27 deletions(-)
> >
> > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> > index 7e3f453..eb99e35 100644
> > --- a/drivers/mmc/card/block.c
> > +++ b/drivers/mmc/card/block.c
> >  <at>  <at>  -58,6 +58,12  <at>  <at>  MODULE_ALIAS("mmc:block");
> >  #define INAND_CMD38_ARG_SECTRIM1 0x81
> >  #define INAND_CMD38_ARG_SECTRIM2 0x88
> >
> > +#define mmc_req_rel_wr(req)    (((req->cmd_flags & REQ_FUA) || \
> > +                       (req->cmd_flags & REQ_META)) && \
> > +                       (rq_data_dir(req) == WRITE))
> > +#define PACKED_CMD_VER         0x01
> > +#define PACKED_CMD_WR          0x02
> > +
(Continue reading)

Permalink | Reply |

Gmane