Linux module-init-tools mailing list ()

Andreas Robinson | 5 May 2009 00:09

[PATCH 0/x] Refactoring mit: Andreas' brain-dump thread

Hi folks,

I'm trying something here. I don't have an online git-repository (does
anyone know of any good providers?) and rather than waiting to complete
a full set of patches, I will post them in this thread one by one. That
way anyone interested can see what is going on in my corner sooner.

I'm not requesting reviews (although you're free to do so anyway). This
is just meant as a notification. However, there will only be patches
that should be good enough to be considered for inclusion.

If you think this is stupid noise, just let me know and I'll go back to
the old way.

Btw, Jon, nice work on the LKML podcast! :)

Cheers,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Robby Workman | 5 May 2009 03:37

Re: [PATCH 0/x] Refactoring mit: Andreas' brain-dump thread

On Tue, 5 May 2009, Andreas Robinson wrote:

> I'm trying something here. I don't have an online git-repository (does
> anyone know of any good providers?) and rather than waiting to complete
> a full set of patches, I will post them in this thread one by one. That
> way anyone interested can see what is going on in my corner sooner.

Have a look at github perhaps.

I've just (within the last few days) decided to work on manual page
updates (which led to a few other minor bits), and I created an
account at github.  I'm not convinced that I did everything entirely
correct yet, as I'm four days into actually *using* git, but here's
hoping.  Anyway, I'll post that in another thread...

-RW
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Andreas Robinson | 5 May 2009 00:09

[PATCH 2/x] ELF: Introduce new elf_file object

elf_file encapsulates an in-memory ELF file and related
operations needed by depmod, modprobe and other tools.

This class is based on struct module, as defined
in depmod.h and will gradually replace moduleops.c

In this commit, elf_file has no users, but compiles cleanly.

Signed-off-by: Andreas Robinson <andr345@...>
---
 elf_core.c |   71 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 elfops.c   |   61 +++++++++++++++++++++++++++++++++++++++++++++++++++
 elfops.h   |   31 ++++++++++++++++++++++++++
 3 files changed, 163 insertions(+), 0 deletions(-)

diff --git a/elf_core.c b/elf_core.c
index 5280b5d..bfd81a5 100644
--- a/elf_core.c
+++ b/elf_core.c
 <at>  <at>  -4,12 +4,22  <at>  <at> 
 #define ElfPERBIT(x) Elf32_##x
 #define ELFPERBIT(x) ELF32_##x

+struct kernel_symbol32 {
+	char value[4];
+	char name[64 - 4];
+};
+
 #elif defined(ELF64BIT)

(Continue reading)

headers

Andreas Robinson | 5 May 2009 00:09

[PATCH 1/x] ELF: Move some ELF functions from util.[ch] to elfops.[ch]

Also move 32/64-bit X-macros (e.g PERBIT) from toplevel
elfops.c into elf_core.c as these are private.

Signed-off-by: Andreas Robinson <andr345@...>
---
 Makefile.am |    4 ++--
 depmod.c    |    1 +
 elf_core.c  |   19 +++++++++++++++++++
 elfops.c    |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 elfops.h    |   13 +++++++++++++
 modinfo.c   |    1 +
 modprobe.c  |    1 +
 moduleops.c |    1 +
 util.c      |   46 +---------------------------------------------
 util.h      |    8 --------
 10 files changed, 91 insertions(+), 55 deletions(-)
 create mode 100644 elfops.c
 create mode 100644 elfops.h

diff --git a/Makefile.am b/Makefile.am
index e5bb4c7..82ccf28 100644
--- a/Makefile.am
+++ b/Makefile.am
 <at>  <at>  -22,8 +22,8  <at>  <at>  EXTRA_insmod_static_SOURCES =
 EXTRA_depmod_SOURCES = moduleops_core.c
 EXTRA_modinfo_SOURCES =

-libmodtools_a_SOURCES = util.c logging.c index.c config_filter.c \
-	util.h depmod.h logging.h index.h list.h config_filter.h
+libmodtools_a_SOURCES = util.c logging.c index.c config_filter.c elfops.c

(Continue reading)