Sachin Kamat | 2 Aug 2012 08:40
Favicon

[PATCH] ARM: Samsung: Make uart_save static in pm.c file

Fixes the following sparse warning:
arch/arm/plat-samsung/pm.c:77:21:
warning: symbol 'uart_save' was not declared. Should it be static?

Signed-off-by: Sachin Kamat <sachin.kamat <at> linaro.org>
---
 arch/arm/plat-samsung/pm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c
index 64ab65f..1507028 100644
--- a/arch/arm/plat-samsung/pm.c
+++ b/arch/arm/plat-samsung/pm.c
 <at>  <at>  -74,7 +74,7  <at>  <at>  unsigned char pm_uart_udivslot;

 #ifdef CONFIG_SAMSUNG_PM_DEBUG

-struct pm_uart_save uart_save[CONFIG_SERIAL_SAMSUNG_UARTS];
+static struct pm_uart_save uart_save[CONFIG_SERIAL_SAMSUNG_UARTS];

 static void s3c_pm_save_uart(unsigned int uart, struct pm_uart_save *save)
 {
--

-- 
1.7.4.1

Kukjin Kim | 7 Aug 2012 12:52

RE: [PATCH] ARM: Samsung: Make uart_save static in pm.c file

Sachin Kamat wrote:
> 
> Fixes the following sparse warning:
> arch/arm/plat-samsung/pm.c:77:21:
> warning: symbol 'uart_save' was not declared. Should it be static?
> 
> Signed-off-by: Sachin Kamat <sachin.kamat <at> linaro.org>
> ---
>  arch/arm/plat-samsung/pm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c
> index 64ab65f..1507028 100644
> --- a/arch/arm/plat-samsung/pm.c
> +++ b/arch/arm/plat-samsung/pm.c
>  <at>  <at>  -74,7 +74,7  <at>  <at>  unsigned char pm_uart_udivslot;
> 
>  #ifdef CONFIG_SAMSUNG_PM_DEBUG
> 
> -struct pm_uart_save uart_save[CONFIG_SERIAL_SAMSUNG_UARTS];
> +static struct pm_uart_save uart_save[CONFIG_SERIAL_SAMSUNG_UARTS];
> 
>  static void s3c_pm_save_uart(unsigned int uart, struct pm_uart_save
*save)
>  {
> --
> 1.7.4.1

Applied, thanks.

(Continue reading)


Gmane