gmane.linux.kernel.wireless.general

Rami Rosen | 6 Oct 15:56

[PATCH 2/2] iwlwifi: fix compliation warning in iwl-scan.c when CONFIG_IWLWIFI_DEBUG is not set.

When CONFIG_IWLWIFI_DEBUG is not set and CONFIG_IWLWIFI is set,
we get this compilation warning:
wireless-next-2.6/drivers/net/wireless/iwlwifi/iwl-scan.c:92: warning:
'iwl_escape_essid' defined but not used

This patch (against wireless-next-2.6 tree) fixes it.

Signed-off-by: Rami Rosen <ramirose@...>

diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index bf855c3..3e5fd0e 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -69,7 +69,7 @@ static int scan_tx_ant[3] = {
 };

 
-
+#ifdef CONFIG_IWLWIFI_DEBUG
 static int iwl_is_empty_essid(const char *essid, int essid_len)
 {
 	/* Single white space is for Linksys APs */
@@ -85,9 +85,10 @@ static int iwl_is_empty_essid(const char *essid, int essid_len)

 	return 1;
 }
+#endif /* CONFIG_IWLWIFI_DEBUG */

(Continue reading)

headers

Tomas Winkler | 6 Oct 16:42

Re: [PATCH 2/2] iwlwifi: fix compliation warning in iwl-scan.c when CONFIG_IWLWIFI_DEBUG is not set.

On Mon, Oct 6, 2008 at 3:59 PM, Rami Rosen <ramirose@...> wrote:
> When CONFIG_IWLWIFI_DEBUG is not set and CONFIG_IWLWIFI is set,
> we get this compilation warning:
> wireless-next-2.6/drivers/net/wireless/iwlwifi/iwl-scan.c:92: warning:
> 'iwl_escape_essid' defined but not used
>
> This patch (against wireless-next-2.6 tree) fixes it.
>
I believe there is queued patch that removes this code completely
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Rami Rosen | 6 Oct 17:21

Re: [PATCH 2/2] iwlwifi: fix compliation warning in iwl-scan.c when CONFIG_IWLWIFI_DEBUG is not set.

Hello,
Yes, now I found you are right;
see:
http://marc.info/?l=linux-wireless&m=122282784617899&w=2

Regards,
Rami Rosen

On Mon, Oct 6, 2008 at 4:42 PM, Tomas Winkler <tomasw@...> wrote:
> On Mon, Oct 6, 2008 at 3:59 PM, Rami Rosen <ramirose@...> wrote:
>> When CONFIG_IWLWIFI_DEBUG is not set and CONFIG_IWLWIFI is set,
>> we get this compilation warning:
>> wireless-next-2.6/drivers/net/wireless/iwlwifi/iwl-scan.c:92: warning:
>> 'iwl_escape_essid' defined but not used
>>
>> This patch (against wireless-next-2.6 tree) fixes it.
>>
> I believe there is queued patch that removes this code completely
> Tomas
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html