Re: p54 build failure

can you turn off html?

On Mon, 2008-10-06 at 22:19 +0200, Christian Lamparter wrote:
> On Monday 06 October 2008 21:48:21 Johannes Berg wrote:
> 
> > p54_parse_eeprom must not be static, or it fails to build on
> powerpc:
> 
> >
> 
> > drivers/net/wireless/p54/p54common.c:482: error:
> 
> > __ksymtab_p54_parse_eeprom causes a section type conflict
> 
> >
> 
> Kind of funny, remember the sparse warning?!
> 
> .../p54common.c:313:5: warning: symbol 'p54_parse_eeprom' was not
> declared.
> Shou

Well, if it's exported then clearly it must be declared in some header
file; therefore the file needs to include that header file. Mindlessly
fixing sparse warnings has never brought anything forward.

johannes