Roland Vossen | 25 Jan 11:51 2011

[PATCH] staging: brcm80211: bugfix for softmac crash on multi cpu configurations

Solved a locking issue that resulted in driver crashes with the 43224 and 43225
chips. The problem has been reported on several fora. Root cause was two fold:
hardware was being manipulated by two unsynchronized threads, and a scan
operation could interfere with an ongoing dynamic calibration process. Fix was
to invoke a lock on wl_ops_config() operation and to set internal flags when a
scan operation is started and stopped.

Please add this to the staging-linus branch.

Reviewed-by: Arend van Spriel <arend@...>
Signed-off-by: Roland Vossen <rvossen@...>
---
 drivers/staging/brcm80211/sys/wl_mac80211.c  |   12 ++++++++++--
 drivers/staging/brcm80211/sys/wlc_mac80211.c |   13 +++++++++++++
 drivers/staging/brcm80211/sys/wlc_pub.h      |    2 ++
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/brcm80211/sys/wl_mac80211.c b/drivers/staging/brcm80211/sys/wl_mac80211.c
index f123588..cd8392b 100644
--- a/drivers/staging/brcm80211/sys/wl_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wl_mac80211.c
 <at>  <at>  -263,9 +263,7  <at>  <at>  ieee_set_channel(struct ieee80211_hw *hw, struct ieee80211_channel *chan,
 	switch (type) {
 	case NL80211_CHAN_HT20:
 	case NL80211_CHAN_NO_HT:
-		WL_LOCK(wl);
 		err = wlc_set(wl->wlc, WLC_SET_CHANNEL, chan->hw_value);
-		WL_UNLOCK(wl);
 		break;
 	case NL80211_CHAN_HT40MINUS:
(Continue reading)

Greg KH | 25 Jan 12:18 2011
Picon

Re: [PATCH] staging: brcm80211: bugfix for softmac crash on multi cpu configurations

On Tue, Jan 25, 2011 at 11:51:56AM +0100, Roland Vossen wrote:
> Solved a locking issue that resulted in driver crashes with the 43224 and 43225
> chips. The problem has been reported on several fora. Root cause was two fold:
> hardware was being manipulated by two unsynchronized threads, and a scan
> operation could interfere with an ongoing dynamic calibration process. Fix was
> to invoke a lock on wl_ops_config() operation and to set internal flags when a
> scan operation is started and stopped.
> 
> Please add this to the staging-linus branch.

Should this also go to the .37 stable kernel tree?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Roland Vossen | 25 Jan 12:24 2011

RE: [PATCH] staging: brcm80211: bugfix for softmac crash on multi cpu configurations

>Should this also go to the .37 stable kernel tree?

Yes it should. Should I send you a patch for the .37 stable kernel tree ?

Thanks, Roland.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Greg KH | 25 Jan 12:41 2011
Picon

Re: [PATCH] staging: brcm80211: bugfix for softmac crash on multi cpu configurations

On Tue, Jan 25, 2011 at 03:24:38AM -0800, Roland Vossen wrote:
> >Should this also go to the .37 stable kernel tree?
> 
> Yes it should. Should I send you a patch for the .37 stable kernel tree ?

Not at the moment, I'll just mark it for the stable tree, and if it
doesn't apply there properly, I'll email you asking for an updated
version.

For more details about the stable kernel process, see the file,
Documentation/stable_kernel_rules.txt

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Gmane