Linux wireless networking development ()

Luis R. Rodriguez | 1 Nov 05:37

Picon

[PATCH 3/7] ath5k: Clean up ath5k rate duration settings

Replace ath5k's rate duration computations for one using
mac80211's internals. Another consideration here is to simply
remove these and put them into initval values. They seem to be
static values based only on mode. We can do this later though once
we can physically confirm by trial and error these are indeed just
used for ACK timeout. The next puzzle is figuring out which registers
are actually setting the control rates.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/ath5k.h |   80 --------------
 drivers/net/wireless/ath5k/hw.c    |  201 ++++++++++++++----------------------
 2 files changed, 76 insertions(+), 205 deletions(-)

diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
index 20567b1..3354b37 100644
--- a/drivers/net/wireless/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath5k/ath5k.h
@@ -374,86 +374,6 @@ enum ath5k_pkt_type {
 )

 /*
- * Used to compute TX times
- */
-#define AR5K_CCK_SIFS_TIME		10
-#define AR5K_CCK_PREAMBLE_BITS		144
-#define AR5K_CCK_PLCP_BITS		48

(Continue reading)

Luis R. Rodriguez | 1 Nov 22:50

Picon

Re: [PATCH 3/7] ath5k: Clean up ath5k rate duration settings

Replace ath5k's rate duration computations for one using
mac80211's internals. Another consideration here is to simply
remove these and put them into initval values. They seem to be
static values based only on mode. We can do this later though once
we can physically confirm by trial and error these are indeed just
used for ACK timeout. The next puzzle is figuring out which registers
are actually setting the control rates.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>

From: Luis R. Rodriguez <mcgrof@...>
To: John Linville <linville@...>
Cc: linux-wireless@..., "Jiri Slaby" <jirislaby@...>,
	"Nick Kossifidis" <mickflemm@...>
Subject: [PATCH 3/7] ath5k: Clean up ath5k rate duration settings

** Resending after running through checkpatch.pl, removes 
** some trailing whitespaces.

Replace ath5k's rate duration computations for one using
mac80211's internals. Another consideration here is to simply
remove these and put them into initval values. They seem to be
static values based only on mode.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

(Continue reading)

Luis R. Rodriguez | 1 Nov 05:38

Picon

[PATCH 4/7] ath5k: Fix clock on OFDM timing computation

We were setting the clock to the turbo sampling rate always, lets fix this
for plain OFDM sampling rate at 40 MHz. I believe this tunes the PLL to
the desired frequency, by setting the mantissa and the exponent.

Changes to hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/hw.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
index 17c46e1..3f78d20 100644
--- a/drivers/net/wireless/ath5k/hw.c
+++ b/drivers/net/wireless/ath5k/hw.c
@@ -698,10 +698,11 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum ieee80211_if_types op_mode,
 		/* Write OFDM timings on 5212*/
 		if (ah->ah_version == AR5K_AR5212) {
 			if (channel->val & CHANNEL_OFDM) {
+				/* Get exponent and mantissa and set it */
 				u32 coef_scaled, coef_exp, coef_man,
 					ds_coef_exp, ds_coef_man, clock;

-				clock = channel->val & CHANNEL_T ? 80 : 40;
+				clock = channel->val & CHANNEL_TURBO ? 80 : 40;
 				coef_scaled = ((5 * (clock << 24)) / 2) /
 					channel->freq;

--

--

(Continue reading)

Luis R. Rodriguez | 1 Nov 05:38

Picon

[PATCH 5/7] ath5k: Move OFDM timings into a helper routine

This move the OFDM timings on ath5k_hw_reset() onto a helper,
ath5k_hw_write_ofdm_timings() to make code cleaner.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/hw.c |   83 ++++++++++++++++++++++++++-------------
 1 files changed, 55 insertions(+), 28 deletions(-)

diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
index 3f78d20..1b9c4f0 100644
--- a/drivers/net/wireless/ath5k/hw.c
+++ b/drivers/net/wireless/ath5k/hw.c
@@ -458,6 +458,56 @@ void ath5k_hw_detach(struct ath5k_hw *ah)
  */

 /**
+ * ath5k_hw_write_ofdm_timings - set OFDM timings on AR5212 
+ *
+ * @ah: the &struct ath5k_hw
+ * @channel: the currently set channel upon reset
+ *
+ * Write the OFDM timings for the AR5212 upon reset. This is a helper for
+ * ath5k_hw_reset(). This seems to tune the PLL a specified frequency
+ * depending on the bandwidth of the channel.
+ *
+ */
+static inline int ath5k_hw_write_ofdm_timings(struct ath5k_hw *ah,

(Continue reading)

Luis R. Rodriguez | 1 Nov 22:53

Picon

Re: [PATCH 5/7] ath5k: Move OFDM timings into a helper routine

** Resending after checkpatch.pl.. 

This move the OFDM timings on ath5k_hw_reset() onto a helper,
ath5k_hw_write_ofdm_timings() to make code cleaner.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/hw.c |   83 ++++++++++++++++++++++++++-------------
 1 files changed, 55 insertions(+), 28 deletions(-)

diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
index 3f78d20..1b9c4f0 100644
--- a/drivers/net/wireless/ath5k/hw.c
+++ b/drivers/net/wireless/ath5k/hw.c
@@ -458,6 +458,56 @@ void ath5k_hw_detach(struct ath5k_hw *ah)
  */

 /**
+ * ath5k_hw_write_ofdm_timings - set OFDM timings on AR5212
+ *
+ * @ah: the &struct ath5k_hw
+ * @channel: the currently set channel upon reset
+ *
+ * Write the OFDM timings for the AR5212 upon reset. This is a helper for
+ * ath5k_hw_reset(). This seems to tune the PLL a specified frequency
+ * depending on the bandwidth of the channel.
+ *

(Continue reading)

Jiri Slaby | 1 Nov 22:57

Picon

Re: [PATCH 5/7] ath5k: Move OFDM timings into a helper routine

On 11/01/2007 10:53 PM, Luis R. Rodriguez wrote:
> ** Resending after checkpatch.pl.. 
> 
> This move the OFDM timings on ath5k_hw_reset() onto a helper,
> ath5k_hw_write_ofdm_timings() to make code cleaner.
> 
> Changes to ath5k.h, hw.c
> Changes-licensed-under: ISC
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@...>
> ---
>  drivers/net/wireless/ath5k/hw.c |   83 ++++++++++++++++++++++++++-------------
>  1 files changed, 55 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
> index 3f78d20..1b9c4f0 100644
> --- a/drivers/net/wireless/ath5k/hw.c
> +++ b/drivers/net/wireless/ath5k/hw.c
> @@ -458,6 +458,56 @@ void ath5k_hw_detach(struct ath5k_hw *ah)
>   */
>  
>  /**
> + * ath5k_hw_write_ofdm_timings - set OFDM timings on AR5212
> + *
> + * @ah: the &struct ath5k_hw
> + * @channel: the currently set channel upon reset
> + *
> + * Write the OFDM timings for the AR5212 upon reset. This is a helper for
> + * ath5k_hw_reset(). This seems to tune the PLL a specified frequency
> + * depending on the bandwidth of the channel.

(Continue reading)

Jiri Slaby | 1 Nov 23:21

Picon

Re: [PATCH 5/7] ath5k: Move OFDM timings into a helper routine

On 11/01/2007 10:57 PM, Jiri Slaby wrote:
> Note, that BUG can return (on configurations where !CONFIG_BUG). It is my fault
> writing you it won't, sorry! Could you post a patch which will add return from
> here and also from places where the BUG() is used in other places?

Ok, after a talk we agreed, that making the BUG() a void is non-recommended
option on embedded and we can let the patch as it is. Hence it is
Acked-by: Jiri Slaby <jirislaby@...>

Nick Kossifidis | 1 Nov 23:27

Picon

Re: [PATCH 5/7] ath5k: Move OFDM timings into a helper routine

2007/11/2, Jiri Slaby <jirislaby@...>:
> On 11/01/2007 10:57 PM, Jiri Slaby wrote:
> > Note, that BUG can return (on configurations where !CONFIG_BUG). It is my fault
> > writing you it won't, sorry! Could you post a patch which will add return from
> > here and also from places where the BUG() is used in other places?
>
> Ok, after a talk we agreed, that making the BUG() a void is non-recommended
> option on embedded and we can let the patch as it is. Hence it is
> Acked-by: Jiri Slaby <jirislaby@...>
>

Acked-by: Nick Kossifidis <mickflemm@...>

--

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun 
Nick

Luis R. Rodriguez | 1 Nov 23:01

Picon

Re: [PATCH 5/7] ath5k: Move OFDM timings into a helper routine

On 11/1/07, Jiri Slaby <jirislaby@...> wrote:
> On 11/01/2007 10:53 PM, Luis R. Rodriguez wrote:
> > ** Resending after checkpatch.pl..
> >
> > This move the OFDM timings on ath5k_hw_reset() onto a helper,
> > ath5k_hw_write_ofdm_timings() to make code cleaner.
> >
> > Changes to ath5k.h, hw.c
> > Changes-licensed-under: ISC
> >
> > Signed-off-by: Luis R. Rodriguez <mcgrof@...>
> > ---
> >  drivers/net/wireless/ath5k/hw.c |   83 ++++++++++++++++++++++++++-------------
> >  1 files changed, 55 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
> > index 3f78d20..1b9c4f0 100644
> > --- a/drivers/net/wireless/ath5k/hw.c
> > +++ b/drivers/net/wireless/ath5k/hw.c
> > @@ -458,6 +458,56 @@ void ath5k_hw_detach(struct ath5k_hw *ah)
> >   */
> >
> >  /**
> > + * ath5k_hw_write_ofdm_timings - set OFDM timings on AR5212
> > + *
> > + * @ah: the &struct ath5k_hw
> > + * @channel: the currently set channel upon reset
> > + *
> > + * Write the OFDM timings for the AR5212 upon reset. This is a helper for
> > + * ath5k_hw_reset(). This seems to tune the PLL a specified frequency

(Continue reading)

Jiri Slaby | 1 Nov 23:02

Picon

Re: [PATCH 5/7] ath5k: Move OFDM timings into a helper routine

On 11/01/2007 11:01 PM, Luis R. Rodriguez wrote:
> On 11/1/07, Jiri Slaby <jirislaby@...> wrote:
>> On 11/01/2007 10:53 PM, Luis R. Rodriguez wrote:
>>> +     if (!(ah->ah_version == AR5K_AR5212) ||
>>> +             !(channel->val & CHANNEL_OFDM))
>>> +             BUG();
>> Note, that BUG can return (on configurations where !CONFIG_BUG). It is my fault
>> writing you it won't, sorry! Could you post a patch which will add return from
>> here and also from places where the BUG() is used in other places?
> 
> The only case where this will trigger is if someone in the driver
> called this on hardware not supported so it is intended.
> 
> Do you want to BUG() and also return?

Yes, exactly.

Luis R. Rodriguez | 1 Nov 05:39

Picon

[PATCH 6/7] ath5k: Clear up settings of AR5K_RSSI_THR register settings

Clear up settings of AR5K_RSSI_THR register settings. These are split between
AR5K_TUNE_BMISS_THRES and AR5K_TUNE_RSSI_THRES.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/ath5k.h |   10 +++++++++-
 drivers/net/wireless/ath5k/hw.c    |   11 ++++-------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
index 3354b37..c8ab09a 100644
--- a/drivers/net/wireless/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath5k/ath5k.h
@@ -86,8 +86,16 @@
 #define AR5K_TUNE_RADAR_ALERT			false
 #define AR5K_TUNE_MIN_TX_FIFO_THRES		1
 #define AR5K_TUNE_MAX_TX_FIFO_THRES		((IEEE80211_MAX_LEN / 64) + 1)
-#define AR5K_TUNE_RSSI_THRES			1792
 #define AR5K_TUNE_REGISTER_TIMEOUT		20000
+/* Register for RSSI threshold has a mask of 0xff, so 255 seems to 
+ * be the max value. */
+#define AR5K_TUNE_RSSI_THRES                   129
+/* This must be set when setting the RSSI threshold otherwise it can 
+ * prevent a reset. If AR5K_RSSI_THR is read after writing to it
+ * the BMISS_THRES will be seen as 0, seems harware doesn't keep 
+ * track of it. Max value depends on harware. For AR5210 this is just 7.
+ * For AR5211+ this seems to be up to 255. */

(Continue reading)

Luis R. Rodriguez | 1 Nov 22:55

Picon

Re: [PATCH 6/7] ath5k: Clear up settings of AR5K_RSSI_THR register settings

** Resending after checkpatch.pl

Clear up settings of AR5K_RSSI_THR register settings. These are split between
AR5K_TUNE_BMISS_THRES and AR5K_TUNE_RSSI_THRES.

Changes to ath5k.h, hw.c
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/ath5k.h |   10 +++++++++-
 drivers/net/wireless/ath5k/hw.c    |   11 ++++-------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
index 3354b37..c8ab09a 100644
--- a/drivers/net/wireless/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath5k/ath5k.h
@@ -86,8 +86,16 @@
 #define AR5K_TUNE_RADAR_ALERT			false
 #define AR5K_TUNE_MIN_TX_FIFO_THRES		1
 #define AR5K_TUNE_MAX_TX_FIFO_THRES		((IEEE80211_MAX_LEN / 64) + 1)
-#define AR5K_TUNE_RSSI_THRES			1792
 #define AR5K_TUNE_REGISTER_TIMEOUT		20000
+/* Register for RSSI threshold has a mask of 0xff, so 255 seems to
+ * be the max value. */
+#define AR5K_TUNE_RSSI_THRES                   129
+/* This must be set when setting the RSSI threshold otherwise it can
+ * prevent a reset. If AR5K_RSSI_THR is read after writing to it
+ * the BMISS_THRES will be seen as 0, seems harware doesn't keep

(Continue reading)

Nick Kossifidis | 1 Nov 14:27

Picon

Re: [PATCH 6/7] ath5k: Clear up settings of AR5K_RSSI_THR register settings

2007/11/1, Luis R. Rodriguez <mcgrof@...>:
> Clear up settings of AR5K_RSSI_THR register settings. These are split between
> AR5K_TUNE_BMISS_THRES and AR5K_TUNE_RSSI_THRES.
>
> Changes to ath5k.h, hw.c
> Changes-licensed-under: ISC
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@...>
> ---
>  drivers/net/wireless/ath5k/ath5k.h |   10 +++++++++-
>  drivers/net/wireless/ath5k/hw.c    |   11 ++++-------
>  2 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
> index 3354b37..c8ab09a 100644
> --- a/drivers/net/wireless/ath5k/ath5k.h
> +++ b/drivers/net/wireless/ath5k/ath5k.h
> @@ -86,8 +86,16 @@
>  #define AR5K_TUNE_RADAR_ALERT                  false
>  #define AR5K_TUNE_MIN_TX_FIFO_THRES            1
>  #define AR5K_TUNE_MAX_TX_FIFO_THRES            ((IEEE80211_MAX_LEN / 64) + 1)
> -#define AR5K_TUNE_RSSI_THRES                   1792
>  #define AR5K_TUNE_REGISTER_TIMEOUT             20000
> +/* Register for RSSI threshold has a mask of 0xff, so 255 seems to
> + * be the max value. */
> +#define AR5K_TUNE_RSSI_THRES                   129
> +/* This must be set when setting the RSSI threshold otherwise it can
> + * prevent a reset. If AR5K_RSSI_THR is read after writing to it
> + * the BMISS_THRES will be seen as 0, seems harware doesn't keep
> + * track of it. Max value depends on harware. For AR5210 this is just 7.

(Continue reading)

Luis R. Rodriguez | 1 Nov 05:40

Picon

[PATCH 7/7] ath5k: Add documentation for struct ath5k_rate

This adds documentation for struct ath5k_rate. This also removes
some unused variables, lp_ack_duration and sp_ack_duration which
are simply unnecessary. We obviously have information about the rest
of the rate values, we can add more as we go, this just starts this up.
I'll next target cleaning up the RATE macros, think that may be there
the other G mode issues are in.

Changes to ath5k.h
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/ath5k.h |   58 +++++++++++++++++++++++++++++++----
 1 files changed, 51 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
index c8ab09a..7147fb4 100644
--- a/drivers/net/wireless/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath5k/ath5k.h
@@ -549,17 +549,61 @@ struct ath5k_athchan_2ghz {
  * 	 used by the rate control algorytm on MadWiFi.
  */

-#define AR5K_MAX_RATES	32 /*max number of rates on the rate table*/
+/* Max number of rates on the rate table and what it seems 
+ * Atheros hardware supports */
+#define AR5K_MAX_RATES 32

+/**
+ * struct ath5k_rate - rate structure

(Continue reading)

Luis R. Rodriguez | 1 Nov 22:56

Picon

Re: [PATCH 7/7] ath5k: Add documentation for struct ath5k_rate

** Resending after checkpatch.pl

This adds documentation for struct ath5k_rate. This also removes
some unused variables, lp_ack_duration and sp_ack_duration which
are simply unnecessary. We obviously have information about the rest
of the rate values, we can add more as we go, this just starts this up.
I'll next target cleaning up the RATE macros, think that may be there
the other G mode issues are in.

Changes to ath5k.h
Changes-licensed-under: ISC

Signed-off-by: Luis R. Rodriguez <mcgrof@...>
---
 drivers/net/wireless/ath5k/ath5k.h |   58 +++++++++++++++++++++++++++++++----
 1 files changed, 51 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
index c8ab09a..7147fb4 100644
--- a/drivers/net/wireless/ath5k/ath5k.h
+++ b/drivers/net/wireless/ath5k/ath5k.h
@@ -549,17 +549,61 @@ struct ath5k_athchan_2ghz {
  * 	 used by the rate control algorytm on MadWiFi.
  */

-#define AR5K_MAX_RATES	32 /*max number of rates on the rate table*/
+/* Max number of rates on the rate table and what it seems
+ * Atheros hardware supports */
+#define AR5K_MAX_RATES 32

(Continue reading)

Randy Dunlap | 1 Nov 23:06

Re: [PATCH 7/7] ath5k: Add documentation for struct ath5k_rate

On Thu, 1 Nov 2007 17:56:40 -0400 Luis R. Rodriguez wrote:

> ** Resending after checkpatch.pl
> 
> This adds documentation for struct ath5k_rate. This also removes
> some unused variables, lp_ack_duration and sp_ack_duration which
> are simply unnecessary. We obviously have information about the rest
> of the rate values, we can add more as we go, this just starts this up.
> I'll next target cleaning up the RATE macros, think that may be there
> the other G mode issues are in.

Thanks for doing this... but one more change, please:
(just move lines around, see below)

> Changes to ath5k.h
> Changes-licensed-under: ISC
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@...>
> ---
>  drivers/net/wireless/ath5k/ath5k.h |   58 +++++++++++++++++++++++++++++++----
>  1 files changed, 51 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
> index c8ab09a..7147fb4 100644
> --- a/drivers/net/wireless/ath5k/ath5k.h
> +++ b/drivers/net/wireless/ath5k/ath5k.h
> @@ -549,17 +549,61 @@ struct ath5k_athchan_2ghz {
>   * 	 used by the rate control algorytm on MadWiFi.
>   */
>

(Continue reading)

Luis R. Rodriguez | 2 Nov 04:11

Picon

Re: [PATCH 7/7] ath5k: Add documentation for struct ath5k_rate

On Thu, Nov 01, 2007 at 03:06:51PM -0700, Randy Dunlap wrote:
> On Thu, 1 Nov 2007 17:56:40 -0400 Luis R. Rodriguez wrote:
> 
> > ** Resending after checkpatch.pl
> > 
> > This adds documentation for struct ath5k_rate. This also removes
> > some unused variables, lp_ack_duration and sp_ack_duration which
> > are simply unnecessary. We obviously have information about the rest
> > of the rate values, we can add more as we go, this just starts this up.
> > I'll next target cleaning up the RATE macros, think that may be there
> > the other G mode issues are in.
> 
> Thanks for doing this... but one more change, please:
> (just move lines around, see below)
> 
> > Changes to ath5k.h
> > Changes-licensed-under: ISC
> > 
> > Signed-off-by: Luis R. Rodriguez <mcgrof@...>
> > ---
> >  drivers/net/wireless/ath5k/ath5k.h |   58 +++++++++++++++++++++++++++++++----
> >  1 files changed, 51 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
> > index c8ab09a..7147fb4 100644
> > --- a/drivers/net/wireless/ath5k/ath5k.h
> > +++ b/drivers/net/wireless/ath5k/ath5k.h
> > @@ -549,17 +549,61 @@ struct ath5k_athchan_2ghz {
> >   * 	 used by the rate control algorytm on MadWiFi.
> >   */

(Continue reading)

Nick Kossifidis | 1 Nov 14:16

Picon

Re: [PATCH 7/7] ath5k: Add documentation for struct ath5k_rate

2007/11/1, Luis R. Rodriguez <mcgrof@...>:
> This adds documentation for struct ath5k_rate. This also removes
> some unused variables, lp_ack_duration and sp_ack_duration which
> are simply unnecessary. We obviously have information about the rest
> of the rate values, we can add more as we go, this just starts this up.
> I'll next target cleaning up the RATE macros, think that may be there
> the other G mode issues are in.
>
> Changes to ath5k.h
> Changes-licensed-under: ISC
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@...>
> ---
>  drivers/net/wireless/ath5k/ath5k.h |   58 +++++++++++++++++++++++++++++++----
>  1 files changed, 51 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ath5k/ath5k.h b/drivers/net/wireless/ath5k/ath5k.h
> index c8ab09a..7147fb4 100644
> --- a/drivers/net/wireless/ath5k/ath5k.h
> +++ b/drivers/net/wireless/ath5k/ath5k.h
> @@ -549,17 +549,61 @@ struct ath5k_athchan_2ghz {
>   *      used by the rate control algorytm on MadWiFi.
>   */
>
> -#define AR5K_MAX_RATES 32 /*max number of rates on the rate table*/
> +/* Max number of rates on the rate table and what it seems
> + * Atheros hardware supports */
> +#define AR5K_MAX_RATES 32
>
> +/**

(Continue reading)

Luis R. Rodriguez | 1 Nov 17:47

Picon

Re: [PATCH 7/7] ath5k: Add documentation for struct ath5k_rate

On 11/1/07, Nick Kossifidis <mickflemm@...> wrote:

> Acked-by: Nick Kossifidis <mickflemm@...>
>
> Also checkout setcurmode function, i believe we can live without all
> this led-timing stuff and clean up both rate tables and related
> functions.

Yeap -- that is where I am sweeping next. The documentation of the
rates was added in  a specific column arrangement for a good reason :)

  Luis

Return

Return to gmane.linux.kernel.wireless.general.

Search Archive

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane