Linux wireless networking development ()

Attila Fazekas | 23 Feb 2012 19:50

[PATCH] Add AD-HOC support to the rtl8187 based on the rtl8180 source

Add AD-HOC support to the rtl8187 based on the rtl8180 source

Signed-off-by: Attila Fazekas <turul64@...>
---
 drivers/net/wireless/rtl818x/rtl8187/dev.c     |  110 +++++++++++++++++++----
 drivers/net/wireless/rtl818x/rtl8187/rtl8187.h |    9 ++
 2 files changed, 100 insertions(+), 19 deletions(-)

diff --git a/drivers/net/wireless/rtl818x/rtl8187/dev.c b/drivers/net/wireless/rtl818x/rtl8187/dev.c
index 638fbef..cf53ac9 100644
--- a/drivers/net/wireless/rtl818x/rtl8187/dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c
 <at>  <at>  -8,7 +8,7  <at>  <at> 
  * Copyright 2005 Andrea Merello <andreamrl@...>, et al.
  *
  * The driver was extended to the RTL8187B in 2008 by:
- * 	Herton Ronaldo Krzesinski <herton@...>
+ *	Herton Ronaldo Krzesinski <herton@...>
  *	Hin-Tak Leung <htl10@...>
  *	Larry Finger <Larry.Finger@...>
  *
 <at>  <at>  -232,6 +232,7  <at>  <at>  static void rtl8187_tx(struct ieee80211_hw *dev, struct sk_buff *skb)
 {
 	struct rtl8187_priv *priv = dev->priv;
 	struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
+	struct ieee80211_hdr *tx_hdr =	(struct ieee80211_hdr *)(skb->data);
 	unsigned int ep;
 	void *buf;
 	struct urb *urb;
 <at>  <at>  -249,7 +250,7  <at>  <at>  static void rtl8187_tx(struct ieee80211_hw *dev, struct sk_buff *skb)

(Continue reading)

headers

Larry Finger | 24 Feb 2012 00:49

Re: [PATCH] Add AD-HOC support to the rtl8187 based on the rtl8180 source

On 02/23/2012 12:50 PM, Attila Fazekas wrote:
> Add AD-HOC support to the rtl8187 based on the rtl8180 source
>
> Signed-off-by: Attila Fazekas<turul64@...>

You fixed the line wrapping problem. Good.

The subject of the mail should be "[PATCH] rtl8187: Add ....". That way the git 
log has the component being changed in the title of the submit. If the driver 
being patched is in the staging tree, then the line is "[PATCH] staging: 
drivername: title". When submitting a revised version, then use "[PATCH v2] ...".

When I tested this patch, I was not able to even see beacons this time with 
either an RTL8187L or RTL8187B. Could you please send me the commands or script 
that you are using to set up the ad-hoc connection?

Thanks,

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Larry Finger | 6 Mar 2012 00:59

Re: [PATCH] Add AD-HOC support to the rtl8187 based on the rtl8180 source

On 02/23/2012 12:50 PM, Attila Fazekas wrote:
> Add AD-HOC support to the rtl8187 based on the rtl8180 source
>
> Signed-off-by: Attila Fazekas<turul64@...>
> ---
>   drivers/net/wireless/rtl818x/rtl8187/dev.c     |  110 +++++++++++++++++++----
>   drivers/net/wireless/rtl818x/rtl8187/rtl8187.h |    9 ++
>   2 files changed, 100 insertions(+), 19 deletions(-)

ACKed-by: Larry Finger <Larry.Finger@...>

Sorry, it took me so long to test this. I was able to make an ad-hoc connection 
between an RTL8187L and an RTL8187B. The beacon interval is very long, which is 
why I was unable to see them earlier.

Do you know what sets that interval? Is it in the driver?

Larry

>
> diff --git a/drivers/net/wireless/rtl818x/rtl8187/dev.c b/drivers/net/wireless/rtl818x/rtl8187/dev.c
> index 638fbef..cf53ac9 100644
> --- a/drivers/net/wireless/rtl818x/rtl8187/dev.c
> +++ b/drivers/net/wireless/rtl818x/rtl8187/dev.c
>  <at>  <at>  -8,7 +8,7  <at>  <at> 
>    * Copyright 2005 Andrea Merello<andreamrl@...>, et al.
>    *
>    * The driver was extended to the RTL8187B in 2008 by:
> - * 	Herton Ronaldo Krzesinski<herton@...>
> + *	Herton Ronaldo Krzesinski<herton@...>

(Continue reading)