Devendra Naga | 17 Jun 2012 15:47
Picon

[PATCH 1/2] staging/rtl8192u: cleanup coding style problems

The following warnings / errors were cleaned

drivers/staging/rtl8192u/r8180_93cx6.c:25: ERROR: space required before the open parenthesis '('
drivers/staging/rtl8192u/r8180_93cx6.c:28: ERROR: do not use C99 // comments
drivers/staging/rtl8192u/r8180_93cx6.c:30: WARNING: line over 80 characters
drivers/staging/rtl8192u/r8180_93cx6.c:31: ERROR: do not use C99 // comments
drivers/staging/rtl8192u/r8180_93cx6.c:41: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: need consistent spacing a round '&' (ctx:WxO)
drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: space prohibited after that '~' (ctx:OxW)
drivers/staging/rtl8192u/r8180_93cx6.c:51: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/rtl8192u/r8180_93cx6.c:53: ERROR: space required before the open parenthesis '('
drivers/staging/rtl8192u/r8180_93cx6.c:55: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/rtl8192u/r8180_93cx6.c:57: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: space prohibited before that close parenthesis ')'
drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: space required before the open parenthesis '('
drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: trailing statements should be on next line

Signed-off-by: Devendra Naga <devendra.aaru <at> gmail.com>
---
 drivers/staging/rtl8192u/r8180_93cx6.c |   35 +++++++++++++++++---------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c
index 3c515b7..e48a5aa 100644
--- a/drivers/staging/rtl8192u/r8180_93cx6.c
+++ b/drivers/staging/rtl8192u/r8180_93cx6.c
 <at>  <at>  -22,13 +22,17  <at>  <at> 

 void eprom_cs(struct net_device *dev, short bit)
(Continue reading)

Greg Kroah-Hartman | 19 Jun 2012 02:01
Favicon
Gravatar

Re: [PATCH 1/2] staging/rtl8192u: cleanup coding style problems

On Sun, Jun 17, 2012 at 07:17:40PM +0530, Devendra Naga wrote:
> The following warnings / errors were cleaned
> 
> drivers/staging/rtl8192u/r8180_93cx6.c:25: ERROR: space required before the open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:28: ERROR: do not use C99 // comments
> drivers/staging/rtl8192u/r8180_93cx6.c:30: WARNING: line over 80 characters
> drivers/staging/rtl8192u/r8180_93cx6.c:31: ERROR: do not use C99 // comments
> drivers/staging/rtl8192u/r8180_93cx6.c:41: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: need consistent spacing a round '&' (ctx:WxO)
> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: space prohibited after that '~' (ctx:OxW)
> drivers/staging/rtl8192u/r8180_93cx6.c:51: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:53: ERROR: space required before the open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:55: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:57: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: spaces required around that '=' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: space prohibited before that close parenthesis ')'
> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: space required before the open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: trailing statements should be on next line
> 
> Signed-off-by: Devendra Naga <devendra.aaru <at> gmail.com>

It's good you broke this down as to what you were fixing, but I don't
like this change:

> -	if(bit) return 1;
> -	return 0;
> +	return bit ? 1: 0;

Please don't use ? : if you can help it, it is just hard to read.

(Continue reading)

devendra.aaru | 19 Jun 2012 06:30
Picon

Re: [PATCH 1/2] staging/rtl8192u: cleanup coding style problems

Hi Greg,

Thanks for spending your valuable time in reviewing the patch,

On Tue, Jun 19, 2012 at 5:31 AM, Greg Kroah-Hartman
<gregkh <at> linuxfoundation.org> wrote:
> On Sun, Jun 17, 2012 at 07:17:40PM +0530, Devendra Naga wrote:
>> The following warnings / errors were cleaned
>>
>> drivers/staging/rtl8192u/r8180_93cx6.c:25: ERROR: space required before the open parenthesis '('
>> drivers/staging/rtl8192u/r8180_93cx6.c:28: ERROR: do not use C99 // comments
>> drivers/staging/rtl8192u/r8180_93cx6.c:30: WARNING: line over 80 characters
>> drivers/staging/rtl8192u/r8180_93cx6.c:31: ERROR: do not use C99 // comments
>> drivers/staging/rtl8192u/r8180_93cx6.c:41: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: need consistent spacing a round '&' (ctx:WxO)
>> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: space prohibited after that '~' (ctx:OxW)
>> drivers/staging/rtl8192u/r8180_93cx6.c:51: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:53: ERROR: space required before the open parenthesis '('
>> drivers/staging/rtl8192u/r8180_93cx6.c:55: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:57: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: spaces required around that '=' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: space prohibited before that close
parenthesis ')'
>> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: space required before the open parenthesis '('
>> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: trailing statements should be on next line
>>
>> Signed-off-by: Devendra Naga <devendra.aaru <at> gmail.com>
>
> It's good you broke this down as to what you were fixing, but I don't
> like this change:
(Continue reading)

devendra.aaru | 19 Jun 2012 06:30
Picon

Re: [PATCH 1/2] staging/rtl8192u: cleanup coding style problems

Hi Greg,

Thanks for spending your valuable time in reviewing the patch,

On Tue, Jun 19, 2012 at 5:31 AM, Greg Kroah-Hartman
<gregkh <at> linuxfoundation.org> wrote:
> On Sun, Jun 17, 2012 at 07:17:40PM +0530, Devendra Naga wrote:
>> The following warnings / errors were cleaned
>>
>> drivers/staging/rtl8192u/r8180_93cx6.c:25: ERROR: space required before the open parenthesis '('
>> drivers/staging/rtl8192u/r8180_93cx6.c:28: ERROR: do not use C99 // comments
>> drivers/staging/rtl8192u/r8180_93cx6.c:30: WARNING: line over 80 characters
>> drivers/staging/rtl8192u/r8180_93cx6.c:31: ERROR: do not use C99 // comments
>> drivers/staging/rtl8192u/r8180_93cx6.c:41: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: need consistent spacing a round '&' (ctx:WxO)
>> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: space prohibited after that '~' (ctx:OxW)
>> drivers/staging/rtl8192u/r8180_93cx6.c:51: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:53: ERROR: space required before the open parenthesis '('
>> drivers/staging/rtl8192u/r8180_93cx6.c:55: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:57: ERROR: space required after that ',' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: spaces required around that '=' (ctx:VxV)
>> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: space prohibited before that close
parenthesis ')'
>> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: space required before the open parenthesis '('
>> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: trailing statements should be on next line
>>
>> Signed-off-by: Devendra Naga <devendra.aaru <at> gmail.com>
>
> It's good you broke this down as to what you were fixing, but I don't
> like this change:
(Continue reading)

Greg Kroah-Hartman | 19 Jun 2012 02:01
Favicon
Gravatar

Re: [PATCH 1/2] staging/rtl8192u: cleanup coding style problems

On Sun, Jun 17, 2012 at 07:17:40PM +0530, Devendra Naga wrote:
> The following warnings / errors were cleaned
> 
> drivers/staging/rtl8192u/r8180_93cx6.c:25: ERROR: space required before the open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:28: ERROR: do not use C99 // comments
> drivers/staging/rtl8192u/r8180_93cx6.c:30: WARNING: line over 80 characters
> drivers/staging/rtl8192u/r8180_93cx6.c:31: ERROR: do not use C99 // comments
> drivers/staging/rtl8192u/r8180_93cx6.c:41: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: need consistent spacing a round '&' (ctx:WxO)
> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: space prohibited after that '~' (ctx:OxW)
> drivers/staging/rtl8192u/r8180_93cx6.c:51: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:53: ERROR: space required before the open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:55: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:57: ERROR: space required after that ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: spaces required around that '=' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: space prohibited before that close parenthesis ')'
> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: space required before the open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: trailing statements should be on next line
> 
> Signed-off-by: Devendra Naga <devendra.aaru <at> gmail.com>

It's good you broke this down as to what you were fixing, but I don't
like this change:

> -	if(bit) return 1;
> -	return 0;
> +	return bit ? 1: 0;

Please don't use ? : if you can help it, it is just hard to read.

(Continue reading)


Gmane