Linux kernel development

Roland Stigge | 27 Jun 2012 17:51

[PATCH 1/4] mtd: lpc32xx_slc: Select AMBA_PL08X in Kconfig

From: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>

Since this driver depends on the amba pl08x dma driver, select it in Kconfig.

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>
Signed-off-by: Roland Stigge <stigge <at> antcom.de>
---
 drivers/mtd/nand/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index de69978..a9e8b73 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
 <at>  <at>  -417,6 +417,7  <at>  <at>  config MTD_NAND_PXA3xx
 config MTD_NAND_SLC_LPC32XX
 	tristate "NXP LPC32xx SLC Controller"
 	depends on ARCH_LPC32XX
+	select AMBA_PL08X
 	help
 	  Enables support for NXP's LPC32XX SLC (i.e. for Single Level Cell
 	  chips) NAND controller. This is the default for the PHYTEC 3250
--

-- 
1.7.10.4

headers

Roland Stigge | 27 Jun 2012 17:51

[PATCH 2/4] mtd: lpc32xx_slc: Make wp gpio optional

From: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>

This patch supports missing wp gpio.

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>
Signed-off-by: Roland Stigge <stigge <at> antcom.de>
---
 drivers/mtd/nand/lpc32xx_slc.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
index b27b3b3..ab72aca 100644
--- a/drivers/mtd/nand/lpc32xx_slc.c
+++ b/drivers/mtd/nand/lpc32xx_slc.c
 <at>  <at>  -192,7 +192,7  <at>  <at>  struct lpc32xx_nand_cfg_slc {
 	u32     rhold;
 	u32     rsetup;
 	bool    use_bbt;
-	unsigned wp_gpio;
+	int     wp_gpio;
 	struct mtd_partition *parts;
 	unsigned num_parts;
 };
 <at>  <at>  -295,7 +295,8  <at>  <at>  static int lpc32xx_nand_device_ready(struct mtd_info *mtd)
  */
 static void lpc32xx_wp_enable(struct lpc32xx_nand_host *host)
 {
-	gpio_set_value(host->ncfg->wp_gpio, 0);
+	if (gpio_is_valid(host->ncfg->wp_gpio))
+		gpio_set_value(host->ncfg->wp_gpio, 0);

(Continue reading)

headers

Artem Bityutskiy | 29 Jun 2012 12:37

Re: [PATCH 2/4] mtd: lpc32xx_slc: Make wp gpio optional

On Wed, 2012-06-27 at 17:51 +0200, Roland Stigge wrote:
> From: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>
> 
> This patch supports missing wp gpio.
> 
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>
> Signed-off-by: Roland Stigge <stigge <at> antcom.de>

Pushed patches 2-4, thanks!

--

-- 
Best Regards,
Artem Bityutskiy

headers

Roland Stigge | 27 Jun 2012 17:51

[PATCH 3/4] mtd: lpc32xx_slc: Use of_get_named_gpio()

This patch makes the lpc32xx_slc driver use of_get_named_gpio() instead of
of_get_named_gpio_flags() whose flags are discarded anyway.

Signed-off-by: Roland Stigge <stigge <at> antcom.de>
Acked-by: Alexandre Pereira da Silva <aletes.xgr <at> gmail.com>
---
 drivers/mtd/nand/lpc32xx_slc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/lpc32xx_slc.c b/drivers/mtd/nand/lpc32xx_slc.c
index ab72aca..4e8db3a 100644
--- a/drivers/mtd/nand/lpc32xx_slc.c
+++ b/drivers/mtd/nand/lpc32xx_slc.c
 <at>  <at>  -770,7 +770,7  <at>  <at>  static struct lpc32xx_nand_cfg_slc *lpc32xx_parse_dt(struct device *dev)
 	}

 	pdata->use_bbt = of_get_nand_on_flash_bbt(np);
-	pdata->wp_gpio = of_get_named_gpio_flags(np, "gpios", 0, NULL);
+	pdata->wp_gpio = of_get_named_gpio(np, "gpios", 0);

 	return pdata;
 }
--

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)