Lars-Peter Clausen | 1 Jul 2012 13:17
Picon

[PATCH] scripts/coccinelle: Find threaded IRQs requests which are missing IRQF_ONESHOT

Since commit 1c6c69525b ("genirq: Reject bogus threaded irq requests") threaded
IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise
the request will fail. This semantic patch will help to statically identify
(and fix) such cases.

Signed-off-by: Lars-Peter Clausen <lars <at> metafoo.de>
---
 scripts/coccinelle/misc/irqf_oneshot.cocci |   65 ++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100644 scripts/coccinelle/misc/irqf_oneshot.cocci

diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
new file mode 100644
index 0000000..6cfde94
--- /dev/null
+++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
 <at>  <at>  -0,0 +1,65  <at>  <at> 
+/// Make sure threaded IRQs without a primary handler are always request with
+/// IRQF_ONESHOT
+///
+//
+// Confidence: Good
+// Comments:
+// Options: --no-includes
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
(Continue reading)

Julia Lawall | 1 Jul 2012 13:39
Picon
Favicon

Re: [Cocci] [PATCH] scripts/coccinelle: Find threaded IRQs requests which are missing IRQF_ONESHOT


On Sun, 1 Jul 2012, Lars-Peter Clausen wrote:

> Since commit 1c6c69525b ("genirq: Reject bogus threaded irq requests") threaded
> IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise
> the request will fail. This semantic patch will help to statically identify
> (and fix) such cases.
>
> Signed-off-by: Lars-Peter Clausen <lars <at> metafoo.de>

Signed-off-by: Julia Lawall <Julia.Lawall <at> lip6.fr>

> ---
>  scripts/coccinelle/misc/irqf_oneshot.cocci |   65 ++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
>  create mode 100644 scripts/coccinelle/misc/irqf_oneshot.cocci
>
> diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci
> new file mode 100644
> index 0000000..6cfde94
> --- /dev/null
> +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci
>  <at>  <at>  -0,0 +1,65  <at>  <at> 
> +/// Make sure threaded IRQs without a primary handler are always request with
> +/// IRQF_ONESHOT
> +///
> +//
> +// Confidence: Good
> +// Comments:
> +// Options: --no-includes
(Continue reading)


Gmane