함명주 | 6 Aug 2012 04:15

Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

> From: anish kumar <anish198519851985 <at> gmail.com>
> 
> External connector devices that decides connection information based on
> ADC values may use adc-jack device driver. The user simply needs to
> provide a table of adc range and connection states. Then, extcon
> framework will automatically notify others.
> 
> Signed-off-by: anish kumar <anish.singh <at> samsung.com>

- Please remove "get_adc" callbacks still remaining in the header file
(and its comments)

- Let's not modify un-related driver code (in Kconfig, extcon-gpio)

Except that, things look good.


Cheers
MyungJoo


anish kumar | 6 Aug 2012 04:44
Picon

Re: [PATCH] Extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices

On Mon, 2012-08-06 at 02:15 +0000, 함명주 wrote:
> > From: anish kumar <anish198519851985@...>
> > 
> > External connector devices that decides connection information based on
> > ADC values may use adc-jack device driver. The user simply needs to
> > provide a table of adc range and connection states. Then, extcon
> > framework will automatically notify others.
> > 
> > Signed-off-by: anish kumar <anish.singh@...>
> 
> - Please remove "get_adc" callbacks still remaining in the header file
> (and its comments)
aha.Forgot to remove this.
> 
> - Let's not modify un-related driver code (in Kconfig, extcon-gpio)
I think this was unintended(my mistake).Sending the patch again.
> 
> Except that, things look good.
> 
> 
> Cheers
> MyungJoo
> 
> 


Gmane