gmane.linux.kernel

Uros Bizjak | 20 Aug 10:42

[PATCH] x86: Use X86_CR4_PGE in x86/power/hibernate_asm_32.S

Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>
---
diff --git a/arch/x86/power/hibernate_asm_32.S
b/arch/x86/power/hibernate_asm_32.S
index 4fc7e87..6fa219e 100644
--- a/arch/x86/power/hibernate_asm_32.S
+++ b/arch/x86/power/hibernate_asm_32.S
@@ -1,5 +1,3 @@
-.text
-
 /*
  * This may not use any stack, nor any variable that is not "NoSave":
  *
@@ -8,21 +6,21 @@
  * your own stack under you is bad idea.
  */

+	.text
 #include <linux/linkage.h>
 #include <asm/segment.h>
 #include <asm/page.h>
 #include <asm/asm-offsets.h>
-
-	.text
+#include <asm/processor-flags.h>

 ENTRY(swsusp_arch_suspend)
-
 	movl %esp, saved_context_esp
 	movl %ebx, saved_context_ebx

(Continue reading)

headers

Ingo Molnar | 20 Aug 11:53

Re: [PATCH] x86: Use X86_CR4_PGE in x86/power/hibernate_asm_32.S


* Uros Bizjak <ubizjak <at> gmail.com> wrote:

> Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>

applied the commit below to tip/x86/cleanups - thanks Uros.

i did a small change: i moved the .text to after the include files. 
While include files are not supposed to change section attributes, it 
looks logically more consistent to have the .text right before the code.

	Ingo

----------------->
From c171f465b7281f2d3b03e9145ec763d6a8bab176 Mon Sep 17 00:00:00 2001
From: Uros Bizjak <ubizjak <at> gmail.com>
Date: Wed, 20 Aug 2008 10:44:47 +0200
Subject: [PATCH] x86, cleanup: use X86_CR4_PGE in x86/power/hibernate_asm_32.S

Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>
Signed-off-by: Ingo Molnar <mingo <at> elte.hu>
---
 arch/x86/power/hibernate_asm_32.S |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/x86/power/hibernate_asm_32.S b/arch/x86/power/hibernate_asm_32.S
index 4fc7e87..d1e9b53 100644
--- a/arch/x86/power/hibernate_asm_32.S
+++ b/arch/x86/power/hibernate_asm_32.S
@@ -1,5 +1,3 @@

(Continue reading)

headers

Rafael J. Wysocki | 20 Aug 15:01

Re: [PATCH] x86: Use X86_CR4_PGE in x86/power/hibernate_asm_32.S

On Wednesday, 20 of August 2008, Ingo Molnar wrote:
> 
> * Uros Bizjak <ubizjak <at> gmail.com> wrote:
> 
> > Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>
> 
> applied the commit below to tip/x86/cleanups - thanks Uros.
> 
> i did a small change: i moved the .text to after the include files. 
> While include files are not supposed to change section attributes, it 
> looks logically more consistent to have the .text right before the code.
> 
> 	Ingo
> 
> ----------------->
> From c171f465b7281f2d3b03e9145ec763d6a8bab176 Mon Sep 17 00:00:00 2001
> From: Uros Bizjak <ubizjak <at> gmail.com>
> Date: Wed, 20 Aug 2008 10:44:47 +0200
> Subject: [PATCH] x86, cleanup: use X86_CR4_PGE in x86/power/hibernate_asm_32.S
> 
> Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>
> Signed-off-by: Ingo Molnar <mingo <at> elte.hu>

Acked-by: Rafael J. Wysocki <rjw <at> sisk.pl>

> ---
>  arch/x86/power/hibernate_asm_32.S |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/x86/power/hibernate_asm_32.S b/arch/x86/power/hibernate_asm_32.S

(Continue reading)

headers

Pavel Machek | 20 Aug 21:25

Re: [PATCH] x86: Use X86_CR4_PGE in x86/power/hibernate_asm_32.S

On Wed 2008-08-20 11:53:53, Ingo Molnar wrote:
> 
> * Uros Bizjak <ubizjak <at> gmail.com> wrote:
> 
> > Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>
> 
> applied the commit below to tip/x86/cleanups - thanks Uros.
> 
> i did a small change: i moved the .text to after the include files. 
> While include files are not supposed to change section attributes, it 
> looks logically more consistent to have the .text right before the code.
> 
> 	Ingo
> 
> ----------------->
> >From c171f465b7281f2d3b03e9145ec763d6a8bab176 Mon Sep 17 00:00:00 2001
> From: Uros Bizjak <ubizjak <at> gmail.com>
> Date: Wed, 20 Aug 2008 10:44:47 +0200
> Subject: [PATCH] x86, cleanup: use X86_CR4_PGE in x86/power/hibernate_asm_32.S
> 
> Signed-off-by: Uros Bizjak <ubizjak <at> gmail.com>
> Signed-off-by: Ingo Molnar <mingo <at> elte.hu>

ACK.

--

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html