User interface development mailing list for OLPC. ()

Daniel Francis | 29 Jun 2012 23:25

[PATCH Speak] A lot of pep8 corrections

I'm porting Speak Activity to Gtk3, this patch is the first step.
I have these pending steps to do:
. Remove the toolkit modules and migrate the activity to sugar-toolkit
. Migrate from Hippo to Gtk
. Convert the activity to PyGI; Gtk3 Port Start
. Use gi.repository.Gst in the place of pygst
. Extra corrections; Finishing port

Signed-off-by: Daniel Francis <francis <at> sugarlabs.org>
---
 activity.py       |   40 ++++++++++++++------------
 brain.py          |   46 +++++++++++++++--------------
 chat.py           |   83 +++++++++++++++++++++--------------------------------
 espeak_cmd.py     |    4 ++-
 espeak_gst.py     |    2 ++
 eye.py            |   24 ++++++++++++----
 face.py           |   50 +++++++++++++++++---------------
 fft_mouth.py      |   71 +++++++++++++++++++++++++--------------------
 glasses.py        |   24 +++++++++++-----
 messenger.py      |   20 +++++++++----
 mouth.py          |   25 ++++++++++------
 setup.py          |    6 ++--
 voice.py          |   63 +++++++++++++++++++++-------------------
 waveform_mouth.py |   43 +++++++++++++++------------
 14 files changed, 277 insertions(+), 224 deletions(-)

diff --git a/activity.py b/activity.py
index b973ca9..a044423 100644
--- a/activity.py
+++ b/activity.py

(Continue reading)

headers

Gonzalo Odiard | 30 Jun 2012 03:16

Re: [PATCH Speak] A lot of pep8 corrections

On Fri, Jun 29, 2012 at 6:25 PM, Daniel Francis <francis <at> sugarlabs.org> wrote:

I'm porting Speak Activity to Gtk3, this patch is the first step.
I have these pending steps to do:
. Remove the toolkit modules and migrate the activity to sugar-toolkit
. Migrate from Hippo to Gtk
. Convert the activity to PyGI; Gtk3 Port Start
. Use gi.repository.Gst in the place of pygst
. Extra corrections; Finishing port

Great!

Please coordinate with the activity maintainer.

I think is Aleksey, but Rafael (dirakx) should know better.

To migrate from hippo to gtk, look at the work done in Chat activity.

I am sure a big part can be used.

Gonzalo

_______________________________________________
Sugar-devel mailing list
Sugar-devel <at> lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

headers

S. Daniel Francis | 30 Jun 2012 03:46

Re: [PATCH Speak] A lot of pep8 corrections

2012/6/29 Gonzalo Odiard <gonzalo <at> laptop.org>:
> Great!
> Please coordinate with the activity maintainer.
> I think is Aleksey, but Rafael (dirakx) should know better.
> To migrate from hippo to gtk, look at the work done in Chat activity.
> I am sure a big part can be used.
>
> Gonzalo

Alright, thanks.
I'll ask Rafael about the maintainer and I'll also consider Chat
activity in the moment of remove the Hippo code.

Best regards,
DanielF.

headers

Rafael Ortiz | 30 Jun 2012 06:28

Re: [PATCH Speak] A lot of pep8 corrections

On Fri, Jun 29, 2012 at 8:46 PM, S. Daniel Francis <francis <at> sugarlabs.org> wrote:

2012/6/29 Gonzalo Odiard <gonzalo <at> laptop.org>:
> Great!
> Please coordinate with the activity maintainer.
> I think is Aleksey, but Rafael (dirakx) should know better.
> To migrate from hippo to gtk, look at the work done in Chat activity.
> I am sure a big part can be used.
>
> Gonzalo

Alright, thanks.
I'll ask Rafael about the maintainer and I'll also consider Chat
activity in the moment of remove the Hippo code.

Best regards,
DanielF.
_______________________________________________
Sugar-devel mailing list
Sugar-devel <at> lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Daniel thanks for your patch:

It's now in.

http://git.sugarlabs.org/speak/mainline/commit/4e2df4e10931eac04393c3cc8abe99953b17dcc6

Your migration plan seems o.k, before changing to gtk3 you can work on the master branch, for instance the hippo removal is welcomed on master.

Thanks.

_______________________________________________
Sugar-devel mailing list
Sugar-devel <at> lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

headers

Rafael Ortiz | 30 Jun 2012 06:28

Re: [PATCH Speak] A lot of pep8 corrections

On Fri, Jun 29, 2012 at 8:46 PM, S. Daniel Francis <francis <at> sugarlabs.org> wrote:

2012/6/29 Gonzalo Odiard <gonzalo <at> laptop.org>:
> Great!
> Please coordinate with the activity maintainer.
> I think is Aleksey, but Rafael (dirakx) should know better.
> To migrate from hippo to gtk, look at the work done in Chat activity.
> I am sure a big part can be used.
>
> Gonzalo

Alright, thanks.
I'll ask Rafael about the maintainer and I'll also consider Chat
activity in the moment of remove the Hippo code.

Best regards,
DanielF.
_______________________________________________
Sugar-devel mailing list
Sugar-devel <at> lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Daniel thanks for your patch:

It's now in.

http://git.sugarlabs.org/speak/mainline/commit/4e2df4e10931eac04393c3cc8abe99953b17dcc6

Your migration plan seems o.k, before changing to gtk3 you can work on the master branch, for instance the hippo removal is welcomed on master.

Thanks.

_______________________________________________
Sugar-devel mailing list
Sugar-devel <at> lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

headers

S. Daniel Francis | 30 Jun 2012 03:46

Re: [PATCH Speak] A lot of pep8 corrections

2012/6/29 Gonzalo Odiard <gonzalo <at> laptop.org>:
> Great!
> Please coordinate with the activity maintainer.
> I think is Aleksey, but Rafael (dirakx) should know better.
> To migrate from hippo to gtk, look at the work done in Chat activity.
> I am sure a big part can be used.
>
> Gonzalo

Alright, thanks.
I'll ask Rafael about the maintainer and I'll also consider Chat
activity in the moment of remove the Hippo code.

Best regards,
DanielF.

headers

Gonzalo Odiard | 30 Jun 2012 03:16

Re: [PATCH Speak] A lot of pep8 corrections

On Fri, Jun 29, 2012 at 6:25 PM, Daniel Francis <francis <at> sugarlabs.org> wrote:

I'm porting Speak Activity to Gtk3, this patch is the first step.
I have these pending steps to do:
. Remove the toolkit modules and migrate the activity to sugar-toolkit
. Migrate from Hippo to Gtk
. Convert the activity to PyGI; Gtk3 Port Start
. Use gi.repository.Gst in the place of pygst
. Extra corrections; Finishing port

Great!

Please coordinate with the activity maintainer.

I think is Aleksey, but Rafael (dirakx) should know better.

To migrate from hippo to gtk, look at the work done in Chat activity.

I am sure a big part can be used.

Gonzalo

_______________________________________________
Sugar-devel mailing list
Sugar-devel <at> lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

headers

Chris Leonard | 30 Jun 2012 03:37

Re: [PATCH Speak] A lot of pep8 corrections

Just a suggestion, but if you are going to be that deep in the guts of
the code, I would also include reviewing outstanding tickets in
bugs.sugarlabs.org for component = Speak (and probably dev.laptop.org
Trac also) as an opportunity to fix things while you're very familiar
with the code.

cjl

On Fri, Jun 29, 2012 at 5:25 PM, Daniel Francis <francis <at> sugarlabs.org> wrote:
> I'm porting Speak Activity to Gtk3, this patch is the first step.
> I have these pending steps to do:
> . Remove the toolkit modules and migrate the activity to sugar-toolkit
> . Migrate from Hippo to Gtk
> . Convert the activity to PyGI; Gtk3 Port Start
> . Use gi.repository.Gst in the place of pygst
> . Extra corrections; Finishing port

headers

Chris Leonard | 30 Jun 2012 03:37

Re: [PATCH Speak] A lot of pep8 corrections

Just a suggestion, but if you are going to be that deep in the guts of
the code, I would also include reviewing outstanding tickets in
bugs.sugarlabs.org for component = Speak (and probably dev.laptop.org
Trac also) as an opportunity to fix things while you're very familiar
with the code.

cjl

On Fri, Jun 29, 2012 at 5:25 PM, Daniel Francis <francis <at> sugarlabs.org> wrote:
> I'm porting Speak Activity to Gtk3, this patch is the first step.
> I have these pending steps to do:
> . Remove the toolkit modules and migrate the activity to sugar-toolkit
> . Migrate from Hippo to Gtk
> . Convert the activity to PyGI; Gtk3 Port Start
> . Use gi.repository.Gst in the place of pygst
> . Extra corrections; Finishing port