Pierre Labastie | 27 Feb 2012 12:28
Picon

bug, but good...

Hi,

In jhalfs, there is a supposed guard against the possibility of using
a partially or totally populated $LFS system, unless we ask to
rebuild the Makefile or to clean $LFS:
----------------
if [[ "$REBUILD_MAKEFILE" = "n" ]] ; then

   # If $BUILDDIR has subdirectories like tools/ or bin/, stop the run
   # and notify the user about that.
   if [ -d $BUILDDIR/tools -o -d $BUILDDIR/bin ] && [ -z $CLEAN ] ; then
     eval "$no_empty_builddir"
   fi
---------------
However "no_empty_builddir" is a function (defined in 
common/common-functions),
so that this guard does nothing. Seems to date back r3087, when jhalfs 
was imported
from experimental.

Actually, I am happy that it does not work. It allows me to restart a 
build after
a failure, just at the point where it failed, after modifying something 
which is not
necessary just Makefile.

So I wanted to ask:
Do we correct the bug, or do we suppress the guard

Regards,
(Continue reading)

Pierre Labastie | 27 Feb 2012 15:04
Picon

Re: bug, but good...

Le 27/02/2012 12:28, Pierre Labastie a écrit :
> which is not
> necessary just Makefile.
Please delete preceding sentence from previous message.
--

-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Pierre Labastie | 27 Feb 2012 15:47
Picon

Re: bug, but good...

Le 27/02/2012 15:04, Pierre Labastie a écrit :
> Le 27/02/2012 12:28, Pierre Labastie a écrit :
>> which is not
>> necessary just Makefile.
> Please delete preceding sentence from previous message.
No, please don't. I do not understand myself... Sorry for the noise.

Pierre

--

-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Peter Palmer | 27 Feb 2012 15:23

Re: bug, but good...

On 27 February 2012 11:28, Pierre Labastie <pierre.labastie <at> neuf.fr> wrote:

>     eval "$no_empty_builddir"

 $no_empty_builddir != no_empty_builddir

That's why it's not working.

I am still trying to get my head around the whole build process
control so I don't have an opinion yet.
--

-- 
http://linuxfromscratch.org/mailman/listinfo/alfs-discuss
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page


Gmane