Dan Carpenter | 30 Jun 2012 13:48
Picon
Favicon

[patch -next] netfilter: use kfree_skb() not kfree()

This was should be a kfree_skb() here to free the sk_buff pointer.

Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>

diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
index 1bd1732..dfbb019 100644
--- a/net/bridge/netfilter/ebt_ulog.c
+++ b/net/bridge/netfilter/ebt_ulog.c
 <at>  <at>  -156,7 +156,7  <at>  <at>  static void ebt_ulog_packet(unsigned int hooknr, const struct sk_buff *skb,
 	nlh = nlmsg_put(ub->skb, 0, ub->qlen, 0,
 			size - NLMSG_ALIGN(sizeof(*nlh)), 0);
 	if (!nlh) {
-		kfree(ub->skb);
+		kfree_skb(ub->skb);
 		ub->skb = NULL;
 		goto unlock;
 	}

David Miller | 1 Jul 2012 02:27
Favicon

Re: [patch -next] netfilter: use kfree_skb() not kfree()

From: Dan Carpenter <dan.carpenter <at> oracle.com>
Date: Sat, 30 Jun 2012 14:48:53 +0300

> This was should be a kfree_skb() here to free the sk_buff pointer.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter <at> oracle.com>

My bad, applied, thanks Dan.


Gmane