Jeff Kirsher | 1 Jul 2012 08:02
Picon
Favicon

[net] e1000e: remove use of IP payload checksum

From: Bruce Allan <bruce.w.allan <at> intel.com>

Currently only used when packet split mode is enabled with jumbo frames,
IP payload checksum (for fragmented UDP packets) is mutually exclusive with
receive hashing offload since the hardware uses the same space in the
receive descriptor for the hardware-provided packet checksum and the RSS
hash, respectively.  Users currently must disable jumbos when receive
hashing offload is enabled, or vice versa, because of this incompatibility.
Since testing has shown that IP payload checksum does not provide any real
benefit, just remove it so that there is no longer a choice between jumbos
or receive hashing offload but not both as done in other Intel GbE drivers
(e.g. e1000, igb).

Also, add a missing check for IP checksum error reported by the hardware;
let the stack verify the checksum when this happens.

CC: stable <stable <at> vger.kernel.org> [3.4]
Signed-off-by: Bruce Allan <bruce.w.allan <at> intel.com>
Tested-by: Aaron Brown <aaron.f.brown <at> intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com>
---
 drivers/net/ethernet/intel/e1000e/defines.h |    1 +
 drivers/net/ethernet/intel/e1000e/netdev.c  |   75 +++++----------------------
 2 files changed, 15 insertions(+), 61 deletions(-)

diff --git a/drivers/net/ethernet/intel/e1000e/defines.h b/drivers/net/ethernet/intel/e1000e/defines.h
index 351a409..76edbc1 100644
--- a/drivers/net/ethernet/intel/e1000e/defines.h
+++ b/drivers/net/ethernet/intel/e1000e/defines.h
 <at>  <at>  -103,6 +103,7  <at>  <at> 
(Continue reading)

David Miller | 1 Jul 2012 09:26
Favicon

Re: [net] e1000e: remove use of IP payload checksum

From: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com>
Date: Sat, 30 Jun 2012 23:02:42 -0700

> From: Bruce Allan <bruce.w.allan <at> intel.com>
> 
> Currently only used when packet split mode is enabled with jumbo frames,
> IP payload checksum (for fragmented UDP packets) is mutually exclusive with
> receive hashing offload since the hardware uses the same space in the
> receive descriptor for the hardware-provided packet checksum and the RSS
> hash, respectively.  Users currently must disable jumbos when receive
> hashing offload is enabled, or vice versa, because of this incompatibility.
> Since testing has shown that IP payload checksum does not provide any real
> benefit, just remove it so that there is no longer a choice between jumbos
> or receive hashing offload but not both as done in other Intel GbE drivers
> (e.g. e1000, igb).
> 
> Also, add a missing check for IP checksum error reported by the hardware;
> let the stack verify the checksum when this happens.
> 
> CC: stable <stable <at> vger.kernel.org> [3.4]
> Signed-off-by: Bruce Allan <bruce.w.allan <at> intel.com>
> Tested-by: Aaron Brown <aaron.f.brown <at> intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher <at> intel.com>

Applied, thanks Jeff.

Gmane