Greg KH | 12 Jul 22:21 2012

Apple Thunderbolt Ethernet device support

I have an Apple Thunderbolt Ethernet device here, and running 3.5-rc6 it
isn't detected.  It has PCI id 14e4:1682, which seems like it should be
supported by the tg3 driver.  Any hints?

I guess I could just go and add the device id to the driver and see what
happens...

thanks,

greg k-h
Greg KH | 12 Jul 22:56 2012

[PATCH] tg3: add device id of Apple Thunderbolt Ethernet device

Add a PCI device id for the Apple Thunderbolt Ethernet device

Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>

---

Note, I'm sure there's a better #define for this device, any way I can
determine what it should really be?

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e47ff8b..46576f9 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
 <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
+	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_APPLE)},
 	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
 	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
 	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h
index 93865f8..0a2ddff 100644
--- a/drivers/net/ethernet/broadcom/tg3.h
+++ b/drivers/net/ethernet/broadcom/tg3.h
 <at>  <at>  -63,6 +63,7  <at>  <at> 
 #define  TG3PCI_DEVICE_TIGON3_57766	 0x1686
 #define  TG3PCI_DEVICE_TIGON3_57786	 0x16b3
 #define  TG3PCI_DEVICE_TIGON3_57782	 0x16b7
+#define  TG3PCI_DEVICE_TIGON3_APPLE	 0x1682
(Continue reading)

Greg KH | 13 Jul 01:26 2012

[PATCH v2] tg3: add device id of Apple Thunderbolt Ethernet device

The Apple Thunderbolt ethernet device is already listed in the driver,
but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
allows it to work properly.

Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e47ff8b..3721833 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
 <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
+	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
 	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
 	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
 	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
David Miller | 13 Jul 03:03 2012
Picon

Re: [PATCH v2] tg3: add device id of Apple Thunderbolt Ethernet device


Please stop ignoring the MAINTAINERS entry for this driver
and CC: the appropriate developers.

Thanks.
Greg KH | 13 Jul 03:37 2012

Re: [PATCH v2] tg3: add device id of Apple Thunderbolt Ethernet device

On Thu, Jul 12, 2012 at 06:03:10PM -0700, David Miller wrote:
> 
> Please stop ignoring the MAINTAINERS entry for this driver
> and CC: the appropriate developers.

Sorry about that, will resend.

greg k-h
Greg KH | 13 Jul 03:39 2012

[PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device

The Apple Thunderbolt ethernet device is already listed in the driver,
but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
allows it to work properly.

Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>

---
Resent to Cc: the proper developers this time.

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e47ff8b..3721833 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
 <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
+	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
 	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
 	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
 	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
Roland Dreier | 13 Jul 07:33 2012

Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device

On Thu, Jul 12, 2012 at 6:39 PM, Greg KH <gregkh <at> linuxfoundation.org> wrote:
> The Apple Thunderbolt ethernet device is already listed in the driver,
> but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
> allows it to work properly.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
>
> ---
> Resent to Cc: the proper developers this time.
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index e47ff8b..3721833 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
>  <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
>         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
>         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
>         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> +       {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
>         {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
>         {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
>         {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},

I realize there's no way Greg can know the answer to this or test the
corresponding change...

But for the Broadcom guys:
it looks like there simiarly is code in the driver for at least

TG3PCI_DEVICE_TIGON3_57766
(Continue reading)

Michael Chan | 13 Jul 09:19 2012

Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device

On Thu, 2012-07-12 at 22:33 -0700, Roland Dreier wrote: 
> On Thu, Jul 12, 2012 at 6:39 PM, Greg KH <gregkh <at> linuxfoundation.org> wrote:
> > The Apple Thunderbolt ethernet device is already listed in the driver,
> > but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
> > allows it to work properly.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
> >
> > ---
> > Resent to Cc: the proper developers this time.
> >
> > diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> > index e47ff8b..3721833 100644
> > --- a/drivers/net/ethernet/broadcom/tg3.c
> > +++ b/drivers/net/ethernet/broadcom/tg3.c
> >  <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> >         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> > +       {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
> 
> I realize there's no way Greg can know the answer to this or test the
> corresponding change...
> 
> But for the Broadcom guys:
> it looks like there simiarly is code in the driver for at least
> 
(Continue reading)

Michael Chan | 13 Jul 09:06 2012

Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device

On Thu, 2012-07-12 at 18:39 -0700, Greg KH wrote: 
> The Apple Thunderbolt ethernet device is already listed in the driver,
> but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
> allows it to work properly.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
> 
> ---
> Resent to Cc: the proper developers this time.
> 
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index e47ff8b..3721833 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
>  <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
>  	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> +	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
>  	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
> 

ACK for net-next.  I don't know why Matt added everything to support
this chip except the entry in the PCI ID table.

Acked-by: Michael Chan <mchan <at> broadcom.com>

(Continue reading)

David Miller | 13 Jul 12:00 2012
Picon

Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device

From: "Michael Chan" <mchan <at> broadcom.com>
Date: Fri, 13 Jul 2012 00:06:38 -0700

> On Thu, 2012-07-12 at 18:39 -0700, Greg KH wrote: 
>> The Apple Thunderbolt ethernet device is already listed in the driver,
>> but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
>> allows it to work properly.
>> 
>> Signed-off-by: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
>> 
>> ---
>> Resent to Cc: the proper developers this time.
>> 
>> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
>> index e47ff8b..3721833 100644
>> --- a/drivers/net/ethernet/broadcom/tg3.c
>> +++ b/drivers/net/ethernet/broadcom/tg3.c
>>  <at>  <at>  -298,6 +298,7  <at>  <at>  static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
>>  	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
>>  	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
>>  	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
>> +	{PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
>>  	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
>>  	{PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
>>  	{PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
>> 
> 
> ACK for net-next.  I don't know why Matt added everything to support
> this chip except the entry in the PCI ID table.
> 
(Continue reading)

Greg KH | 12 Jul 22:57 2012

Re: Apple Thunderbolt Ethernet device support

On Thu, Jul 12, 2012 at 01:21:31PM -0700, Greg KH wrote:
> I have an Apple Thunderbolt Ethernet device here, and running 3.5-rc6 it
> isn't detected.  It has PCI id 14e4:1682, which seems like it should be
> supported by the tg3 driver.  Any hints?
> 
> I guess I could just go and add the device id to the driver and see what
> happens...

And that worked, patch sent.

But, as the patch shows, odds are it has a "real" device type in it,
so the #define I used isn't as descriptive as it should be.  Any hints
on how I can figure out what to look at to make it more "correct"?

thanks,

greg k-h

Gmane