2 Feb 2005 18:56
[KJ] [PATCH 1/20] char/lp: remove interruptible_sleep_on_timeout() usage
Nishanth Aravamudan <nacc <at> us.ibm.com>
2005-02-02 17:56:51 GMT
2005-02-02 17:56:51 GMT
Hello,
Please consider applying.
Description: Replace deprecated interruptible_sleep_on_timeout() function calls
with direct wait-queue usage. There may be an existing problem with this driver,
as I am not finding any wake_up_interruptible() callers for the waitq.
Patch is compile-tested.
Signed-off-by: Nishanth Aravamudan <nacc <at> us.ibm.com>
--- 2.6.11-rc2-kj-v/drivers/char/lp.c 2005-01-24 09:34:06.000000000 -0800
+++ 2.6.11-rc2-kj/drivers/char/lp.c 2005-02-02 09:55:30.000000000 -0800
<at> <at> -127,6 +127,7 <at> <at>
#include <linux/poll.h>
#include <linux/console.h>
#include <linux/device.h>
+#include <linux/wait.h>
#include <linux/parport.h>
#undef LP_STATS
<at> <at> -218,6 +219,7 <at> <at> static int lp_reset(int minor)
static void lp_error (int minor)
{
+ DEFINE_WAIT(wait);
int polling;
if (LP_F(minor) & LP_ABORT)
<at> <at> -225,8 +227,9 <at> <at> static void lp_error (int minor)
(Continue reading)
RSS Feed