headers
Hui Wang | 20 Jun 2012 12:13
Picon

[PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set

new_map is allocated according to map_num instead of grp->npins,
if a pin or some pins of a group has NO_PAD_CTL property, the map_num
and the grp->npin are different definitely.

When we set mapping information to the new_map[], we should skip those
pins with NO_PAD_CTL from index, otherwise it is possible the driver
will aceesss to a unallocated region.

Cc: Dong Aisheng <dong.aisheng <at> linaro.org>
Cc: Linus Walleij <linus.walleij <at> linaro.org>
Cc: Shawn Guo <shawn.guo <at> linaro.org>
Signed-off-by: Hui Wang <jason77.wang <at> gmail.com>
---
In the v2, according to dong.aisheng's suggestion, change to use j as index.

 drivers/pinctrl/pinctrl-imx.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
index dd6d93a..2bafb5d 100644
--- a/drivers/pinctrl/pinctrl-imx.c
+++ b/drivers/pinctrl/pinctrl-imx.c
 <at>  <at>  -146,7 +146,7  <at>  <at>  static int imx_dt_node_to_map(struct pinctrl_dev *pctldev,
 	struct pinctrl_map *new_map;
 	struct device_node *parent;
 	int map_num = 1;
-	int i;
+	int i, j;

 	/*
(Continue reading)

Permalink | Reply |
headers
Dong Aisheng | 20 Jun 2012 12:28
Favicon

Re: [PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set

On Wed, Jun 20, 2012 at 06:13:47PM +0800, Hui Wang wrote:
> new_map is allocated according to map_num instead of grp->npins,
> if a pin or some pins of a group has NO_PAD_CTL property, the map_num
> and the grp->npin are different definitely.
> 
> When we set mapping information to the new_map[], we should skip those
> pins with NO_PAD_CTL from index, otherwise it is possible the driver
> will aceesss to a unallocated region.
> 
> Cc: Dong Aisheng <dong.aisheng <at> linaro.org>
> Cc: Linus Walleij <linus.walleij <at> linaro.org>
> Cc: Shawn Guo <shawn.guo <at> linaro.org>
> Signed-off-by: Hui Wang <jason77.wang <at> gmail.com>
> ---
> In the v2, according to dong.aisheng's suggestion, change to use j as index.
> 

Acked-by: Dong Aisheng <dong.aisheng <at> linaro.org>

Thanks

Regards
Dong Aisheng
Permalink | Reply |
headers
Linus Walleij | 20 Jun 2012 21:25
Favicon

Re: [PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set

On Wed, Jun 20, 2012 at 12:13 PM, Hui Wang <jason77.wang <at> gmail.com> wrote:

> new_map is allocated according to map_num instead of grp->npins,
> if a pin or some pins of a group has NO_PAD_CTL property, the map_num
> and the grp->npin are different definitely.
>
> When we set mapping information to the new_map[], we should skip those
> pins with NO_PAD_CTL from index, otherwise it is possible the driver
> will aceesss to a unallocated region.
>
> Cc: Dong Aisheng <dong.aisheng <at> linaro.org>
> Cc: Linus Walleij <linus.walleij <at> linaro.org>
> Cc: Shawn Guo <shawn.guo <at> linaro.org>
> Signed-off-by: Hui Wang <jason77.wang <at> gmail.com>
> ---
> In the v2, according to dong.aisheng's suggestion, change to use j as index.

OK applied this v2 version. Is this a serious bug fix that is causing
regressions right now and needs to go into the -rc:s for v3.5 or can it wait
for v3.6?

Thanks,
Linus Walleij
Permalink | Reply |
headers
Hui Wang | 21 Jun 2012 03:08
Picon

Re: [PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set

Linus Walleij wrote:
> On Wed, Jun 20, 2012 at 12:13 PM, Hui Wang <jason77.wang <at> gmail.com> wrote:
>
>   
>> new_map is allocated according to map_num instead of grp->npins,
>> if a pin or some pins of a group has NO_PAD_CTL property, the map_num
>> and the grp->npin are different definitely.
>>
>> When we set mapping information to the new_map[], we should skip those
>> pins with NO_PAD_CTL from index, otherwise it is possible the driver
>> will aceesss to a unallocated region.
>>
>> Cc: Dong Aisheng <dong.aisheng <at> linaro.org>
>> Cc: Linus Walleij <linus.walleij <at> linaro.org>
>> Cc: Shawn Guo <shawn.guo <at> linaro.org>
>> Signed-off-by: Hui Wang <jason77.wang <at> gmail.com>
>> ---
>> In the v2, according to dong.aisheng's suggestion, change to use j as index.
>>     
>
> OK applied this v2 version. Is this a serious bug fix that is causing
> regressions right now and needs to go into the -rc:s for v3.5 or can it wait
> for v3.6?
>   
It is a bug fix, but currently no {board}.dts can trigger this bug, so 
it  can wait for v3.6.

Regards,
Hui.
> Thanks,
(Continue reading)

Permalink | Reply |
headers
Dong Aisheng | 21 Jun 2012 04:13
Favicon

Re: [PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set

On Wed, Jun 20, 2012 at 09:25:35PM +0200, Linus Walleij wrote:
> On Wed, Jun 20, 2012 at 12:13 PM, Hui Wang <jason77.wang <at> gmail.com> wrote:
> 
> > new_map is allocated according to map_num instead of grp->npins,
> > if a pin or some pins of a group has NO_PAD_CTL property, the map_num
> > and the grp->npin are different definitely.
> >
> > When we set mapping information to the new_map[], we should skip those
> > pins with NO_PAD_CTL from index, otherwise it is possible the driver
> > will aceesss to a unallocated region.
> >
> > Cc: Dong Aisheng <dong.aisheng <at> linaro.org>
> > Cc: Linus Walleij <linus.walleij <at> linaro.org>
> > Cc: Shawn Guo <shawn.guo <at> linaro.org>
> > Signed-off-by: Hui Wang <jason77.wang <at> gmail.com>
> > ---
> > In the v2, according to dong.aisheng's suggestion, change to use j as index.
> 
> OK applied this v2 version. Is this a serious bug fix that is causing
> regressions right now and needs to go into the -rc:s for v3.5 or can it wait
> for v3.6?
> 
Yes, it's a serious bug fix.
Although still not triggered by current dts file but it did may block some legal using
defined in binding doc.
So can it go into rc?

Regards
Dong Aisheng
(Continue reading)

Permalink | Reply |

Gmane