Re: [PATCH v2 6/7] gpio_msm: Move Qualcomm v6 MSM driver into drivers

On Fri, Jun 03, 2011 at 03:44:18PM -0700, David Brown wrote:
> Migrate the driver for the v6-based MSM chips into drivers/gpio.  The
> driver is unchanged, only moved.
> 
> Signed-off-by: David Brown <davidb <at> codeaurora.org>
> Acked-by: Linus Walleij <linus.walleij <at> linaro.org>
> Acked-by: Nicolas Pitre <nicolas.pitre <at> linaro.org>

Hi David,

Comments below.  When you repost, please cc me on the entire
series, not just the last 2.

> ---
>  arch/arm/mach-msm/Kconfig                          |    3 +++
>  arch/arm/mach-msm/Makefile                         |    2 --
>  drivers/gpio/Kconfig                               |    8 ++++++++
>  drivers/gpio/Makefile                              |    1 +
>  arch/arm/mach-msm/gpio.c => drivers/gpio/msm_v1.c  |    7 +++----

drivers/gpio/gpio-msm-v1.c please.  I'm now enforcing a gpio-*.c naming
convention in this directory.  The other drivers will be renamed soon.

>  .../mach-msm/gpio_hw.h => drivers/gpio/msm_v1.h    |    9 ++++-----
>  6 files changed, 19 insertions(+), 11 deletions(-)
>  rename arch/arm/mach-msm/gpio.c => drivers/gpio/msm_v1.c (98%)
>  rename arch/arm/mach-msm/gpio_hw.h => drivers/gpio/msm_v1.h (98%)
> 
> diff --git a/arch/arm/mach-msm/Kconfig b/arch/arm/mach-msm/Kconfig
> index 1516896..cc7c0b2 100644