headers
Sam Ravnborg | 10 Oct 20:42
Gravatar

parisc arch makefile clean-up needed [Was: cleaning up "make headers_install" for various architectures]

It helps when I use the right mailing list address..

	Sam

----- Forwarded message from Sam Ravnborg <sam <at> ravnborg.org> -----

Subject: parisc arch makefile clean-up needed [Was: cleaning up "make headers_install" for various architectures]
Sender: linux-kernel-owner <at> vger.kernel.org
From: Sam Ravnborg <sam <at> ravnborg.org>
Date:	Wed, 10 Oct 2007 20:38:58 +0200
User-Agent: Mutt/1.4.2.1i
To: "Robert P. J. Day" <rpjday <at> mindspring.com>,
	parisc-linux-request <at> lists.parisc-linux.org
Cc: Randy Dunlap <randy.dunlap <at> oracle.com>,
	Linux Kernel Mailing List <linux-kernel <at> vger.kernel.org>,
	Matthew Wilcox <matthew <at> wil.cx>,
	Grant Grundler <grundler <at> parisc-linux.org>,
	Kyle McMartin <kyle <at> parisc-linux.org>
X-Mailing-List:	linux-kernel <at> vger.kernel.org

Added parisc mailing-listi and cc'ed parisc maintainers.

On Wed, Oct 10, 2007 at 01:26:16PM -0400, Robert P. J. Day wrote:
> On Wed, 10 Oct 2007, Randy Dunlap wrote:
> 
> > On Wed, 10 Oct 2007 12:44:58 -0400 (EDT) Robert P. J. Day wrote:
> >
> > >   the final example, parisc, just plain fails:
> > >
> > > $ make ARCH=parisc headers_install
(Continue reading)

Permalink | Reply |
headers
Mike Frysinger | 11 Oct 00:34
Picon
Favicon
Gravatar

Re: parisc arch makefile clean-up needed [Was: cleaning up "make headers_install" for various architectures]

On Wednesday 10 October 2007, Sam Ravnborg wrote:
> And this snippet is also wrong:
> PALO := $(shell if which palo; then : ; \
> 	elif [ -x /sbin/palo ]; then echo /sbin/palo; \
> 	fi)
>
> palo: vmlinux
> 	@if [ -x $PALO ]; then \
>
>
> Make does not export variables so $PALO is not the same as $(PALO).
> The latter should be used.

not even really an export issue ... $PALO will be interpreted by make as 
$(P)ALO and the script will do [ -x ALO ] which is obviously no good :)
-mike

_______________________________________________
parisc-linux mailing list
parisc-linux <at> lists.parisc-linux.org
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux
Permalink | Reply |
headers
Matthew Wilcox | 10 Oct 21:10

Re: parisc arch makefile clean-up needed [Was: cleaning up "make headers_install" for various architectures]

On Wed, Oct 10, 2007 at 08:42:25PM +0200, Sam Ravnborg wrote:
> parisc arch Makefile needs some love and care...
> 
> The logic selecting CROSS_COMPILE seems fishy and wrong -
> the error reported by rday is obvious in this respect.

He doesn't have a compiler installed that can target parisc.  It doesn't
seem obvious to me that this should work.

> FINAL_LD is unused - kill it.

OK.

> Building with oldpalo has been broken for a loong time - time to kill it?
> Hint - the "cd ../palo" is not working as expected.
> And use of TOPDIR is deprecated.

OK, killed.  I don't think anyone still uses that.

> The libs-y assignment should learn from the other architectures how to
> get the gcc lib filename:
> $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)

Actually, this looks utterly unstandardised:

arch/cris/Makefile:LIBGCC = $(shell $(CC) $(CFLAGS) -print-file-name=libgcc.a)
arch/h8300/Makefile:LIBGCC := $(shell $(CROSS-COMPILE)$(CC) $(CFLAGS) -print-libgcc-file-name)
arch/m32r/Makefile:LIBGCC       := $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)
arch/parisc/Makefile:libs-y     += arch/parisc/lib/ `$(CC) -print-libgcc-file-name`
arch/sh64/Makefile:LIBGCC := $(shell $(CC) $(CFLAGS) -print-libgcc-file-name)
(Continue reading)

Permalink | Reply |

Gmane