Development of Linux for the HP PA-RISC platform

Matthew Wilcox | 21 Oct 2007 21:06

Re: [PATCH] VSC_GSC_HSC bus debugging

On Sun, Oct 21, 2007 at 07:54:53PM +0200, Roel Kluin wrote:
> +config GSC_DEBUG
> +	bool "VSC_GSC_HSC bus debugging"

What an ugly prompt string ...

> +	depends on GSC
> +	default n

default is 'n', by default.  No need to specify it.

> +#ifdef GSC_DEBUG
> +	#define DEBUG 1
> +#endif

Why the indent?

> -	DEBPRINTK("%s intr, mask=0x%x\n", gsc_asic->name, irr);
> +	printk("%s intr, mask=0x%x\n", gsc_asic->name, irr);

Presumably you meant pr_debug?

--

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

headers

Roel Kluin | 21 Oct 2007 23:12

Re: [PATCH] VSC_GSC_HSC bus debugging

Matthew Wilcox wrote:
> On Sun, Oct 21, 2007 at 07:54:53PM +0200, Roel Kluin wrote:
>> +config GSC_DEBUG
>> +	bool "VSC_GSC_HSC bus debugging"
> 
> What an ugly prompt string ...

I wrote a script to make these changes, but apparently it's still not perfect
I should have checked it more. I will make changes and resend previously sent
patches. Below is the patch previously called [PATCH] VSC_GSC_HSC bus debugging,
with corrections.

I used "VSC/GSC/HSC bus support" from "config GSC" in the Kconfig. the slashes
were translated to underscores because they previously gave a bug. it's fixed now,
but I think the name "VSC/GSC/HSC bus debugging" is more appropriate here.

>> +	depends on GSC
>> +	default n
> 
> default is 'n', by default.  No need to specify it.

ok fixed that

>> +#ifdef GSC_DEBUG
>> +	#define DEBUG 1
>> +#endif
> 
> Why the indent?

I thought it was more clear. But have that changed now as well.

(Continue reading)