Development of Linux for the HP PA-RISC platform

Emil Medve | 23 Oct 18:14

[PATCH] Use the new sg_page() helper

Fix build error messages such as this:

In file included from include/linux/dma-mapping.h:52,
                 from include/linux/dmaengine.h:29,
                 from include/linux/skbuff.h:29,
                 from include/linux/netlink.h:155,
                 from include/linux/genetlink.h:4,
                 from include/net/genetlink.h:4,
                 from include/linux/taskstats_kern.h:12,
                 from init/main.c:46:
include/asm/dma-mapping.h: In function 'dma_map_sg':
include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named 'page'
include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named 'page'
include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named 'page'
include/asm/dma-mapping.h:290: error: 'struct scatterlist' has no member named 'page'

This change in the struct scatterlist was introduced by this commit: 18dabf473e15850c0dbc8ff13ac1e2806d542c15

Signed-off-by: Emil Medve <Emilian.Medve <at> Freescale.com>
---

linux-2.6> scripts/checkpatch.pl 0001-Use-the-new-sg_page-helper.patch 
Your patch has no obvious style problems and is ready for submission.

 drivers/mmc/host/mmci.h           |    4 ++--
 drivers/pci/intel-iommu.c         |    2 +-
 include/asm-arm/dma-mapping.h     |    8 ++++----
 include/asm-parisc/scatterlist.h  |    3 ++-
 include/asm-powerpc/dma-mapping.h |   10 +++++-----
 include/asm-xtensa/dma-mapping.h  |   10 +++++-----

(Continue reading)

headers

Linus Torvalds | 23 Oct 19:00

Re: [PATCH] Use the new sg_page() helper

On Tue, 23 Oct 2007, Emil Medve wrote:
>
> Fix build error messages such as this:

Some - but apparently not all - of these are already fixed in my tree, 
through pulls from Jens. I just pushed out the result, can you resend the 
parts that didn't already get fixed?

As is, the patch won't apply for me, since it touches many different parts 
and some of them are fixed.

		Linus

headers

Jens Axboe | 23 Oct 20:40

Re: [PATCH] Use the new sg_page() helper

On Tue, Oct 23 2007, Linus Torvalds wrote:
> 
> 
> On Tue, 23 Oct 2007, Emil Medve wrote:
> >
> > Fix build error messages such as this:
> 
> Some - but apparently not all - of these are already fixed in my tree, 
> through pulls from Jens. I just pushed out the result, can you resend the 
> parts that didn't already get fixed?
> 
> As is, the patch won't apply for me, since it touches many different parts 
> and some of them are fixed.

Looks like just the mmc and xtensa bits, I've merged those up.

--

-- 
Jens Axboe

headers

Kristoffer Ericson | 24 Oct 03:55

Re: [PATCH] Use the new sg_page() helper

Great, :D 
Just dropped a bug report about this 5mins ago. Hope it gets commited shortly.

On Tue, 23 Oct 2007 11:14:52 -0500
Emil Medve <Emilian.Medve <at> Freescale.com> wrote:

> Fix build error messages such as this:
> 
> In file included from include/linux/dma-mapping.h:52,
>                  from include/linux/dmaengine.h:29,
>                  from include/linux/skbuff.h:29,
>                  from include/linux/netlink.h:155,
>                  from include/linux/genetlink.h:4,
>                  from include/net/genetlink.h:4,
>                  from include/linux/taskstats_kern.h:12,
>                  from init/main.c:46:
> include/asm/dma-mapping.h: In function 'dma_map_sg':
> include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named 'page'
> include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named 'page'
> include/asm/dma-mapping.h:288: error: 'struct scatterlist' has no member named 'page'
> include/asm/dma-mapping.h:290: error: 'struct scatterlist' has no member named 'page'
> 
> This change in the struct scatterlist was introduced by this commit: 18dabf473e15850c0dbc8ff13ac1e2806d542c15
> 
> Signed-off-by: Emil Medve <Emilian.Medve <at> Freescale.com>
> ---
> 
> linux-2.6> scripts/checkpatch.pl 0001-Use-the-new-sg_page-helper.patch 
> Your patch has no obvious style problems and is ready for submission.
>

(Continue reading)