headers
Jesper Juhl | 11 Apr 22:54
Picon

[PATCH] parisc: kfree cleanup in arch/parisc/


Get rid of redundant NULL pointer checks before kfree() in arch/parisc/ as 
well as a few blank lines.

Signed-off-by: Jesper Juhl <juhl-lkml <at> dif.dk>

diff -upr linux-2.6.12-rc2-mm3-orig/arch/parisc/kernel/ioctl32.c linux-2.6.12-rc2-mm3/arch/parisc/kernel/ioctl32.c
--- linux-2.6.12-rc2-mm3-orig/arch/parisc/kernel/ioctl32.c	2005-04-05 21:21:08.000000000 +0200
+++ linux-2.6.12-rc2-mm3/arch/parisc/kernel/ioctl32.c	2005-04-11 22:48:03.000000000 +0200
@@ -104,12 +104,9 @@ static int drm32_version(unsigned int fd
 	}

 out:
-	if (kversion.name)
-		kfree(kversion.name);
-	if (kversion.date)
-		kfree(kversion.date);
-	if (kversion.desc)
-		kfree(kversion.desc);
+	kfree(kversion.name);
+	kfree(kversion.date);
+	kfree(kversion.desc);
 	return ret;
 }

@@ -166,9 +163,7 @@ static int drm32_getsetunique(unsigned i
 			ret = -EFAULT;
 	}

-	if (karg.unique != NULL)
(Continue reading)

Permalink | Reply |
headers
Grant Grundler | 12 Apr 21:22

Re: [PATCH] parisc: kfree cleanup in arch/parisc/

On Mon, Apr 11, 2005 at 10:54:25PM +0200, Jesper Juhl wrote:
> Get rid of redundant NULL pointer checks before kfree() in arch/parisc/ as 
> well as a few blank lines.
> 
> Signed-off-by: Jesper Juhl <juhl-lkml <at> dif.dk>

thanks!
Commited to cvs.parisc-linux.org:
	http://lists.parisc-linux.org/pipermail/parisc-linux-cvs/2005-April/035542.html

I expect Matthew Wilcox will submit to linus with other parisc code changes
in the next RC release.

thanks,
grant

> 
> diff -upr linux-2.6.12-rc2-mm3-orig/arch/parisc/kernel/ioctl32.c linux-2.6.12-rc2-mm3/arch/parisc/kernel/ioctl32.c
> --- linux-2.6.12-rc2-mm3-orig/arch/parisc/kernel/ioctl32.c	2005-04-05 21:21:08.000000000 +0200
> +++ linux-2.6.12-rc2-mm3/arch/parisc/kernel/ioctl32.c	2005-04-11 22:48:03.000000000 +0200
> @@ -104,12 +104,9 @@ static int drm32_version(unsigned int fd
>  	}
>  
>  out:
> -	if (kversion.name)
> -		kfree(kversion.name);
> -	if (kversion.date)
> -		kfree(kversion.date);
> -	if (kversion.desc)
> -		kfree(kversion.desc);
(Continue reading)

Permalink | Reply |

Gmane