Discussion of the Linux kernel port for the OpenRISC architecture ()

Richard Weinberger | 19 May 2012 13:19

[PATCH] OpenRISC: Make do_signal() non-static

There is no need to export this function.

Signed-off-by: Richard Weinberger <richard <at> nod.at>
---
 arch/openrisc/kernel/signal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c
index 44749d4..f0446ec 100644
--- a/arch/openrisc/kernel/signal.c
+++ b/arch/openrisc/kernel/signal.c
 <at>  <at>  -284,7 +284,7  <at>  <at>  handle_signal(unsigned long sig,
  * mode below.
  */

-void do_signal(struct pt_regs *regs)
+static void do_signal(struct pt_regs *regs)
 {
 	siginfo_t info;
 	int signr;
--

-- 
1.7.7.3

headers

Christoph Hellwig | 20 May 2012 18:18

Re: [PATCH] OpenRISC: Make do_signal() non-static

On Sat, May 19, 2012 at 01:19:07PM +0200, Richard Weinberger wrote:
> There is no need to export this function.

s/non-static/static/ in the subject?

headers

Richard Weinberger | 20 May 2012 18:36

Re: [PATCH] OpenRISC: Make do_signal() non-static

Am 20.05.2012 18:18, schrieb Christoph Hellwig:
> On Sat, May 19, 2012 at 01:19:07PM +0200, Richard Weinberger wrote:
>> There is no need to export this function.
>
> s/non-static/static/ in the subject?
>

*grrr*, yes.

Thanks,
//richard

headers

Jonas Bonn | 25 May 2012 15:25

Re: [PATCH] OpenRISC: Make do_signal() non-static


Thanks, applied.
/Jonas

On Sat, 2012-05-19 at 13:19 +0200, Richard Weinberger wrote:
> There is no need to export this function.
> 
> Signed-off-by: Richard Weinberger <richard <at> nod.at>
> ---
>  arch/openrisc/kernel/signal.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/openrisc/kernel/signal.c b/arch/openrisc/kernel/signal.c
> index 44749d4..f0446ec 100644
> --- a/arch/openrisc/kernel/signal.c
> +++ b/arch/openrisc/kernel/signal.c
>  <at>  <at>  -284,7 +284,7  <at>  <at>  handle_signal(unsigned long sig,
>   * mode below.
>   */
>  
> -void do_signal(struct pt_regs *regs)
> +static void do_signal(struct pt_regs *regs)
>  {
>  	siginfo_t info;
>  	int signr;