Communications among developers and users of Linux on embedded PowerPC boards

Dongsheng.wang | 10 Aug 2012 07:54

[PATCH v2 2/2] powerpc/mpic: add global timer support

From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>

The MPIC global timer is a hardware timer inside the Freescale PIC comply
to Open-PIC standard. When the timer is timeout of the specified interval,
the hardware timer generates an interrupt. The driver currently is only
tested on fsl chip, but it can potentially support other global timers
complying to Open-PIC standard.
The two independent groups of global timer on fsl chip, group A and group B,
are identical in their functionality, except that they appear at different
locations within the PIC register map. The hardware timer can be cascaded to
create timers larger than the default 31-bit global timers. Timer cascade
fields allow configuration of up to two 63-bit timers. But These two groups
of timers cannot be cascaded together.
It can be used as a wakeup source for low power modes. It also could be used
as periodical timer for protocols, drivers and etc.

Signed-off-by: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>
Signed-off-by: Li Yang <leoli <at> freescale.com>
---
 arch/powerpc/include/asm/mpic_timer.h |   15 +
 arch/powerpc/platforms/Kconfig        |    5 +
 arch/powerpc/sysdev/Makefile          |    1 +
 arch/powerpc/sysdev/mpic_timer.c      |  525 +++++++++++++++++++++++++++++++++
 4 files changed, 546 insertions(+), 0 deletions(-)
 create mode 100644 arch/powerpc/include/asm/mpic_timer.h
 create mode 100644 arch/powerpc/sysdev/mpic_timer.c

diff --git a/arch/powerpc/include/asm/mpic_timer.h b/arch/powerpc/include/asm/mpic_timer.h
new file mode 100644
index 0000000..01d58a2

(Continue reading)

headers

Scott Wood | 10 Aug 2012 21:40

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> +static const struct of_device_id mpic_timer_ids[] = {
> +	{ .compatible = "open-pic,global-timer", },
> +	{ .compatible = "fsl,global-timer", },
> +	{},
> +};
> +
> +static int __init mpic_timer_init(void)
> +{
> +	struct device_node *np = NULL;
> +
> +	for_each_node_by_type(np, "open-pic")
> +		if (of_match_node(mpic_timer_ids, np))
> +			group_init(np);
> +
> +	if (list_empty(&group_list))
> +		return -ENODEV;
> +
> +	return 0;
> +}
> +arch_initcall(mpic_timer_init);
> 

Where do you distinguish an FSL timer from an openpic timer?  I thought
openpic timers didn't support cascading.

Oh, and don't probe by device_type.

-Scott

(Continue reading)

headers

Gala Kumar-B11780 | 10 Aug 2012 22:24

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support


On Aug 10, 2012, at 2:40 PM, Scott Wood wrote:

> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
>> +static const struct of_device_id mpic_timer_ids[] = {
>> +	{ .compatible = "open-pic,global-timer", },
>> +	{ .compatible = "fsl,global-timer", },
>> +	{},
>> +};
>> +
>> +static int __init mpic_timer_init(void)
>> +{
>> +	struct device_node *np = NULL;
>> +
>> +	for_each_node_by_type(np, "open-pic")
>> +		if (of_match_node(mpic_timer_ids, np))
>> +			group_init(np);
>> +
>> +	if (list_empty(&group_list))
>> +		return -ENODEV;
>> +
>> +	return 0;
>> +}
>> +arch_initcall(mpic_timer_init);
>> 
> 
> Where do you distinguish an FSL timer from an openpic timer?  I thought
> openpic timers didn't support cascading.

in group_init()

(Continue reading)

headers

Gala Kumar-B11780 | 10 Aug 2012 22:24

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support


On Aug 10, 2012, at 2:40 PM, Scott Wood wrote:

> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
>> +static const struct of_device_id mpic_timer_ids[] = {
>> +	{ .compatible = "open-pic,global-timer", },
>> +	{ .compatible = "fsl,global-timer", },
>> +	{},
>> +};
>> +
>> +static int __init mpic_timer_init(void)
>> +{
>> +	struct device_node *np = NULL;
>> +
>> +	for_each_node_by_type(np, "open-pic")
>> +		if (of_match_node(mpic_timer_ids, np))
>> +			group_init(np);
>> +
>> +	if (list_empty(&group_list))
>> +		return -ENODEV;
>> +
>> +	return 0;
>> +}
>> +arch_initcall(mpic_timer_init);
>> 
> 
> Where do you distinguish an FSL timer from an openpic timer?  I thought
> openpic timers didn't support cascading.

in group_init()

(Continue reading)

headers

Wang Dongsheng-B40534 | 13 Aug 2012 07:53

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, August 11, 2012 3:40 AM
> To: Wang Dongsheng-B40534
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> > +static const struct of_device_id mpic_timer_ids[] = {
> > +	{ .compatible = "open-pic,global-timer", },
> > +	{ .compatible = "fsl,global-timer", },
> > +	{},
> > +};
> > +
> > +static int __init mpic_timer_init(void) {
> > +	struct device_node *np = NULL;
> > +
> > +	for_each_node_by_type(np, "open-pic")
> > +		if (of_match_node(mpic_timer_ids, np))
> > +			group_init(np);
> > +
> > +	if (list_empty(&group_list))
> > +		return -ENODEV;
> > +
> > +	return 0;
> > +}
> > +arch_initcall(mpic_timer_init);
>

(Continue reading)

headers

Li Yang-R58472 | 13 Aug 2012 08:17

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wang Dongsheng-B40534
> Sent: Monday, August 13, 2012 1:54 PM
> To: Wood Scott-B07421
> Cc: benh@...;
paulus@...; linuxppc-
> dev@...; Gala Kumar-B11780; Li Yang-R58472
> Subject: RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, August 11, 2012 3:40 AM
> > To: Wang Dongsheng-B40534
> > Cc: benh@...;
paulus@...; linuxppc-
> > dev@...; Gala Kumar-B11780; Li Yang-R58472
> > Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >
> > On 08/10/2012 12:54 AM, Dongsheng.wang@... wrote:
> > > +static const struct of_device_id mpic_timer_ids[] = {
> > > +	{ .compatible = "open-pic,global-timer", },
> > > +	{ .compatible = "fsl,global-timer", },
> > > +	{},
> > > +};
> > > +
> > > +static int __init mpic_timer_init(void) {
> > > +	struct device_node *np = NULL;

(Continue reading)

headers

Li Yang-R58472 | 13 Aug 2012 08:17

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wang Dongsheng-B40534
> Sent: Monday, August 13, 2012 1:54 PM
> To: Wood Scott-B07421
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Saturday, August 11, 2012 3:40 AM
> > To: Wang Dongsheng-B40534
> > Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> > dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> > Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >
> > On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> > > +static const struct of_device_id mpic_timer_ids[] = {
> > > +	{ .compatible = "open-pic,global-timer", },
> > > +	{ .compatible = "fsl,global-timer", },
> > > +	{},
> > > +};
> > > +
> > > +static int __init mpic_timer_init(void) {
> > > +	struct device_node *np = NULL;
> > > +
> > > +	for_each_node_by_type(np, "open-pic")

(Continue reading)

headers

Scott Wood | 13 Aug 2012 18:49

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 12:53 AM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Saturday, August 11, 2012 3:40 AM
>> To: Wang Dongsheng-B40534
>> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
>> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
>>> +static const struct of_device_id mpic_timer_ids[] = {
>>> +	{ .compatible = "open-pic,global-timer", },
>>> +	{ .compatible = "fsl,global-timer", },
>>> +	{},
>>> +};
>>> +
>>> +static int __init mpic_timer_init(void) {
>>> +	struct device_node *np = NULL;
>>> +
>>> +	for_each_node_by_type(np, "open-pic")
>>> +		if (of_match_node(mpic_timer_ids, np))
>>> +			group_init(np);
>>> +
>>> +	if (list_empty(&group_list))
>>> +		return -ENODEV;
>>> +
>>> +	return 0;
>>> +}

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:06

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 12:49 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 12:53 AM, Wang Dongsheng-B40534 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Saturday, August 11, 2012 3:40 AM
> >> To: Wang Dongsheng-B40534
> >> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> >> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >>
> >> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> >>> +static const struct of_device_id mpic_timer_ids[] = {
> >>> +	{ .compatible = "open-pic,global-timer", },
> >>> +	{ .compatible = "fsl,global-timer", },
> >>> +	{},
> >>> +};
> >>> +
> >>> +static int __init mpic_timer_init(void) {
> >>> +	struct device_node *np = NULL;
> >>> +

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:06

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 12:49 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 12:53 AM, Wang Dongsheng-B40534 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Saturday, August 11, 2012 3:40 AM
> >> To: Wang Dongsheng-B40534
> >> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> >> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >>
> >> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> >>> +static const struct of_device_id mpic_timer_ids[] = {
> >>> +	{ .compatible = "open-pic,global-timer", },
> >>> +	{ .compatible = "fsl,global-timer", },
> >>> +	{},
> >>> +};
> >>> +
> >>> +static int __init mpic_timer_init(void) {
> >>> +	struct device_node *np = NULL;
> >>> +

(Continue reading)

headers

Scott Wood | 13 Aug 2012 18:49

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 12:53 AM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Saturday, August 11, 2012 3:40 AM
>> To: Wang Dongsheng-B40534
>> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
>> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
>>> +static const struct of_device_id mpic_timer_ids[] = {
>>> +	{ .compatible = "open-pic,global-timer", },
>>> +	{ .compatible = "fsl,global-timer", },
>>> +	{},
>>> +};
>>> +
>>> +static int __init mpic_timer_init(void) {
>>> +	struct device_node *np = NULL;
>>> +
>>> +	for_each_node_by_type(np, "open-pic")
>>> +		if (of_match_node(mpic_timer_ids, np))
>>> +			group_init(np);
>>> +
>>> +	if (list_empty(&group_list))
>>> +		return -ENODEV;
>>> +
>>> +	return 0;
>>> +}

(Continue reading)

headers

Wang Dongsheng-B40534 | 13 Aug 2012 07:53

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, August 11, 2012 3:40 AM
> To: Wang Dongsheng-B40534
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> > +static const struct of_device_id mpic_timer_ids[] = {
> > +	{ .compatible = "open-pic,global-timer", },
> > +	{ .compatible = "fsl,global-timer", },
> > +	{},
> > +};
> > +
> > +static int __init mpic_timer_init(void) {
> > +	struct device_node *np = NULL;
> > +
> > +	for_each_node_by_type(np, "open-pic")
> > +		if (of_match_node(mpic_timer_ids, np))
> > +			group_init(np);
> > +
> > +	if (list_empty(&group_list))
> > +		return -ENODEV;
> > +
> > +	return 0;
> > +}
> > +arch_initcall(mpic_timer_init);
>

(Continue reading)

headers

Scott Wood | 10 Aug 2012 21:40

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> +static const struct of_device_id mpic_timer_ids[] = {
> +	{ .compatible = "open-pic,global-timer", },
> +	{ .compatible = "fsl,global-timer", },
> +	{},
> +};
> +
> +static int __init mpic_timer_init(void)
> +{
> +	struct device_node *np = NULL;
> +
> +	for_each_node_by_type(np, "open-pic")
> +		if (of_match_node(mpic_timer_ids, np))
> +			group_init(np);
> +
> +	if (list_empty(&group_list))
> +		return -ENODEV;
> +
> +	return 0;
> +}
> +arch_initcall(mpic_timer_init);
> 

Where do you distinguish an FSL timer from an openpic timer?  I thought
openpic timers didn't support cascading.

Oh, and don't probe by device_type.

-Scott

(Continue reading)

headers

Scott Wood | 10 Aug 2012 22:37

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> +static int group_get_freq(struct group_priv *priv)
> +{
> +	if (priv->flags & FSL_GLOBAL_TIMER) {
> +		ccbfreq = fsl_get_sys_freq();
> +		priv->timerfreq = ccbfreq;
> +	} else {
> +		priv->timerfreq = in_be32(priv->group_tfrr);
> +	}

FSL MPICs have TFRR too.  I'm not sure that the lack of fsl,mpic is a
good indication that TFRR is being set (e.g. we have old device trees
for FSL chips with U-Boot that are labelled as ordinary openpics).

> +
> +	if (priv->timerfreq <= 0)
> +		return -EINVAL;
> +
> +	return 0;
> +}

timerfreq is unsigned.  It can never be < 0.

> +
> +static int group_init_regmap(struct device_node *np, struct group_priv *priv)
> +{
> +	priv->group_tfrr = of_iomap(np, 0);
> +	if (!priv->group_tfrr) {
> +		pr_err("%s: cannot ioremap tfrr address.\n",
> +				np->full_name);

(Continue reading)

headers

Wang Dongsheng-B40534 | 13 Aug 2012 08:18

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, August 11, 2012 4:38 AM
> To: Wang Dongsheng-B40534
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> > +static int group_get_freq(struct group_priv *priv) {
> > +	if (priv->flags & FSL_GLOBAL_TIMER) {
> > +		ccbfreq = fsl_get_sys_freq();
> > +		priv->timerfreq = ccbfreq;
> > +	} else {
> > +		priv->timerfreq = in_be32(priv->group_tfrr);
> > +	}
> 
> FSL MPICs have TFRR too.  I'm not sure that the lack of fsl,mpic is a
> good indication that TFRR is being set (e.g. we have old device trees for
> FSL chips with U-Boot that are labelled as ordinary openpics).
> 
[Wang Dongsheng] yes, we have. But we do not used it. The TFRR register value
is zero. 

> > +
> > +	if (priv->timerfreq <= 0)
> > +		return -EINVAL;
> > +
> > +	return 0;

(Continue reading)

headers

Scott Wood | 13 Aug 2012 19:36

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>> +	p = of_get_property(np, "available-ranges", &len);
>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>> +				np->full_name);
>>> +		return -EINVAL;
>>> +	}
>>
>> You need to support fsl,available-ranges since that's in an accepted
>> binding and people could have partitioned setups already using it.
>>
> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group)
> in each group only four timer. This is unified. So i use a generic name.
> I think there is not compatible with existing mpic timer nodes.

We need to be compatible with existing trees, so you'd need to check for
both -- but I think any further discussion of the details is premature
until we decide whether this is worthwhile to begin with (both the
support of non-FSL timers, and the creation of a new device tree binding
which will not be implemented by many of the machines that have non-FSL
openpic because they run real Open Firmware).

-Scott

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:00

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 1:37 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
> >>> +	p = of_get_property(np, "available-ranges", &len);
> >>> +	if (p && len % (2 * sizeof(u32)) != 0) {
> >>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
> >>> +				np->full_name);
> >>> +		return -EINVAL;
> >>> +	}
> >>
> >> You need to support fsl,available-ranges since that's in an accepted
> >> binding and people could have partitioned setups already using it.
> >>
> > [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group) in
> > each group only four timer. This is unified. So i use a generic name.
> > I think there is not compatible with existing mpic timer nodes.
> 
> We need to be compatible with existing trees, so you'd need to check for
> both -- but I think any further discussion of the details is premature
> until we decide whether this is worthwhile to begin with (both the
> support of non-FSL timers, and the creation of a new device tree binding
> which will not be implemented by many of the machines that have non-FSL
> openpic because they run real Open Firmware).

(Continue reading)

headers

Scott Wood | 14 Aug 2012 04:05

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 1:37 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>>>> +	p = of_get_property(np, "available-ranges", &len);
>>>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>>>> +				np->full_name);
>>>>> +		return -EINVAL;
>>>>> +	}
>>>>
>>>> You need to support fsl,available-ranges since that's in an accepted
>>>> binding and people could have partitioned setups already using it.
>>>>
>>> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group) in
>>> each group only four timer. This is unified. So i use a generic name.
>>> I think there is not compatible with existing mpic timer nodes.
>>
>> We need to be compatible with existing trees, so you'd need to check for
>> both -- but I think any further discussion of the details is premature
>> until we decide whether this is worthwhile to begin with (both the
>> support of non-FSL timers, and the creation of a new device tree binding

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:15

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 10:05 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Tuesday, August 14, 2012 1:37 AM
> >> To: Wang Dongsheng-B40534
> >> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> >> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >>
> >> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
> >>>>> +	p = of_get_property(np, "available-ranges", &len);
> >>>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
> >>>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
> >>>>> +				np->full_name);
> >>>>> +		return -EINVAL;
> >>>>> +	}
> >>>>
> >>>> You need to support fsl,available-ranges since that's in an
> >>>> accepted binding and people could have partitioned setups already

(Continue reading)

headers

Scott Wood | 14 Aug 2012 04:18

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 10:05 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Tuesday, August 14, 2012 1:37 AM
>>>> To: Wang Dongsheng-B40534
>>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>>>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>>>
>>>> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>>>>>> +	p = of_get_property(np, "available-ranges", &len);
>>>>>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>>>>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>>>>>> +				np->full_name);
>>>>>>> +		return -EINVAL;
>>>>>>> +	}
>>>>>>

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:32

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 10:19 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Tuesday, August 14, 2012 10:05 AM
> >> To: Wang Dongsheng-B40534
> >> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> >> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >>
> >> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Wood Scott-B07421
> >>>> Sent: Tuesday, August 14, 2012 1:37 AM
> >>>> To: Wang Dongsheng-B40534
> >>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> >>>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

(Continue reading)

headers

Scott Wood | 14 Aug 2012 23:20

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 09:32 PM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 10:19 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Tuesday, August 14, 2012 10:05 AM
>>>> To: Wang Dongsheng-B40534
>>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>>>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>>>
>>>> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Wood Scott-B07421
>>>>>> Sent: Tuesday, August 14, 2012 1:37 AM
>>>>>> To: Wang Dongsheng-B40534
>>>>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;

(Continue reading)

headers

Scott Wood | 14 Aug 2012 23:20

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 09:32 PM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 10:19 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Tuesday, August 14, 2012 10:05 AM
>>>> To: Wang Dongsheng-B40534
>>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>>>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>>>
>>>> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Wood Scott-B07421
>>>>>> Sent: Tuesday, August 14, 2012 1:37 AM
>>>>>> To: Wang Dongsheng-B40534
>>>>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:32

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 10:19 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Tuesday, August 14, 2012 10:05 AM
> >> To: Wang Dongsheng-B40534
> >> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> >> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >>
> >> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Wood Scott-B07421
> >>>> Sent: Tuesday, August 14, 2012 1:37 AM
> >>>> To: Wang Dongsheng-B40534
> >>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> >>>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

(Continue reading)

headers

Scott Wood | 14 Aug 2012 04:18

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 09:15 PM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 10:05 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Tuesday, August 14, 2012 1:37 AM
>>>> To: Wang Dongsheng-B40534
>>>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>>>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>>>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>>>
>>>> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>>>>>> +	p = of_get_property(np, "available-ranges", &len);
>>>>>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>>>>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>>>>>> +				np->full_name);
>>>>>>> +		return -EINVAL;
>>>>>>> +	}
>>>>>>

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:15

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 10:05 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Tuesday, August 14, 2012 1:37 AM
> >> To: Wang Dongsheng-B40534
> >> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> >> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> >> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >>
> >> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
> >>>>> +	p = of_get_property(np, "available-ranges", &len);
> >>>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
> >>>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
> >>>>> +				np->full_name);
> >>>>> +		return -EINVAL;
> >>>>> +	}
> >>>>
> >>>> You need to support fsl,available-ranges since that's in an
> >>>> accepted binding and people could have partitioned setups already

(Continue reading)

headers

Scott Wood | 14 Aug 2012 04:05

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 09:00 PM, Wang Dongsheng-B40534 wrote:
> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Tuesday, August 14, 2012 1:37 AM
>> To: Wang Dongsheng-B40534
>> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
>> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>>>> +	p = of_get_property(np, "available-ranges", &len);
>>>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>>>> +				np->full_name);
>>>>> +		return -EINVAL;
>>>>> +	}
>>>>
>>>> You need to support fsl,available-ranges since that's in an accepted
>>>> binding and people could have partitioned setups already using it.
>>>>
>>> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group) in
>>> each group only four timer. This is unified. So i use a generic name.
>>> I think there is not compatible with existing mpic timer nodes.
>>
>> We need to be compatible with existing trees, so you'd need to check for
>> both -- but I think any further discussion of the details is premature
>> until we decide whether this is worthwhile to begin with (both the
>> support of non-FSL timers, and the creation of a new device tree binding

(Continue reading)

headers

Wang Dongsheng-B40534 | 14 Aug 2012 04:00

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 14, 2012 1:37 AM
> To: Wang Dongsheng-B40534
> Cc: Wood Scott-B07421; benh <at> kernel.crashing.org; paulus <at> samba.org;
> linuxppc-dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
> >>> +	p = of_get_property(np, "available-ranges", &len);
> >>> +	if (p && len % (2 * sizeof(u32)) != 0) {
> >>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
> >>> +				np->full_name);
> >>> +		return -EINVAL;
> >>> +	}
> >>
> >> You need to support fsl,available-ranges since that's in an accepted
> >> binding and people could have partitioned setups already using it.
> >>
> > [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group) in
> > each group only four timer. This is unified. So i use a generic name.
> > I think there is not compatible with existing mpic timer nodes.
> 
> We need to be compatible with existing trees, so you'd need to check for
> both -- but I think any further discussion of the details is premature
> until we decide whether this is worthwhile to begin with (both the
> support of non-FSL timers, and the creation of a new device tree binding
> which will not be implemented by many of the machines that have non-FSL
> openpic because they run real Open Firmware).

(Continue reading)

headers

Scott Wood | 13 Aug 2012 19:36

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/13/2012 01:18 AM, Wang Dongsheng-B40534 wrote:
>>> +	p = of_get_property(np, "available-ranges", &len);
>>> +	if (p && len % (2 * sizeof(u32)) != 0) {
>>> +		pr_err("%s: malformed fsl,available-ranges property.\n",
>>> +				np->full_name);
>>> +		return -EINVAL;
>>> +	}
>>
>> You need to support fsl,available-ranges since that's in an accepted
>> binding and people could have partitioned setups already using it.
>>
> [Wang Dongsheng] FSL chip or OPEN-PIC specification(Only a group)
> in each group only four timer. This is unified. So i use a generic name.
> I think there is not compatible with existing mpic timer nodes.

We need to be compatible with existing trees, so you'd need to check for
both -- but I think any further discussion of the details is premature
until we decide whether this is worthwhile to begin with (both the
support of non-FSL timers, and the creation of a new device tree binding
which will not be implemented by many of the machines that have non-FSL
openpic because they run real Open Firmware).

-Scott

headers

Wang Dongsheng-B40534 | 13 Aug 2012 08:18

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, August 11, 2012 4:38 AM
> To: Wang Dongsheng-B40534
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; linuxppc-
> dev <at> lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> > +static int group_get_freq(struct group_priv *priv) {
> > +	if (priv->flags & FSL_GLOBAL_TIMER) {
> > +		ccbfreq = fsl_get_sys_freq();
> > +		priv->timerfreq = ccbfreq;
> > +	} else {
> > +		priv->timerfreq = in_be32(priv->group_tfrr);
> > +	}
> 
> FSL MPICs have TFRR too.  I'm not sure that the lack of fsl,mpic is a
> good indication that TFRR is being set (e.g. we have old device trees for
> FSL chips with U-Boot that are labelled as ordinary openpics).
> 
[Wang Dongsheng] yes, we have. But we do not used it. The TFRR register value
is zero. 

> > +
> > +	if (priv->timerfreq <= 0)
> > +		return -EINVAL;
> > +
> > +	return 0;

(Continue reading)

headers

Scott Wood | 10 Aug 2012 22:37

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On 08/10/2012 12:54 AM, Dongsheng.wang <at> freescale.com wrote:
> +static int group_get_freq(struct group_priv *priv)
> +{
> +	if (priv->flags & FSL_GLOBAL_TIMER) {
> +		ccbfreq = fsl_get_sys_freq();
> +		priv->timerfreq = ccbfreq;
> +	} else {
> +		priv->timerfreq = in_be32(priv->group_tfrr);
> +	}

FSL MPICs have TFRR too.  I'm not sure that the lack of fsl,mpic is a
good indication that TFRR is being set (e.g. we have old device trees
for FSL chips with U-Boot that are labelled as ordinary openpics).

> +
> +	if (priv->timerfreq <= 0)
> +		return -EINVAL;
> +
> +	return 0;
> +}

timerfreq is unsigned.  It can never be < 0.

> +
> +static int group_init_regmap(struct device_node *np, struct group_priv *priv)
> +{
> +	priv->group_tfrr = of_iomap(np, 0);
> +	if (!priv->group_tfrr) {
> +		pr_err("%s: cannot ioremap tfrr address.\n",
> +				np->full_name);

(Continue reading)

headers

Tabi Timur-B04825 | 11 Aug 2012 15:10

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On Fri, Aug 10, 2012 at 12:54 AM,  <Dongsheng.wang <at> freescale.com> wrote:
> From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>

> +EXPORT_SYMBOL_GPL(mpic_request_timer);

Make these EXPORT_SYMBOL.  No need for a GPL restriction.

--

-- 
Timur Tabi
Linux kernel developer at Freescale

headers

Wang Dongsheng-B40534 | 13 Aug 2012 08:20

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Tabi Timur-B04825
> Sent: Saturday, August 11, 2012 9:10 PM
> To: Wang Dongsheng-B40534
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; Wood Scott-B07421; Gala
> Kumar-B11780; linuxppc-dev <at> lists.ozlabs.org
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On Fri, Aug 10, 2012 at 12:54 AM,  <Dongsheng.wang <at> freescale.com> wrote:
> > From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>
> 
> > +EXPORT_SYMBOL_GPL(mpic_request_timer);
> 
> Make these EXPORT_SYMBOL.  No need for a GPL restriction.
> 
[Wang Dongsheng] Why?
> --
> Timur Tabi
> Linux kernel developer at Freescale

headers

Wang Dongsheng-B40534 | 13 Aug 2012 08:25

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+b40534=freescale.com <at> lists.ozlabs.org] On Behalf Of Wang
> Dongsheng-B40534
> Sent: Monday, August 13, 2012 2:21 PM
> To: Tabi Timur-B04825
> Cc: Gala Kumar-B11780; paulus <at> samba.org; linuxppc-dev <at> lists.ozlabs.org;
> Wood Scott-B07421
> Subject: RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> 
> 
> > -----Original Message-----
> > From: Tabi Timur-B04825
> > Sent: Saturday, August 11, 2012 9:10 PM
> > To: Wang Dongsheng-B40534
> > Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; Wood Scott-B07421;
> > Gala Kumar-B11780; linuxppc-dev <at> lists.ozlabs.org
> > Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >
> > On Fri, Aug 10, 2012 at 12:54 AM,  <Dongsheng.wang <at> freescale.com> wrote:
> > > From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>
> >
> > > +EXPORT_SYMBOL_GPL(mpic_request_timer);
> >
> > Make these EXPORT_SYMBOL.  No need for a GPL restriction.
> >
> [Wang Dongsheng] Why?
[Wang Dongsheng] Sorry, I just see the mail. Thanks.

(Continue reading)

headers

Wang Dongsheng-B40534 | 13 Aug 2012 08:25

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Linuxppc-dev [mailto:linuxppc-dev-
> bounces+b40534=freescale.com <at> lists.ozlabs.org] On Behalf Of Wang
> Dongsheng-B40534
> Sent: Monday, August 13, 2012 2:21 PM
> To: Tabi Timur-B04825
> Cc: Gala Kumar-B11780; paulus <at> samba.org; linuxppc-dev <at> lists.ozlabs.org;
> Wood Scott-B07421
> Subject: RE: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> 
> 
> > -----Original Message-----
> > From: Tabi Timur-B04825
> > Sent: Saturday, August 11, 2012 9:10 PM
> > To: Wang Dongsheng-B40534
> > Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; Wood Scott-B07421;
> > Gala Kumar-B11780; linuxppc-dev <at> lists.ozlabs.org
> > Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> >
> > On Fri, Aug 10, 2012 at 12:54 AM,  <Dongsheng.wang <at> freescale.com> wrote:
> > > From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>
> >
> > > +EXPORT_SYMBOL_GPL(mpic_request_timer);
> >
> > Make these EXPORT_SYMBOL.  No need for a GPL restriction.
> >
> [Wang Dongsheng] Why?
[Wang Dongsheng] Sorry, I just see the mail. Thanks.

(Continue reading)

headers

Wang Dongsheng-B40534 | 13 Aug 2012 08:20

RE: [PATCH v2 2/2] powerpc/mpic: add global timer support


> -----Original Message-----
> From: Tabi Timur-B04825
> Sent: Saturday, August 11, 2012 9:10 PM
> To: Wang Dongsheng-B40534
> Cc: benh <at> kernel.crashing.org; paulus <at> samba.org; Wood Scott-B07421; Gala
> Kumar-B11780; linuxppc-dev <at> lists.ozlabs.org
> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
> 
> On Fri, Aug 10, 2012 at 12:54 AM,  <Dongsheng.wang <at> freescale.com> wrote:
> > From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>
> 
> > +EXPORT_SYMBOL_GPL(mpic_request_timer);
> 
> Make these EXPORT_SYMBOL.  No need for a GPL restriction.
> 
[Wang Dongsheng] Why?
> --
> Timur Tabi
> Linux kernel developer at Freescale

headers

Tabi Timur-B04825 | 11 Aug 2012 15:10

Re: [PATCH v2 2/2] powerpc/mpic: add global timer support

On Fri, Aug 10, 2012 at 12:54 AM,  <Dongsheng.wang <at> freescale.com> wrote:
> From: Wang Dongsheng <Dongsheng.Wang <at> freescale.com>

> +EXPORT_SYMBOL_GPL(mpic_request_timer);

Make these EXPORT_SYMBOL.  No need for a GPL restriction.

--

-- 
Timur Tabi
Linux kernel developer at Freescale