gmane.linux.power-management.general

[PATCH] sky2: Fix recent WOL regression

From: Rafael J. Wysocki <rjw <at> sisk.pl>

sky2: Fix recent WOL regression

Since dev->power.should_wakeup bit is used by the PCI core to
decide whether the device should wake up the system from sleep
states, set/unset this bit whenever WOL is enabled/disabled using
sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
machine).

Remove an open-coded reference to the standard PCI PM registers that
is not used any more.

Signed-off-by: Rafael J. Wysocki <rjw <at> sisk.pl>
Reported-by: Tino Keitel <tino.keitel <at> gmx.de>
---

 drivers/net/sky2.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/net/sky2.c
===================================================================
--- linux-2.6.orig/drivers/net/sky2.c
+++ linux-2.6/drivers/net/sky2.c
@@ -3034,7 +3034,8 @@ static int sky2_set_wol(struct net_devic
 	struct sky2_port *sky2 = netdev_priv(dev);
 	struct sky2_hw *hw = sky2->hw;

-	if (wol->wolopts & ~sky2_wol_supported(sky2->hw))
+	if ((wol->wolopts & ~sky2_wol_supported(sky2->hw))

(Continue reading)

headers

Stephen Hemminger | 3 Oct 09:02

Re: [PATCH] sky2: Fix recent WOL regression

On Thu, 2 Oct 2008 23:39:33 +0200
"Rafael J. Wysocki" <rjw <at> sisk.pl> wrote:

> From: Rafael J. Wysocki <rjw <at> sisk.pl>
> 
> sky2: Fix recent WOL regression
> 
> Since dev->power.should_wakeup bit is used by the PCI core to
> decide whether the device should wake up the system from sleep
> states, set/unset this bit whenever WOL is enabled/disabled using
> sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> machine).
> 
> Remove an open-coded reference to the standard PCI PM registers that
> is not used any more.
> 
> Signed-off-by: Rafael J. Wysocki <rjw <at> sisk.pl>
> Reported-by: Tino Keitel <tino.keitel <at> gmx.de>
> ---

Acked-by: Stephen Hemminger <shemminger <at> vyatta.com>

Thanks for fixing this.

headers

Rafael J. Wysocki | 9 Oct 00:55

Re: [PATCH] sky2: Fix recent WOL regression

On Friday, 3 of October 2008, Stephen Hemminger wrote:
> On Thu, 2 Oct 2008 23:39:33 +0200
> "Rafael J. Wysocki" <rjw <at> sisk.pl> wrote:
> 
> > From: Rafael J. Wysocki <rjw <at> sisk.pl>
> > 
> > sky2: Fix recent WOL regression
> > 
> > Since dev->power.should_wakeup bit is used by the PCI core to
> > decide whether the device should wake up the system from sleep
> > states, set/unset this bit whenever WOL is enabled/disabled using
> > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > machine).
> > 
> > Remove an open-coded reference to the standard PCI PM registers that
> > is not used any more.
> > 
> > Signed-off-by: Rafael J. Wysocki <rjw <at> sisk.pl>
> > Reported-by: Tino Keitel <tino.keitel <at> gmx.de>
> > ---
> 
> Acked-by: Stephen Hemminger <shemminger <at> vyatta.com>
> 
> Thanks for fixing this.

Can you please include this patch into your next push for Jeff?

It seems to have been overlooked.

Thanks,

(Continue reading)

headers

David Miller | 9 Oct 01:12

Re: [PATCH] sky2: Fix recent WOL regression

From: "Rafael J. Wysocki" <rjw <at> sisk.pl>
Date: Thu, 9 Oct 2008 00:55:55 +0200

> On Friday, 3 of October 2008, Stephen Hemminger wrote:
> > On Thu, 2 Oct 2008 23:39:33 +0200
> > "Rafael J. Wysocki" <rjw <at> sisk.pl> wrote:
> > 
> > > From: Rafael J. Wysocki <rjw <at> sisk.pl>
> > > 
> > > sky2: Fix recent WOL regression
> > > 
> > > Since dev->power.should_wakeup bit is used by the PCI core to
> > > decide whether the device should wake up the system from sleep
> > > states, set/unset this bit whenever WOL is enabled/disabled using
> > > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > > machine).
> > > 
> > > Remove an open-coded reference to the standard PCI PM registers that
> > > is not used any more.
> > > 
> > > Signed-off-by: Rafael J. Wysocki <rjw <at> sisk.pl>
> > > Reported-by: Tino Keitel <tino.keitel <at> gmx.de>
> > > ---
> > 
> > Acked-by: Stephen Hemminger <shemminger <at> vyatta.com>
> > 
> > Thanks for fixing this.
> 
> Can you please include this patch into your next push for Jeff?
>

(Continue reading)

headers

Rafael J. Wysocki | 9 Oct 23:01

Re: [PATCH] sky2: Fix recent WOL regression

On Thursday, 9 of October 2008, David Miller wrote:
> From: "Rafael J. Wysocki" <rjw <at> sisk.pl>
> Date: Thu, 9 Oct 2008 00:55:55 +0200
> 
> > On Friday, 3 of October 2008, Stephen Hemminger wrote:
> > > On Thu, 2 Oct 2008 23:39:33 +0200
> > > "Rafael J. Wysocki" <rjw <at> sisk.pl> wrote:
> > > 
> > > > From: Rafael J. Wysocki <rjw <at> sisk.pl>
> > > > 
> > > > sky2: Fix recent WOL regression
> > > > 
> > > > Since dev->power.should_wakeup bit is used by the PCI core to
> > > > decide whether the device should wake up the system from sleep
> > > > states, set/unset this bit whenever WOL is enabled/disabled using
> > > > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > > > machine).
> > > > 
> > > > Remove an open-coded reference to the standard PCI PM registers that
> > > > is not used any more.
> > > > 
> > > > Signed-off-by: Rafael J. Wysocki <rjw <at> sisk.pl>
> > > > Reported-by: Tino Keitel <tino.keitel <at> gmx.de>
> > > > ---
> > > 
> > > Acked-by: Stephen Hemminger <shemminger <at> vyatta.com>
> > > 
> > > Thanks for fixing this.
> > 
> > Can you please include this patch into your next push for Jeff?

(Continue reading)