headers
Zhang Rui | 11 Jun 2012 05:20
Picon
Favicon

[RFC PATCH 3/12] thermal: set upper and lower limits when binding


Set upper and lower limits when binding
a thermal cooling device to a thermal zone device.

Signed-off-by: Zhang Rui <rui.zhang <at> intel.com>
---
 drivers/acpi/thermal.c         |   34 ++++++++++++++++++++++++----------
 drivers/platform/x86/acerhdf.c |    2 +-
 drivers/thermal/thermal_sys.c  |   20 ++++++++++++++------
 include/linux/thermal.h        |    3 ++-
 4 files changed, 41 insertions(+), 18 deletions(-)

Index: rtd3/drivers/thermal/thermal_sys.c
===================================================================
--- rtd3.orig/drivers/thermal/thermal_sys.c
+++ rtd3/drivers/thermal/thermal_sys.c
 <at>  <at>  -248,7 +248,7  <at>  <at>  passive_store(struct device *dev, struct
 				     sizeof("Processor")))
 				thermal_zone_bind_cooling_device(tz,
 								 THERMAL_TRIPS_NONE,
-								 cdev);
+								 cdev, -1, -1);
 		}
 		mutex_unlock(&thermal_list_lock);
 		if (!tz->passive_delay)
 <at>  <at>  -760,7 +760,8  <at>  <at>  static void thermal_zone_device_check(st
  */
 int thermal_zone_bind_cooling_device(struct thermal_zone_device *tz,
 				     int trip,
-				     struct thermal_cooling_device *cdev)
(Continue reading)

Permalink | Reply |
headers
Amit Kachhap | 11 Jun 2012 06:21
Favicon

Re: [RFC PATCH 3/12] thermal: set upper and lower limits when binding

Hi Rui,

I like this approach of multiple cooling states for ACTIVE type cooling devices.
Some comments added.

On 11 June 2012 08:50, Zhang Rui <rui.zhang <at> intel.com> wrote:
>
> Set upper and lower limits when binding
> a thermal cooling device to a thermal zone device.
>
> Signed-off-by: Zhang Rui <rui.zhang <at> intel.com>
> ---
>  drivers/acpi/thermal.c         |   34 ++++++++++++++++++++++++----------
>  drivers/platform/x86/acerhdf.c |    2 +-
>  drivers/thermal/thermal_sys.c  |   20 ++++++++++++++------
>  include/linux/thermal.h        |    3 ++-
>  4 files changed, 41 insertions(+), 18 deletions(-)
>
> Index: rtd3/drivers/thermal/thermal_sys.c
> ===================================================================
> --- rtd3.orig/drivers/thermal/thermal_sys.c
> +++ rtd3/drivers/thermal/thermal_sys.c
>  <at>  <at>  -248,7 +248,7  <at>  <at>  passive_store(struct device *dev, struct
>                                     sizeof("Processor")))
>                                thermal_zone_bind_cooling_device(tz,
>                                                                 THERMAL_TRIPS_NONE,
> -                                                                cdev);
> +                                                                cdev, -1, -1);
>                }
>                mutex_unlock(&thermal_list_lock);
(Continue reading)

Permalink | Reply |
headers
Amit Kachhap | 11 Jun 2012 06:27
Favicon

Re: [RFC PATCH 3/12] thermal: set upper and lower limits when binding

Hi Rui,

Sorry for sending one incomplete mail before.
I like this approach of multiple cooling states for ACTIVE type cooling devices.
Some comments added.

On 11 June 2012 08:50, Zhang Rui <rui.zhang <at> intel.com> wrote:
>
> Set upper and lower limits when binding
> a thermal cooling device to a thermal zone device.
>
> Signed-off-by: Zhang Rui <rui.zhang <at> intel.com>
> ---
>  drivers/acpi/thermal.c         |   34 ++++++++++++++++++++++++----------
>  drivers/platform/x86/acerhdf.c |    2 +-
>  drivers/thermal/thermal_sys.c  |   20 ++++++++++++++------
>  include/linux/thermal.h        |    3 ++-
>  4 files changed, 41 insertions(+), 18 deletions(-)
>
> Index: rtd3/drivers/thermal/thermal_sys.c
> ===================================================================
> --- rtd3.orig/drivers/thermal/thermal_sys.c
> +++ rtd3/drivers/thermal/thermal_sys.c
>  <at>  <at>  -248,7 +248,7  <at>  <at>  passive_store(struct device *dev, struct
>                                     sizeof("Processor")))
>                                thermal_zone_bind_cooling_device(tz,
>                                                                 THERMAL_TRIPS_NONE,
> -                                                                cdev);
> +                                                                cdev, -1, -1);
>                }
(Continue reading)

Permalink | Reply |
headers
Zhang Rui | 11 Jun 2012 08:30
Picon
Favicon

Re: [RFC PATCH 3/12] thermal: set upper and lower limits when binding

On 一, 2012-06-11 at 09:57 +0530, Amit Kachhap wrote:
> Hi Rui,
> 
> Sorry for sending one incomplete mail before.
> I like this approach of multiple cooling states for ACTIVE type cooling devices.

Great, thanks.

> Some comments added.
> On 11 June 2012 08:50, Zhang Rui <rui.zhang <at> intel.com> wrote:
> >
> > Set upper and lower limits when binding
> > a thermal cooling device to a thermal zone device.
> >
> > Signed-off-by: Zhang Rui <rui.zhang <at> intel.com>
> > ---
> >  drivers/acpi/thermal.c         |   34 ++++++++++++++++++++++++----------
> >  drivers/platform/x86/acerhdf.c |    2 +-
> >  drivers/thermal/thermal_sys.c  |   20 ++++++++++++++------
> >  include/linux/thermal.h        |    3 ++-
> >  4 files changed, 41 insertions(+), 18 deletions(-)
> >
> > Index: rtd3/drivers/thermal/thermal_sys.c
> > ===================================================================
> > --- rtd3.orig/drivers/thermal/thermal_sys.c
> > +++ rtd3/drivers/thermal/thermal_sys.c
> >  <at>  <at>  -248,7 +248,7  <at>  <at>  passive_store(struct device *dev, struct
> >                                     sizeof("Processor")))
> >                                thermal_zone_bind_cooling_device(tz,
> >                                                                 THERMAL_TRIPS_NONE,
(Continue reading)

Permalink | Reply |
headers
Eduardo Valentin | 12 Jun 2012 11:52
Picon
Favicon

Re: [RFC PATCH 3/12] thermal: set upper and lower limits when binding

Hello Rui,

On Mon, Jun 11, 2012 at 11:20:01AM +0800, Zhang Rui wrote:
> 
> Set upper and lower limits when binding
> a thermal cooling device to a thermal zone device.
> 
> Signed-off-by: Zhang Rui <rui.zhang <at> intel.com>
> ---
>  drivers/acpi/thermal.c         |   34 ++++++++++++++++++++++++----------
>  drivers/platform/x86/acerhdf.c |    2 +-
>  drivers/thermal/thermal_sys.c  |   20 ++++++++++++++------
>  include/linux/thermal.h        |    3 ++-
>  4 files changed, 41 insertions(+), 18 deletions(-)
> 
> Index: rtd3/drivers/thermal/thermal_sys.c
> ===================================================================
> --- rtd3.orig/drivers/thermal/thermal_sys.c
> +++ rtd3/drivers/thermal/thermal_sys.c
>  <at>  <at>  -248,7 +248,7  <at>  <at>  passive_store(struct device *dev, struct
>  				     sizeof("Processor")))
>  				thermal_zone_bind_cooling_device(tz,
>  								 THERMAL_TRIPS_NONE,
> -								 cdev);
> +								 cdev, -1, -1);
>  		}
>  		mutex_unlock(&thermal_list_lock);
>  		if (!tz->passive_delay)
>  <at>  <at>  -760,7 +760,8  <at>  <at>  static void thermal_zone_device_check(st
>   */
(Continue reading)

Permalink | Reply |
headers
Zhang Rui | 13 Jun 2012 02:51
Picon
Favicon

Re: [RFC PATCH 3/12] thermal: set upper and lower limits when binding

On 二, 2012-06-12 at 12:52 +0300, Eduardo Valentin wrote:
> Hello Rui,
> 
> On Mon, Jun 11, 2012 at 11:20:01AM +0800, Zhang Rui wrote:
> > 
> > Set upper and lower limits when binding
> > a thermal cooling device to a thermal zone device.
> > 
> > Signed-off-by: Zhang Rui <rui.zhang <at> intel.com>
> > ---
> >  drivers/acpi/thermal.c         |   34 ++++++++++++++++++++++++----------
> >  drivers/platform/x86/acerhdf.c |    2 +-
> >  drivers/thermal/thermal_sys.c  |   20 ++++++++++++++------
> >  include/linux/thermal.h        |    3 ++-
> >  4 files changed, 41 insertions(+), 18 deletions(-)
> > 
> > Index: rtd3/drivers/thermal/thermal_sys.c
> > ===================================================================
> > --- rtd3.orig/drivers/thermal/thermal_sys.c
> > +++ rtd3/drivers/thermal/thermal_sys.c
> >  <at>  <at>  -248,7 +248,7  <at>  <at>  passive_store(struct device *dev, struct
> >  				     sizeof("Processor")))
> >  				thermal_zone_bind_cooling_device(tz,
> >  								 THERMAL_TRIPS_NONE,
> > -								 cdev);
> > +								 cdev, -1, -1);
> >  		}
> >  		mutex_unlock(&thermal_list_lock);
> >  		if (!tz->passive_delay)
> >  <at>  <at>  -760,7 +760,8  <at>  <at>  static void thermal_zone_device_check(st
(Continue reading)

Permalink | Reply |

Gmane